Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Generation of data catalog #4957

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Initial Generation of data catalog #4957

merged 2 commits into from
Apr 17, 2019

Conversation

sduskis
Copy link
Contributor

@sduskis sduskis commented Apr 16, 2019

No description provided.

@sduskis sduskis requested a review from a team as a code owner April 16, 2019 14:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2019
kolea2
kolea2 reviewed Apr 16, 2019
View reviewed changes
google-api-grpc/pom.xml Outdated
@@ -777,7 +777,7 @@
<module>grpc-google-cloud-bigtable-v2</module>
<module>grpc-google-cloud-container-v1</module>
<module>grpc-google-cloud-containeranalysis-v1beta1</module>
<module>grpc-google-cloud-datalabeling-v1beta1</module>
<module>grpc-google-cloud-datacatalog-v1beta1</module><module>grpc-google-cloud-datalabeling-v1beta1</module>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

kolea2
kolea2 reviewed Apr 16, 2019
View reviewed changes
google-api-grpc/pom.xml Outdated
@@ -840,7 +840,7 @@
<module>proto-google-cloud-bigtable-v2</module>
<module>proto-google-cloud-container-v1</module>
<module>proto-google-cloud-containeranalysis-v1beta1</module>
<module>proto-google-cloud-datalabeling-v1beta1</module>
<module>proto-google-cloud-datacatalog-v1beta1</module><module>proto-google-cloud-datalabeling-v1beta1</module>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

kolea2
kolea2 reviewed Apr 16, 2019
View reviewed changes
google-cloud-bom/pom.xml Outdated
@@ -1045,7 +1045,7 @@
<artifactId>google-cloud-webrisk</artifactId>
<version>0.2.1-alpha-SNAPSHOT</version><!--{x-version-update:google-cloud-webrisk:current}-->
</dependency>
</dependencies>
<dependency><groupId>com.google.api.grpc</groupId><artifactId>proto-google-cloud-datacatalog-v1beta1</artifactId><version>0.0.1-alpha-SNAPSHOT</version><!--{x-version-update:proto-google-cloud-datacatalog-v1beta1:current}--></dependency><dependency><groupId>com.google.api.grpc</groupId><artifactId>grpc-google-cloud-datacatalog-v1beta1</artifactId><version>0.0.1-alpha-SNAPSHOT</version><!--{x-version-update:grpc-google-cloud-datacatalog-v1beta1:current}--></dependency><dependency><groupId>com.google.cloud</groupId><artifactId>google-cloud-datacatalog</artifactId><version>0.0.1-alpha-SNAPSHOT</version><!--{x-version-update:google-cloud-datacatalog:current}--></dependency></dependencies>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

@sduskis
Copy link
Contributor Author

sduskis commented Apr 17, 2019

@kolea2, this should be ready to go.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #4957 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4957      +/-   ##
============================================
- Coverage     50.36%   50.32%   -0.04%     
  Complexity    23665    23665              
============================================
  Files          2233     2238       +5     
  Lines        225856   226045     +189     
  Branches      24956    24957       +1     
============================================
+ Hits         113742   113751       +9     
- Misses       103517   103697     +180     
  Partials       8597     8597
Impacted Files Coverage Δ Complexity Δ
...e/cloud/datacatalog/v1beta1/DataCatalogClient.java 0% <0%> (ø) 0 <0> (?)
.../datacatalog/v1beta1/stub/GrpcDataCatalogStub.java 0% <0%> (ø) 0 <0> (?)
...g/v1beta1/stub/GrpcDataCatalogCallableFactory.java 0% <0%> (ø) 0 <0> (?)
...acatalog/v1beta1/stub/DataCatalogStubSettings.java 0% <0%> (ø) 0 <0> (?)
...cloud/datacatalog/v1beta1/DataCatalogSettings.java 0% <0%> (ø) 0 <0> (?)
...loud/datacatalog/v1beta1/stub/DataCatalogStub.java 0% <0%> (ø) 0 <0> (?)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 86.48% <0%> (-0.08%) 22% <0%> (ø)
...cloud/pubsub/v1/StreamingSubscriberConnection.java 64.75% <0%> (ø) 9% <0%> (ø) ⬇️
...ava/com/google/cloud/pubsub/v1/PublisherStats.java
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8c8d6...b50b9b3. Read the comment docs.

@kolea2 kolea2 merged commit 34ca53d into googleapis:master Apr 17, 2019
@kolea2 kolea2 mentioned this pull request Apr 17, 2019
Merged
@sduskis sduskis deleted the datacatalog_gen1 branch April 22, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sduskis @kolea2 @googlebot