FireStore: Firestore.runTransaction should support asynchronous updateFunction #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #5196 +/- ##
============================================
- Coverage 50.41% 50.41% -0.01%
Complexity 23796 23796
============================================
Files 2251 2251
Lines 226833 226841 +8
Branches 24966 24967 +1
============================================
+ Hits 114368 114369 +1
- Misses 103858 103864 +6
- Partials 8607 8608 +1
Continue to review full report at Codecov.
|
sduskis
reviewed
May 17, 2019
| @@ -352,7 +352,25 @@ public void onSuccess(List<WriteResult> writeResults) { | |||
| @Override | |||
| public void run() { | |||
| try { | |||
| callbackResult.set(transactionCallback.updateCallback(transaction)); | |||
| T callbackValue = transactionCallback.updateCallback(transaction); | |||
| if (callbackValue instanceof ApiFuture) { | |||
There was a problem hiding this comment.
This looks wrong. if T is an ApiFuture, then it's not an ApiFuture<T>, but yet you cast a T to an ApiFuture<T>; that seems like infinite recursion. I would ask that we start over with a design for AsyncFunction which would be cleaner.
This callback gets called within a separate thread anyway. I'm not even sure what AsyncFunction would do for us here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5166