-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates DnsService interface and DnsOptions #597
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f9b6f6a
Added DnsService interface.
mderka 4fdc8ee
Added AbstractOption.
mderka 06becd8
Added DnsException.
mderka 81cedc4
Added DnsServiceRpc.
mderka bf1361c
Added DnsServiceOptions and necessary dependencies.
mderka 465f532
Modified DnsException to pass tests.
mderka a8bee9c
Implements comments by @aozarov.
mderka 762483b
Makes ProjectInfo.Quota serializable. Fixed #599.
mderka e17bedb
Implemented DnsOptions up to two unavailable classes.
mderka adf5c1c
Added test for AbstractOption.
mderka a9cc927
Implemented comments by @aozarov. Added test for option accessors.
mderka 6ecde35
Comments by @aozarov second round.
mderka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
70 changes: 70 additions & 0 deletions
70
gcloud-java-dns/src/main/java/com/google/gcloud/dns/AbstractOption.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
/* | ||
* Copyright 2016 Google Inc. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.gcloud.dns; | ||
|
||
import static com.google.common.base.Preconditions.checkNotNull; | ||
|
||
import com.google.common.base.MoreObjects; | ||
import com.google.gcloud.spi.DnsRpc; | ||
|
||
import java.io.Serializable; | ||
import java.util.Objects; | ||
|
||
/** | ||
* A base class for options. | ||
*/ | ||
abstract class AbstractOption implements Serializable { | ||
|
||
private static final long serialVersionUID = -5912727967831484228L; | ||
private final Object value; | ||
private final DnsRpc.Option rpcOption; | ||
|
||
AbstractOption(DnsRpc.Option rpcOption, Object value) { | ||
this.rpcOption = checkNotNull(rpcOption); | ||
this.value = value; | ||
} | ||
|
||
Object value() { | ||
return value; | ||
} | ||
|
||
DnsRpc.Option rpcOption() { | ||
return rpcOption; | ||
} | ||
|
||
@Override | ||
public boolean equals(Object obj) { | ||
if (!(obj instanceof AbstractOption)) { | ||
return false; | ||
} | ||
AbstractOption other = (AbstractOption) obj; | ||
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
return Objects.equals(value, other.value) && Objects.equals(rpcOption, other.rpcOption); | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return Objects.hash(value, rpcOption); | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return MoreObjects.toStringHelper(this) | ||
.add("value", value) | ||
.add("rpcOption", rpcOption) | ||
.toString(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.