Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing doc problems, improving formatting #670

Merged
merged 2 commits into from
Feb 26, 2016
Merged

Fixing doc problems, improving formatting #670

merged 2 commits into from
Feb 26, 2016

Conversation

garrettjonesgoogle
Copy link
Member

fixes #387 - Moving references of delete topics to get/list calls
fixes #386 - Removing the problematic wording

@garrettjonesgoogle
Fixing doc problems, improving formatting
355369f 
fixes googleapis#387 - Moving references of delete topics to get/list calls
fixes googleapis#386 - Removing the problematic wording
fixes googleapis#385 - Changing 'returns' to 'generates' when referencing errors
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2016
@aozarov
Copy link
Contributor

aozarov commented Feb 26, 2016

Changes are fine, but I don't think this PR completely resolve #385.

I think "generate NOT_FOUND", though maybe better than "return NOT_FOUND", is still not clear.
Also, what is NOT_FOUND (which looks like a constant) is not clear and this part from the issue
description "Additionally, the documentation needs to make clear how to get the exact error that occurred (specifically, getting the status code)." is not dealt with.

@aozarov aozarov added the api: pubsub Issues related to the Pub/Sub API. label Feb 26, 2016
@garrettjonesgoogle
Copy link
Member Author

Ok, I removed the "fixes 385" line from the PR description, and we'll take it up in a separate PR.

aozarov added a commit that referenced this pull request Feb 26, 2016
@aozarov
Merge pull request #670 from garrettjonesgoogle/pubsub-alpha
d549d3f 
Fixing doc problems, improving formatting
@aozarov aozarov merged commit d549d3f into googleapis:pubsub-alpha Feb 26, 2016
github-actions bot pushed a commit that referenced this pull request Jun 23, 2022
@release-please
chore(main): release 2.1.1 (#670)
a0872d9 
🤖 I have created a release *beep* *boop*
---


## [2.1.1](googleapis/java-webrisk@v2.1.0...v2.1.1) (2022-06-23)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#668](googleapis/java-webrisk#668)) ([f37760c](googleapis/java-webrisk@f37760c))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@renovate-bot
deps: update dependency com.google.apis:google-api-services-cloudreso…
c648624 
…urcemanager to v1-rev20211107-1.32.1 (googleapis#670)
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@release-please
chore: release 1.2.0 (googleapis#657)
03ba670 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.2.0](https://www.github.com/googleapis/java-resourcemanager/compare/v1.1.4...v1.2.0) (2021-12-03)


### Features

* next release from main branch is 1.2.0 ([googleapis#659](https://www.github.com/googleapis/java-resourcemanager/issues/659)) ([8af7d6d](https://www.github.com/googleapis/java-resourcemanager/commit/8af7d6de5eb05cf3c08c52e13e4ef47a51fb7d36))


### Bug Fixes

* **java:** java 17 dependency arguments ([googleapis#1266](https://www.github.com/googleapis/java-resourcemanager/issues/1266)) ([googleapis#656](https://www.github.com/googleapis/java-resourcemanager/issues/656)) ([2bb306a](https://www.github.com/googleapis/java-resourcemanager/commit/2bb306a23319c415666f72ff8f793385c5a7a3f0))


### Documentation

* fix docstring formatting ([googleapis#665](https://www.github.com/googleapis/java-resourcemanager/issues/665)) ([cb79f5f](https://www.github.com/googleapis/java-resourcemanager/commit/cb79f5f49b2d3941c698c11c2e0177e89a44e153))
* fix docstring formatting ([googleapis#673](https://www.github.com/googleapis/java-resourcemanager/issues/673)) ([5e371b9](https://www.github.com/googleapis/java-resourcemanager/commit/5e371b93873b361e5d9b54a29c50bc91d63e39b3))


### Dependencies

* update dependency com.google.apis:google-api-services-cloudresourcemanager to v1-rev20211017-1.32.1 ([googleapis#654](https://www.github.com/googleapis/java-resourcemanager/issues/654)) ([d489a3e](https://www.github.com/googleapis/java-resourcemanager/commit/d489a3e486113d75caa419e5fe0ab182764f7b49))
* update dependency com.google.apis:google-api-services-cloudresourcemanager to v1-rev20211107-1.32.1 ([googleapis#670](https://www.github.com/googleapis/java-resourcemanager/issues/670)) ([c648624](https://www.github.com/googleapis/java-resourcemanager/commit/c648624456d10518971d3a8ad2ef897a8f520576))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([googleapis#672](https://www.github.com/googleapis/java-resourcemanager/issues/672)) ([c07eaef](https://www.github.com/googleapis/java-resourcemanager/commit/c07eaef86911a560e51b85b726d26c1f82e9cbf1))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([googleapis#678](https://www.github.com/googleapis/java-resourcemanager/issues/678)) ([3bfbff5](https://www.github.com/googleapis/java-resourcemanager/commit/3bfbff573edbf1e11472f8eba130470a0c9d7841))
* update dependency com.google.errorprone:error_prone_annotations to v2.10.0 ([googleapis#663](https://www.github.com/googleapis/java-resourcemanager/issues/663)) ([ed01782](https://www.github.com/googleapis/java-resourcemanager/commit/ed0178221930b4c3796d993e467c2481170ec863))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@gcf-owl-bot
feat: Enable REST transport for most of Java and Go clients (googleap…
6763c54 
…is#670)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 456641589

Source-Link: googleapis/googleapis@8a251f5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
@release-please
chore(main): release 2.3.0 (googleapis#675)
c87d75b 
🤖 I have created a release *beep* *boop*
---


## [2.3.0](googleapis/java-billing@v2.2.1...v2.3.0) (2022-07-01)


### Features

* Enable REST transport for most of Java and Go clients ([googleapis#670](googleapis/java-billing#670)) ([6763c54](googleapis/java-billing@6763c54))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@gcf-owl-bot
fix: enable longpaths support for windows test (#1485) (#670)
498a5bf 
Source-Link: googleapis/synthtool@7336562
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@release-please
chore(main): release 2.6.2-SNAPSHOT (#670)
29f19b7 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@release-please
chore(main): release 0.9.1 (#671)
9efe368 
🤖 I have created a release *beep* *boop*
---


## [0.9.1](googleapis/java-mediatranslation@v0.9.0...v0.9.1) (2022-07-13)


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-mediatranslation/issues/1485)) ([#670](googleapis/java-mediatranslation#670)) ([498a5bf](googleapis/java-mediatranslation@498a5bf))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@gcf-owl-bot
chore(bazel): Update WORKSPACE files for rules_gapic, gax_java, gener…
f7d63d1 
…ator_java versions (#670)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472750037

Source-Link: googleapis/googleapis@88f2ea3

Source-Link: googleapis/googleapis-gen@230a558
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9
github-actions bot pushed a commit that referenced this pull request Nov 9, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
e6d6288 
…1.4 (#670)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://github.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/compatibility-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/confidence-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring-dashboards).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC45LjIifQ==-->
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@release-please
chore(main): release 2.10.1-SNAPSHOT (#670)
967b87a 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrettjonesgoogle @aozarov @googlebot