Add support for Compute's addresses #755

mziccard · 2016-03-16T16:36:32Z

This PR adds support for Compute's addresses:

Add InstanceId, ForwardingRuleId, GlobalForwardingRuleId and RegionForwardingRuleId classes
Add AddressId, GlobalAddressId, RegionAddressId classes
Add functional methods for addresses to Compute's service and rpc classes
Add AddressInfo and Address classes
Add unit and integration tests

- Add InstanceId, ForwardingRuleId and Global/RegionForwardingRuleId - Add AddressId, GlobalAddressId, RegionAddressId classes - Add functional methods for addresses to Compute's service and rpc classes - Add AddressInfo and Address classes - Add unit and integration tests

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Address.java

+  /**
+   * Deletes this address.
+   *
+   * @return an operation object if delete request was successfully sent, {@code null} if the


mziccard · 2016-03-21T18:10:25Z

@aozarov @ajkannan Thanks for the pass, I think I fixed all comments

coveralls · 2016-03-21T18:19:21Z

Coverage decreased (-0.9%) to 81.882% when pulling 3e9c62e on mziccard:compute into a4f6db9 on GoogleCloudPlatform:compute-alpha.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskTypeId.java

  }

  @Override
  public boolean equals(Object obj) {
    return obj instanceof DiskTypeId
        && baseEquals((DiskTypeId) obj)
+        && Objects.equals(zone, ((DiskTypeId) obj).zone)


aozarov · 2016-03-22T03:21:50Z

I like it much better now! LGTM, feel free to merge after applying the javadoc fix (ForwardingRuleId) and if you like the casting suggestion for equals (unless @ajkannan has any more comments?)

ajkannan · 2016-03-22T03:59:30Z

All my original comments were addressed except for the repeated toPb Function for Address (and perhaps Operation?) in ComputeImplTest. I don't think the javadocs/tests changes drastically and I don't want to slow you down by taking another pass, so no other comments from me.

coveralls · 2016-03-22T12:41:20Z

Coverage decreased (-0.9%) to 81.873% when pulling 5d172b6 on mziccard:compute into a4f6db9 on GoogleCloudPlatform:compute-alpha.

Add support for Compute's addresses

🤖 I have created a release *beep* *boop* --- ## [2.3.2](googleapis/java-accessapproval@v2.3.1...v2.3.2) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#753](googleapis/java-accessapproval#753)) ([c59599d](googleapis/java-accessapproval@c59599d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…oogleapis#755) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9 feat: Enable REST transport for most of Java and Go clients PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9

Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.

🤖 I have created a release *beep* *boop* --- ## [3.5.0](googleapis/java-cloudbuild@v3.4.1...v3.5.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([bfef783](googleapis/java-cloudbuild@bfef783)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#755](googleapis/java-cloudbuild#755)) ([bfef783](googleapis/java-cloudbuild@bfef783)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…755) * chore(deps): update dependency com.google.cloud:libraries-bom to v26 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.3.2](googleapis/java-iot@v2.3.1...v2.3.2) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#753](googleapis/java-iot#753)) ([4906218](googleapis/java-iot@4906218)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.4](googleapis/java-billingbudgets@v2.3.3...v2.3.4) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#754](googleapis/java-billingbudgets#754)) ([2a54f46](googleapis/java-billingbudgets@2a54f46)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.6](https://github.com/googleapis/java-iamcredentials/compare/v2.3.5...v2.3.6) (2022-10-05) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#754](https://github.com/googleapis/java-iamcredentials/issues/754)) ([c70cc24](https://github.com/googleapis/java-iamcredentials/commit/c70cc240dfb6a9402e5c93ea6b6c52998637040b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.3 (googleapis#755) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://github.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-phishingprotection).

…s#1687) (googleapis#755) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <chingor@google.com> Source-Link: https://github.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a

* chore: removed migrated samples * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * reverting owlbot changes * update pom * update pom * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

mziccard added the api: compute Issues related to the Compute Engine API. label Mar 16, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2016

mderka reviewed Mar 16, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Address.java

/**

* Deletes this address.

*

* @return an operation object if delete request was successfully sent, {@code null} if the

This comment was marked as spam.

Sign in to view

Make AddressInfo.builder return Builder instead of BuilderImpl

3e9c62e

aozarov reviewed Mar 22, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskTypeId.java

}

@Override

public boolean equals(Object obj) {

return obj instanceof DiskTypeId

&& baseEquals((DiskTypeId) obj)

&& Objects.equals(zone, ((DiskTypeId) obj).zone)

This comment was marked as spam.

Sign in to view

mziccard added 3 commits March 22, 2016 11:57

Use TO_PB_FUNCTION when possible in ComputeImplTest

e541400

Remove repeated casts in identities'equals method

61d87e3

Replace 'an unique' with 'the unique' everywhere

5d172b6

mziccard added a commit that referenced this pull request Mar 22, 2016

Merge pull request #755 from mziccard/compute

25e3559

Add support for Compute's addresses

mziccard merged commit 25e3559 into googleapis:compute-alpha Mar 22, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Compute's addresses #755

Add support for Compute's addresses #755

mziccard commented Mar 16, 2016

This comment was marked as spam.

mziccard commented Mar 21, 2016

coveralls commented Mar 21, 2016

This comment was marked as spam.

aozarov commented Mar 22, 2016

ajkannan commented Mar 22, 2016

coveralls commented Mar 22, 2016

Add support for Compute's addresses #755

Add support for Compute's addresses #755

Conversation

mziccard commented Mar 16, 2016

This comment was marked as spam.

mziccard commented Mar 21, 2016

coveralls commented Mar 21, 2016

This comment was marked as spam.

aozarov commented Mar 22, 2016

ajkannan commented Mar 22, 2016

coveralls commented Mar 22, 2016