Renamed DnsRecord to RecordSet. Fixes #779. #784

mderka · 2016-03-23T23:09:24Z

No description provided.

gcloud-java-dns/README.md

-The `addRecord` method of `DnsRecord.Builder` accepts records in the form of
-strings. The format of the strings depends on the type of the DNS record to be added.
-More information on the supported DNS record types and record formats can be found [here](https://cloud.google.com/dns/what-is-cloud-dns#supported_record_types).
+The `addRecord` method of `RecordSet.Builder` accepts record sets in the form of


mziccard · 2016-03-24T15:57:08Z

You might already have noticed but CI is failing:

[ERROR] /home/travis/build/GoogleCloudPlatform/gcloud-java/gcloud-java-dns/src/test/java/com/google/gcloud/dns/SerializationTest.java:[94,42] cannot find symbol
  symbol:   variable DNS_RECORD_PARTIAL
  location: class com.google.gcloud.dns.SerializationTest
[ERROR] /home/travis/build/GoogleCloudPlatform/gcloud-java/gcloud-java-dns/src/test/java/com/google/gcloud/dns/SerializationTest.java:[94,62] cannot find symbol
  symbol:   variable DNS_RECORD_COMPLETE
  location: class com.google.gcloud.dns.SerializationTest

mziccard · 2016-03-24T17:36:59Z

I finished my pass

mderka · 2016-03-24T17:39:15Z

Done with revisions. Ready to proceed.

coveralls · 2016-03-24T17:47:28Z

Coverage remained the same at 85.575% when pulling 43e7b53 on mderka:rename-dns-record into 2f90e7e on GoogleCloudPlatform:dns-alpha.

gcloud-java-dns/src/test/java/com/google/gcloud/dns/it/ITDnsTest.java

      } catch (DnsException ex) {
        // expected
        assertEquals(412, ex.code());
        assertFalse(ex.retryable());
      }
      // delete and add SOA
-      Iterator<RecordSet> recordIterator = zone.listRecordSets().iterateAll();
+      Iterator<RecordSet> recordSetIteratorrator = zone.listRecordSets().iterateAll();


mziccard · 2016-03-24T19:23:35Z

Added one more nit, feel free to merge when done!

mderka · 2016-03-24T19:49:23Z

Fixed and squashed commits. I will merge when travis finished. Thanks.

coveralls · 2016-03-24T19:56:39Z

Coverage remained the same at 85.575% when pulling 1a5aade on mderka:rename-dns-record into 2f90e7e on GoogleCloudPlatform:dns-alpha.

…onfig to v1.5.0 (#784) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://github.com/googleapis/java-shared-config) | `1.4.0` -> `1.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/compatibility-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/confidence-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.0`](https://github.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#150-httpsgithubcomgoogleapisjava-shared-configcomparev140v150-2022-06-10) [Compare Source](https://github.com/googleapis/java-shared-config/compare/v1.4.0...v1.5.0) ##### Features - add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-shared-config/issues/1440)) ([#475](https://github.com/googleapis/java-shared-config/issues/475)) ([e4dfc1b](https://github.com/googleapis/java-shared-config/commit/e4dfc1ba29295158c78c8fcf94467d2a6a33538a)) - to produce Java 8 compatible bytecode when using JDK 9+ ([2468276](https://github.com/googleapis/java-shared-config/commit/2468276145cdfe1ca911b52f765e026e77661a09)) ##### Dependencies - update surefire.version to v3.0.0-m7 ([bbfe663](https://github.com/googleapis/java-shared-config/commit/bbfe66393af3e49612c9c1e4334ba39c133ea1d0)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-secretmanager).

…3.0 (googleapis#784) * chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…onfig to v1.5.1 (#784) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://github.com/googleapis/java-shared-config) | `1.5.0` -> `1.5.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/compatibility-slim/1.5.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/confidence-slim/1.5.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.1`](https://github.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#151-httpsgithubcomgoogleapisjava-shared-configcomparev150v151-2022-06-30) [Compare Source](https://github.com/googleapis/java-shared-config/compare/v1.5.0...v1.5.1) ##### Dependencies - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([#482](https://github.com/googleapis/java-shared-config/issues/482)) ([fbfc6dc](https://github.com/googleapis/java-shared-config/commit/fbfc6dc1329faaead3a3114c8599d9267722e7f0)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#483](https://github.com/googleapis/java-shared-config/issues/483)) ([336cb78](https://github.com/googleapis/java-shared-config/commit/336cb7827b36583228c9e2b85871ae72f4c55975)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recommender).

…784) * chore(deps): update dependency com.google.cloud:libraries-bom to v26 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…784) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | `2.8.5` -> `2.8.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/compatibility-slim/2.8.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/confidence-slim/2.8.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.6`](https://github.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#286-httpsgithubcomgoogleapisjava-corecomparev285v286-2022-08-02) [Compare Source](https://github.com/googleapis/java-core/compare/v2.8.5...v2.8.6) ##### Dependencies - update dependency com.google.api:gax-bom to v2.18.7 ([#890](https://github.com/googleapis/java-core/issues/890)) ([c67bed5](https://github.com/googleapis/java-core/commit/c67bed5281b458e78780cdd918235b5d073917c7)) - update dependency com.google.code.gson:gson to v2.9.1 ([#888](https://github.com/googleapis/java-core/issues/888)) ([7b799c6](https://github.com/googleapis/java-core/commit/7b799c66f4aaf057242e9a231b920e49a7c964e9)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-accessapproval).

🤖 I have created a release *beep* *boop* --- ## [2.4.3](googleapis/java-accessapproval@v2.4.2...v2.4.3) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#779](googleapis/java-accessapproval#779)) ([f11b5f4](googleapis/java-accessapproval@f11b5f4)) * update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#780](googleapis/java-accessapproval#780)) ([ccbc03d](googleapis/java-accessapproval@ccbc03d)) * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#784](googleapis/java-accessapproval#784)) ([2b8872d](googleapis/java-accessapproval@2b8872d)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#785](googleapis/java-accessapproval#785)) ([464c702](googleapis/java-accessapproval@464c702)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#786](googleapis/java-accessapproval#786)) ([4d28115](googleapis/java-accessapproval@4d28115)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#781](googleapis/java-accessapproval#781)) ([f8fac7c](googleapis/java-accessapproval@f8fac7c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-info-reports-plugin to v3.4.1 (#784) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-cloudbuild).

…1575) (#784) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…thon 3.6 (#1588)" (#784) Reverts googleapis/java-billingbudgets#759

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…784) * test: add presubmit to verify java_library requirements file Source-Link: https://github.com/googleapis/synthtool/commit/d14818215edae9910959439def57cf180d58f4c9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:27d0a1232b3656f0610cc1a55beb157cb3b63b1ca8b3dfba0bcd8b9dfecda4a1

🤖 I have created a release *beep* *boop* --- ## [2.6.0](googleapis/java-core@v2.5.11...v2.6.0) (2022-04-14) ### Features * **java:** remove GoogleJsonClentFeature and OpenCensusFeature after relocation ([#793](googleapis/java-core#793)) ([cafd489](googleapis/java-core@cafd489)) * **java:** remove Netty Native Image configuration after relocation to gax ([#771](googleapis/java-core#771)) ([9cc7dba](googleapis/java-core@9cc7dba)) * **java:** remove protobuf Native Image configuration ([#784](googleapis/java-core#784)) ([7a8df66](googleapis/java-core@7a8df66)) * remove native-image.properties settings after relocation ([#794](googleapis/java-core#794)) ([219a519](googleapis/java-core@219a519)) * remove resource-config after relocation ([#795](googleapis/java-core#795)) ([8ed3110](googleapis/java-core@8ed3110)) * remove substitutions after relocation to gax ([#789](googleapis/java-core#789)) ([85280b1](googleapis/java-core@85280b1)) ### Bug Fixes * **java:** register test class for reflection to fix native image test ([#766](googleapis/java-core#766)) ([fa07125](googleapis/java-core@fa07125)) ### Dependencies * revert protobuf to 3.19 and common-protos 2.8.3 ([#798](googleapis/java-core#798)) ([27ca70c](googleapis/java-core@27ca70c)) * update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#800](googleapis/java-core#800)) ([3abc47d](googleapis/java-core@3abc47d)) * update dependency com.google.api:gax-bom to v2.16.0 ([#785](googleapis/java-core#785)) ([bd33a76](googleapis/java-core@bd33a76)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.1 ([#792](googleapis/java-core#792)) ([3f85e62](googleapis/java-core@3f85e62)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.2 ([#796](googleapis/java-core#796)) ([d6ea18e](googleapis/java-core@d6ea18e)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.0 ([#783](googleapis/java-core#783)) ([48594f3](googleapis/java-core@48594f3)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.1 ([#799](googleapis/java-core#799)) ([9fe7d35](googleapis/java-core@9fe7d35)) * update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#788](googleapis/java-core#788)) ([cfdabb4](googleapis/java-core@cfdabb4)) * update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#791](googleapis/java-core#791)) ([d9ff405](googleapis/java-core@d9ff405)) * update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#797](googleapis/java-core#797)) ([dfc3c57](googleapis/java-core@dfc3c57)) * update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#787](googleapis/java-core#787)) ([51f59fc](googleapis/java-core@51f59fc)) * update dependency io.grpc:grpc-bom to v1.45.1 ([#780](googleapis/java-core#780)) ([cd8a078](googleapis/java-core@cd8a078)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2016

mderka added api: dns Issues related to the Cloud DNS API. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 23, 2016

mderka added this to the DNS Stable milestone Mar 23, 2016

mziccard reviewed Mar 24, 2016
View reviewed changes

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2016

mziccard reviewed Mar 24, 2016
View reviewed changes

Renamed DnsRecord to RecordSet. Fixes googleapis#779.

1a5aade

mderka force-pushed the rename-dns-record branch from 43e7b53 to 1a5aade Compare March 24, 2016 19:48

mderka merged commit 96e28d6 into googleapis:dns-alpha Mar 24, 2016

github-actions bot pushed a commit that referenced this pull request Sep 30, 2022

Revert "chore: pin versions of dependencies for compatibility with Py…

6dc58f1

…thon 3.6 (#1588)" (#784) Reverts googleapis/java-billingbudgets#759

suztomo pushed a commit that referenced this pull request Feb 1, 2023

feat(java): remove protobuf Native Image configuration (#784)

7a8df66

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update google.core.version to v2.8.9 (#784)

a9847d7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renamed DnsRecord to RecordSet. Fixes #779. #784

Renamed DnsRecord to RecordSet. Fixes #779. #784

mderka commented Mar 23, 2016

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Mar 24, 2016

mziccard commented Mar 24, 2016

mderka commented Mar 24, 2016

coveralls commented Mar 24, 2016

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Mar 24, 2016

mderka commented Mar 24, 2016

coveralls commented Mar 24, 2016

Renamed DnsRecord to RecordSet. Fixes #779. #784

Renamed DnsRecord to RecordSet. Fixes #779. #784

Conversation

mderka commented Mar 23, 2016

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Mar 24, 2016

mziccard commented Mar 24, 2016

mderka commented Mar 24, 2016

coveralls commented Mar 24, 2016

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Mar 24, 2016

mderka commented Mar 24, 2016

coveralls commented Mar 24, 2016