Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restore google-cloud-examples #8583

Merged
merged 6 commits into from
Oct 12, 2022
Merged

chore: restore google-cloud-examples #8583

merged 6 commits into from
Oct 12, 2022
+10,009 −3

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Oct 12, 2022 •
edited
Loading

@snippet-bot
Copy link

snippet-bot bot commented Oct 12, 2022 •
edited
Loading

Here is the summary of possible violations 😱

There are 105 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 162 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@suztomo
Copy link
Member Author

suztomo commented Oct 12, 2022

The check fails

+ for path in $(find . -mindepth 2 -maxdepth 2 -name pom.xml | sort --dictionary-order | xargs dirname)
+ module_name=google-cloud-examples
+ version_file=./google-cloud-examples/versions.txt
++ grep -E '^((google-.*|grafeas|gapic\-libraries)).*:[0-9]+\.[0-9]+\.[0-9]+.*:[0-9]+\.[0-9]+\.[0-9]+.*$' ./google-cloud-examples/versions.txt
grep: ./google-cloud-examples/versions.txt: No such file or directory

@meltsufin
Copy link
Member

@suztomo If you rename pom.xml to pom.xml.bak, you shouldn't have to make any changes to generation\.

@suztomo
Copy link
Member Author

suztomo commented Oct 12, 2022

I now think it’s better to remove the pom.xml altogether.

@meltsufin
Copy link
Member

I now think it’s better to remove the pom.xml altogether.

When these get migrated to java-docs-samples, they might want to use something from pom.xml to start running the tests again, but I'm not sure how much in it is useful.

@meltsufin
Copy link
Member

It looks like pom.xml is still there.

@suztomo suztomo added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@suztomo suztomo merged commit f8f5b83 into googleapis:main Oct 12, 2022
@suztomo suztomo deleted the restore_google-cloud-examples branch October 12, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

@ddixit14 ddixit14 ddixit14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suztomo @meltsufin @ddixit14