Integration test for ls #931

jean-philippe-martin · 2016-04-15T18:02:58Z

List the files in a bucket running against the real GCS. This required a little bugfix in my FakeStorageRpc.

jean-philippe-martin · 2016-04-15T18:06:50Z

I ran into unexpected behavior in storage.list (see CloudStorageFileSystemProvider:575): I supply BlobListOptions.currentDirectory() to avoid a recursive listing, but if I also set the BlobListOption.fields() option then I get a recursive listing anyways!

The current workaround is not to set the fields() option, but if this is a real bug in storage then we should fix it.

mziccard · 2016-04-15T18:24:47Z

@jean-philippe-martin Nice catch, this is indeed a bug on our side. I'll send a fix ASAP.

jean-philippe-martin · 2016-04-15T18:28:42Z

Awesome @mziccard, thank you!

gcloud-java-storage/src/main/java/com/google/gcloud/storage/testing/FakeStorageRpc.java

+        int nextSlash = so.getName().indexOf(delimiter, prefix.length());
+        if (nextSlash >= 0) {
+          String folderName = so.getName().substring(0, nextSlash + 1);
+          if (folders.containsKey(folderName)) {


mziccard · 2016-04-15T23:43:52Z

@jean-philippe-martin The issue was fixed with #933, you might want to fetch changes from master

jean-philippe-martin · 2016-04-18T16:15:17Z

Sure @mziccard . I'm guessing that should be a separate PR? I made #937, please take a look when you get a chance.

mziccard · 2016-04-18T16:22:25Z

@jean-philippe-martin We need one PR to merge master into gcs-nio, then you can either rebase this or create a new one, your call

mziccard · 2016-04-18T20:22:53Z

@jean-philippe-martin In 47632c7 I see you merge gcs-nio into this PR's branch. I strongly suggest you undo that commit and rebase this PR instead.

jean-philippe-martin · 2016-04-18T20:25:06Z

oh, ok.

mziccard · 2016-04-18T20:29:10Z

The rationale behind this is that I don't want to add to the history merge commits that are not strictly necessary. Merge is fine but for PR we should always prefer rebase if possible as it does not add commits that are not feature-related. This makes browsing through history much easier as well as writing changelogs or tracking issues to commits.

jean-philippe-martin · 2016-04-18T20:35:51Z

Makes sense. I was going by the "don't rebase public branches" rule of thumb but since no one's working on this branch except me, we're fine.

...a-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProvider.java

+        Storage.BlobListOption.prefix(prefix),
+        Storage.BlobListOption.currentDirectory()
+        // this breaks the listing (bug?)
+        //Storage.BlobListOption.fields()


mziccard · 2016-04-19T13:56:47Z

@jean-philippe-martin I just noticed that this file contain several lines that exceed the 100-characters line limit. Would you mind wrapping them?

jean-philippe-martin · 2016-04-19T20:42:55Z

Added line breaks.

mziccard · 2016-04-19T20:57:11Z

Thanks @jean-philippe-martin for addressing all my annoying comments!

jean-philippe-martin · 2016-04-19T21:00:02Z

And thanks @mziccard for your attention to detail!

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…oogleapis#931) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | `2.8.0` -> `2.8.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.1/compatibility-slim/2.8.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.1/confidence-slim/2.8.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-vision).

🤖 I have created a release *beep* *boop* --- ## [3.0.1](googleapis/java-vision@v3.0.0...v3.0.1) (2022-07-01) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.1 ([googleapis#931](googleapis/java-vision#931)) ([027e196](googleapis/java-vision@027e196)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…telligence to v2.2.1 (#931) * chore(deps): update dependency com.google.cloud:google-cloud-video-intelligence to v2.2.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. chore(bazel): update gax-java to 2.18.4 PiperOrigin-RevId: 463115700 Source-Link: googleapis/googleapis@52130a9 Source-Link: googleapis/googleapis-gen@6a4d9d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmE0ZDlkOWJiM2FmYjIwYjBmNWZhNGY1ZDlmNjc0MGIxZDBlYjE5YSJ9

🤖 I have created a release *beep* *boop* --- ## [2.5.4](googleapis/java-speech@v2.5.3...v2.5.4) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#927](googleapis/java-speech#927)) ([5731284](googleapis/java-speech@5731284)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#930](googleapis/java-speech#930)) ([afc1b3f](googleapis/java-speech@afc1b3f)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#931](googleapis/java-speech#931)) ([10bebdc](googleapis/java-speech@10bebdc)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#932](googleapis/java-speech#932)) ([5900f4a](googleapis/java-speech@5900f4a)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#933](googleapis/java-speech#933)) ([d8e1353](googleapis/java-speech@d8e1353)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.124.5](googleapis/java-errorreporting@v0.124.4...v0.124.5) (2022-09-08) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#931](googleapis/java-errorreporting#931)) ([789ff61](googleapis/java-errorreporting@789ff61)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.4.5](googleapis/java-containeranalysis@v2.4.4...v2.4.5) (2022-09-10) ### Dependencies * Update dependency io.grafeas:grafeas to v2.4.4 ([#930](googleapis/java-containeranalysis#930)) ([905c9e4](googleapis/java-containeranalysis@905c9e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2016

jean-philippe-martin reviewed Apr 15, 2016
View reviewed changes

Integration test for ls

68002d0

jean-philippe-martin force-pushed the nio_ls branch from 47632c7 to 68002d0 Compare April 18, 2016 20:31

mziccard reviewed Apr 18, 2016
View reviewed changes

jean-philippe-martin added 2 commits April 18, 2016 14:36

Remove workaround for now-fixed list bug

9e323cc

Formatting changes

c32d29e

Trim lines to 100 chars in gcloud-java-nio

f97de17

mziccard merged commit eceec71 into googleapis:gcs-nio Apr 19, 2016

jean-philippe-martin deleted the nio_ls branch April 19, 2016 21:00

mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Jun 29, 2016

Integration test for ls (googleapis#931)

23ae570

mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Jun 30, 2016

Integration test for ls (googleapis#931)

10180eb

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update iam.version to v1.6.22 (#931)

5f303ec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integration test for ls #931

Integration test for ls #931

jean-philippe-martin commented Apr 15, 2016

jean-philippe-martin commented Apr 15, 2016

mziccard commented Apr 15, 2016

jean-philippe-martin commented Apr 15, 2016

This comment was marked as spam.

mziccard commented Apr 15, 2016

jean-philippe-martin commented Apr 18, 2016 •

edited

Loading

mziccard commented Apr 18, 2016

mziccard commented Apr 18, 2016

jean-philippe-martin commented Apr 18, 2016

mziccard commented Apr 18, 2016

jean-philippe-martin commented Apr 18, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Apr 19, 2016

jean-philippe-martin commented Apr 19, 2016

mziccard commented Apr 19, 2016

jean-philippe-martin commented Apr 19, 2016

Integration test for ls #931

Integration test for ls #931

Conversation

jean-philippe-martin commented Apr 15, 2016

jean-philippe-martin commented Apr 15, 2016

mziccard commented Apr 15, 2016

jean-philippe-martin commented Apr 15, 2016

This comment was marked as spam.

mziccard commented Apr 15, 2016

jean-philippe-martin commented Apr 18, 2016 • edited Loading

mziccard commented Apr 18, 2016

mziccard commented Apr 18, 2016

jean-philippe-martin commented Apr 18, 2016

mziccard commented Apr 18, 2016

jean-philippe-martin commented Apr 18, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Apr 19, 2016

jean-philippe-martin commented Apr 19, 2016

mziccard commented Apr 19, 2016

jean-philippe-martin commented Apr 19, 2016

jean-philippe-martin commented Apr 18, 2016 •

edited

Loading