refactor: modernize the sample tests (#185)

* refactor: modernize the sample tests * lintalicious
googleapis · Oct 13, 2022 · 258d093 · 258d093
1 parent e37ee9d
commit 258d093
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 19 deletions.
diff --git a/packages/google-cloud-language/samples/.eslintrc.yml b/packages/google-cloud-language/samples/.eslintrc.yml
@@ -1,3 +1,4 @@
 ---
 rules:
   no-console: off
+  node/no-missing-require: off
diff --git a/packages/google-cloud-language/samples/package.json b/packages/google-cloud-language/samples/package.json
@@ -12,7 +12,7 @@
     "resources"
   ],
   "scripts": {
-    "test": "mocha"
+    "test": "mocha --timeout 60000"
   },
   "dependencies": {
     "@google-cloud/automl": "^0.1.1",
@@ -22,7 +22,8 @@
     "yargs": "^12.0.0"
   },
   "devDependencies": {
-    "@google-cloud/nodejs-repo-tools": "^3.0.0",
+    "chai": "^4.2.0",
+    "execa": "^1.0.0",
     "mocha": "^5.2.0",
     "uuid": "^3.2.1"
   }

diff --git a/packages/google-cloud-language/samples/quickstart.js b/packages/google-cloud-language/samples/quickstart.js
@@ -16,7 +16,7 @@
 'use strict';
 
 // [START language_quickstart]
-async function main() {
+async function quickstart() {
   // Imports the Google Cloud client library
   const language = require('@google-cloud/language');
 
@@ -39,6 +39,6 @@ async function main() {
   console.log(`Sentiment score: ${sentiment.score}`);
   console.log(`Sentiment magnitude: ${sentiment.magnitude}`);
 }
-
-main().catch(console.error);
 // [END language_quickstart]
+
+quickstart().catch(console.error);
diff --git a/packages/google-cloud-language/samples/test/quickstart.test.js b/packages/google-cloud-language/samples/test/quickstart.test.js
@@ -15,19 +15,14 @@
 
 'use strict';
 
-const path = require(`path`);
-const assert = require('assert');
-const tools = require(`@google-cloud/nodejs-repo-tools`);
+const {assert} = require('chai');
+const execa = require('execa');
 
-const cmd = `node quickstart.js`;
-const cwd = path.join(__dirname, `..`);
-
-beforeEach(async () => tools.stubConsole);
-afterEach(async () => tools.restoreConsole);
-
-it(`should analyze sentiment in text`, async () => {
-  const output = await tools.runAsync(cmd, cwd);
-  assert(RegExp('Text: Hello, world!').test(output));
-  assert(RegExp('Sentiment score: ').test(output));
-  assert(RegExp('Sentiment magnitude: ').test(output));
+describe('quickstart', () => {
+  it('should analyze sentiment in text', async () => {
+    const {stdout} = await execa.shell('node quickstart.js');
+    assert(stdout, /Text: Hello, world!/);
+    assert(stdout, /Sentiment score: /);
+    assert(stdout, /Sentiment magnitude: /);
+  });
 });