Skip to content

Commit

Permalink
chore: update npm scripts and synth.py (#767)
Browse files Browse the repository at this point in the history
Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.
  • Loading branch information
alexander-fenster authored Apr 24, 2020
1 parent 5ce383b commit 3162f86
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
5 changes: 3 additions & 2 deletions packages/google-cloud-vision/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"scripts": {
"test": "c8 mocha build/test",
"samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../",
"lint": "gts fix",
"lint": "gts check",
"docs": "jsdoc -c .jsdoc.js",
"system-test": "mocha build/system-test",
"fix": "gts fix",
Expand All @@ -40,7 +40,8 @@
"clean": "gts clean",
"compile": "tsc -p . && cp -r protos build/",
"compile-protos": "compileProtos src",
"prepare": "npm run compile"
"prepare": "npm run compile",
"precompile": "gts clean"
},
"dependencies": {
"@google-cloud/promisify": "^2.0.0",
Expand Down
7 changes: 2 additions & 5 deletions packages/google-cloud-vision/synth.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import synthtool as s
import synthtool.gcp as gcp
import subprocess
import synthtool.languages.node as node
import logging

logging.basicConfig(level=logging.DEBUG)
Expand Down Expand Up @@ -52,7 +52,4 @@
templates = common_templates.node_library(source_location='build/src')
s.copy(templates)

# Node.js specific cleanup
subprocess.run(['npm', 'install'])
subprocess.run(['npm', 'run', 'fix'])
subprocess.run(['npx', 'compileProtos', 'src'])
node.postprocess_gapic_library()

0 comments on commit 3162f86

Please sign in to comment.