fix: remove eslint, update gax, fix generated protos, run the generat…

…or (#756) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.
googleapis · Apr 11, 2020 · 410e05b · 410e05b
1 parent c768b81
commit 410e05b
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 22 deletions.
diff --git a/packages/google-cloud-vision/package.json b/packages/google-cloud-vision/package.json
@@ -36,15 +36,15 @@
     "test-no-cover": "mocha test/*.js",
     "docs-test": "linkinator docs",
     "predocs-test": "npm run docs",
-    "prelint": "cd samples; npm link ../; npm i",
+    "prelint": "cd samples; npm link ../; npm install",
     "clean": "gts clean",
     "compile": "tsc -p . && cp -r protos build/",
     "compile-protos": "compileProtos src",
     "prepare": "npm run compile"
   },
   "dependencies": {
     "@google-cloud/promisify": "^1.0.4",
-    "google-gax": "^2.0.1",
+    "google-gax": "^2.1.0",
     "is": "^3.3.0"
   },
   "devDependencies": {
@@ -56,11 +56,7 @@
     "@types/uuid": "^3.4.7",
     "c8": "^7.1.0",
     "codecov": "^3.6.5",
-    "eslint": "^6.8.0",
-    "eslint-config-prettier": "^6.10.0",
-    "eslint-plugin-node": "^11.0.0",
-    "eslint-plugin-prettier": "^3.1.2",
-    "gts": "2.0.0",
+    "gts": "^2.0.0",
     "jsdoc": "^3.6.3",
     "jsdoc-fresh": "^1.0.2",
     "jsdoc-region-tag": "^1.0.4",

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1/image_annotator.proto
@@ -676,7 +676,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](https://cloud.google.com/vision/docs/languages).
+  // [supported languages](/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p1beta1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p1beta1/image_annotator.proto
@@ -502,7 +502,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](https://cloud.google.com/vision/docs/languages).
+  // [supported languages](/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p2beta1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p2beta1/image_annotator.proto
@@ -533,7 +533,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](https://cloud.google.com/vision/docs/languages).
+  // [supported languages](/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p3beta1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p3beta1/image_annotator.proto
@@ -561,7 +561,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](https://cloud.google.com/vision/docs/languages).
+  // [supported languages](/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/image_annotator.proto
@@ -632,7 +632,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](https://cloud.google.com/vision/docs/languages).
+  // [supported languages](/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/synth.metadata b/packages/google-cloud-vision/synth.metadata
@@ -1,14 +1,6 @@
 {
-  "updateTime": "2020-04-10T20:00:59.209374Z",
+  "updateTime": "2020-04-11T01:08:42.418307Z",
   "sources": [
-    {
-      "git": {
-        "name": "googleapis",
-        "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "cf18ab5200e41e9d0cfef88c6c4bcdd394faf1ca",
-        "internalRef": "305925954"
-      }
-    },
     {
       "git": {
         "name": "synthtool",

diff --git a/packages/google-cloud-vision/synth.py b/packages/google-cloud-vision/synth.py
@@ -54,5 +54,5 @@
 
 # Node.js specific cleanup
 subprocess.run(['npm', 'install'])
-subprocess.run(['npm', 'run', 'fix'])
+subprocess.run(['npm', 'run', 'lint'])
 subprocess.run(['npx', 'compileProtos', 'src'])