Skip to content

Commit

Permalink
feat!: drop node8 support (#562)
Browse files Browse the repository at this point in the history
* feat!: drop node8 support

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

* fix: lint
  • Loading branch information
alexander-fenster committed Apr 1, 2020
1 parent d9f13a2 commit 7135f81
Show file tree
Hide file tree
Showing 18 changed files with 1,191 additions and 836 deletions.
3 changes: 3 additions & 0 deletions packages/google-cloud-node/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "./node_modules/gts"
}
15 changes: 0 additions & 15 deletions packages/google-cloud-node/.eslintrc.yml

This file was deleted.

8 changes: 0 additions & 8 deletions packages/google-cloud-node/.prettierrc

This file was deleted.

17 changes: 17 additions & 0 deletions packages/google-cloud-node/.prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

module.exports = {
...require('gts/.prettierrc.json')
}
12 changes: 6 additions & 6 deletions packages/google-cloud-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc.",
"engines": {
"node": ">=8.10.0"
"node": ">=10"
},
"repository": "googleapis/nodejs-speech",
"main": "./build/src/index.js",
Expand Down Expand Up @@ -44,7 +44,7 @@
},
"dependencies": {
"@google-cloud/common": "^2.0.0",
"google-gax": "^1.11.1",
"google-gax": "^2.0.1",
"protobufjs": "^6.8.6",
"pumpify": "^2.0.0",
"stream-events": "^1.0.4",
Expand All @@ -53,14 +53,14 @@
"devDependencies": {
"@types/mocha": "^7.0.0",
"@types/node": "^12.0.0",
"@types/sinon": "^7.5.1",
"@types/sinon": "^7.5.2",
"c8": "^7.0.0",
"codecov": "^3.0.2",
"eslint": "^6.0.0",
"eslint-config-prettier": "^6.0.0",
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-prettier": "^3.0.0",
"gts": "^1.1.2",
"gts": "2.0.0-alpha.9",
"jsdoc": "^3.5.5",
"jsdoc-fresh": "^1.0.1",
"jsdoc-region-tag": "^1.0.2",
Expand All @@ -69,9 +69,9 @@
"null-loader": "^3.0.0",
"pack-n-play": "^1.0.0-2",
"prettier": "^1.13.5",
"sinon": "^9.0.0",
"sinon": "^9.0.1",
"ts-loader": "^6.2.1",
"typescript": "3.6.4",
"typescript": "^3.8.3",
"webpack": "^4.41.2",
"webpack-cli": "^3.3.10"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-node/src/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export class ImprovedStreamingClient {
// Format the audio content as input request for pipeline
const recognizeStream = streamEvents(new pumpify.obj());

// tslint:disable-next-line no-any
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const requestStream = (this as any)
._streamingRecognize(options)
.on('error', (err: Error) => {
Expand Down
Loading

0 comments on commit 7135f81

Please sign in to comment.