feat: support apiEndpoint override (#229)

googleapis · May 31, 2019 · a0fa05d · a0fa05d
1 parent c7d3875
commit a0fa05d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/packages/google-cloud-resourcemanager/package.json b/packages/google-cloud-resourcemanager/package.json
@@ -43,7 +43,7 @@
   },
   "dependencies": {
     "@google-cloud/paginator": "^1.0.0",
-    "@google-cloud/common": "^1.0.0",
+    "@google-cloud/common": "^2.0.0",
     "@google-cloud/promisify": "^1.0.0"
   },
   "devDependencies": {

diff --git a/packages/google-cloud-resourcemanager/src/index.ts b/packages/google-cloud-resourcemanager/src/index.ts
@@ -110,6 +110,11 @@ export interface CreateProjectOptions {
 export interface ClientConfig extends GoogleAuthOptions {
   autoRetry?: boolean;
   maxRetries?: boolean;
+  /**
+   * The API endpoint of the service used to make requests.
+   * Defaults to `cloudresourcemanager.googleapis.com`.
+   */
+  apiEndpoint?: string;
 }
 
 /**
@@ -149,8 +154,11 @@ export interface ClientConfig extends GoogleAuthOptions {
 class Resource extends Service {
   getProjectsStream: Function;
   constructor(options: ClientConfig = {}) {
+    options.apiEndpoint =
+      options.apiEndpoint || 'cloudresourcemanager.googleapis.com';
     const config = {
-      baseUrl: 'https://cloudresourcemanager.googleapis.com/v1',
+      apiEndpoint: options.apiEndpoint,
+      baseUrl: `https://${options.apiEndpoint}/v1`,
       scopes: ['https://www.googleapis.com/auth/cloud-platform'],
       projectIdRequired: false,
       packageJson: require('../../package.json'),

diff --git a/packages/google-cloud-resourcemanager/test/index.ts b/packages/google-cloud-resourcemanager/test/index.ts
@@ -139,7 +139,6 @@ describe('Resource', () => {
       assert(resource instanceof FakeService);
 
       const calledWith = resource.calledWith_[0];
-
       const baseUrl = 'https://cloudresourcemanager.googleapis.com/v1';
       assert.strictEqual(calledWith.baseUrl, baseUrl);
       assert.deepStrictEqual(calledWith.scopes, [
@@ -151,6 +150,15 @@ describe('Resource', () => {
         require('../../package.json')
       );
     });
+
+    it('should allow overriding the apiEndpoint', () => {
+      const apiEndpoint = 'fake.endpoint';
+      resource = new Resource({
+        apiEndpoint,
+      });
+      const calledWith = resource.calledWith_[0];
+      assert.strictEqual(calledWith.baseUrl, `https://${apiEndpoint}/v1`);
+    });
   });
 
   describe('createProject', () => {