fix: drop support for node.js 4.x and 9.x (#45)

googleapis · Jun 11, 2018 · aefe69c · aefe69c
1 parent cd4b904
commit aefe69c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 28 deletions.
diff --git a/packages/google-cloud-dns/.circleci/config.yml b/packages/google-cloud-dns/.circleci/config.yml
@@ -3,10 +3,6 @@ workflows:
   version: 2
   tests:
     jobs: &workflow_jobs
-      - node4:
-          filters:
-            tags:
-              only: /.*/
       - node6:
           filters:
             tags:
@@ -15,30 +11,22 @@ workflows:
           filters:
             tags:
               only: /.*/
-      - node9:
-          filters:
-            tags:
-              only: /.*/
       - node10:
           filters:
             tags:
               only: /.*/
       - lint:
           requires:
-            - node4
             - node6
             - node8
-            - node9
             - node10
           filters:
             tags:
               only: /.*/
       - docs:
           requires:
-            - node4
             - node6
             - node8
-            - node9
             - node10
           filters:
             tags:
@@ -79,9 +67,9 @@ workflows:
               only: master
     jobs: *workflow_jobs
 jobs:
-  node4:
+  node6:
     docker:
-      - image: 'node:4'
+      - image: 'node:6'
     steps: &unit_tests_steps
       - checkout
       - run: &remove_package_lock
@@ -111,25 +99,17 @@ jobs:
           name: Submit coverage data to codecov.
           command: node_modules/.bin/codecov
           when: always
-  node6:
-    docker:
-      - image: 'node:6'
-    steps: *unit_tests_steps
   node8:
     docker:
       - image: 'node:8'
     steps: *unit_tests_steps
-  node9:
-    docker:
-      - image: 'node:9'
-    steps: *unit_tests_steps
   node10:
     docker:
       - image: 'node:10'
     steps: *unit_tests_steps
   lint:
     docker:
-      - image: 'node:8'
+      - image: 'node:10'
     steps:
       - checkout
       - run: *remove_package_lock
@@ -146,7 +126,7 @@ jobs:
           command: npm run lint
   docs:
     docker:
-      - image: 'node:8'
+      - image: 'node:10'
     steps:
       - checkout
       - run: *remove_package_lock
@@ -156,7 +136,7 @@ jobs:
           command: npm run docs
   sample_tests:
     docker:
-      - image: 'node:8'
+      - image: 'node:10'
     steps:
       - checkout
       - run: *remove_package_lock
@@ -203,7 +183,7 @@ jobs:
           when: always
   publish_npm:
     docker:
-      - image: 'node:8'
+      - image: 'node:10'
     steps:
       - checkout
       - run:

diff --git a/packages/google-cloud-dns/package.json b/packages/google-cloud-dns/package.json
@@ -5,7 +5,7 @@
   "license": "Apache-2.0",
   "author": "Google Inc.",
   "engines": {
-    "node": ">=4.0.0"
+    "node": ">=6.0.0"
   },
   "repository": "googleapis/nodejs-dns",
   "main": "./src/index.js",

diff --git a/packages/google-cloud-dns/samples/package.json b/packages/google-cloud-dns/samples/package.json
@@ -6,7 +6,7 @@
   "author": "Google Inc.",
   "repository": "googleapis/nodejs-dns",
   "engines": {
-    "node": ">=4.0.0"
+    "node": ">=6.0.0"
   },
   "scripts": {
     "ava": "ava -T 20s --verbose test/*.test.js system-test/*.test.js",