Unable to set svg Content-Type

[samdaltonmaag]

Hi,

SVGs that I upload to my bucket are being served as text/plain. I suspect that the mime type detection has failed, so I'm trying to set it manually. Here's an example metadata object I use during upload:

      metadata: {
        'Content-Type': 'image/svg+xml'
      }

There doesn't seem to be any documentation on how to set the content type, so any help is appreciated.

Cheers

[stephenplusplus]

Just to confirm we're looking at the same thing, what version of gcloud-node are you running?

[silvolu]

@samdaltonmaag there is an example in the storage regression test, the key should be contentType. You can find a complete description of Cloud Storage objects here.

[stephenplusplus]

Small thing: it's actually contentType, not ContentType.

The bucket write functionality has changed since 0.3.0, so keep that in mind when looking at the repo's tests & docs.

@silvolu Can we put out a 0.4.0 before the weekend?

[samdaltonmaag]

Ah yes, it's working with that property name. I'm using 0.3.0.
Appreciate the help.

[silvolu]

@stephenplusplus yeah, but the way you write metadata hasn't changed ;-)

[adamreisnz]

Could this be documented a bit clearer please? I reached this issue because I also couldn't find in the docs how to properly write the Content-Type meta data property, and tried to write it as:

let stream = gcsFile.createWriteStream({
      metaData: {
        'Content-Type': file.mimetype
      }
    });

Would be nice if this was documented, or a link to relevant documentation provided, somewhere here:

https://googlecloudplatform.github.io/gcloud-node/#/docs/v0.35.0/storage/file?method=createWriteStream

[stephenplusplus]

We do show setting metadata in an example. Doesn't say much that you didn't see it, though! Could you contribute a PR with what you would have found helpful?

[adamreisnz]

If you can send me the link to the page where the meta data is shown in an example, then yes I could add a link to that page in the documentation.

[stephenplusplus]

It's in the example for createWriteStream under "Uploading a File with Metadata"

[adamreisnz]

Ah, there it is. Yes, a link in the table at the metadata property to that example would be great. I'd create a PR for this, but not sure what repository/files I should be looking at.

[stephenplusplus]

Thanks! The docs are inline with the code in this repo. Here's where the docblock starts for createWriteStream: https://github.com/GoogleCloudPlatform/gcloud-node/blob/v0.35.0/lib/storage/file.js#L702