-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: predefined ACL support #177
Labels
api: storage
Issues related to the Cloud Storage API.
🚨
This issue needs some love.
triage me
I really want to be triaged.
Milestone
Comments
We're actually discussing this at #163 - feel free to chime in there :) |
yoshi-automation
added
🚨
This issue needs some love.
triage me
I really want to be triaged.
labels
Apr 6, 2020
chingor13
pushed a commit
that referenced
this issue
Aug 22, 2022
4 tasks
sofisl
pushed a commit
that referenced
this issue
Sep 15, 2022
sofisl
pushed a commit
that referenced
this issue
Oct 12, 2022
This was referenced Oct 12, 2022
sofisl
pushed a commit
that referenced
this issue
Oct 13, 2022
[PR](googleapis/gapic-generator-typescript#878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Link: googleapis/googleapis@95fa72f Source-Link: googleapis/googleapis-gen@f40a343
sofisl
pushed a commit
that referenced
this issue
Nov 10, 2022
This was referenced Nov 10, 2022
sofisl
pushed a commit
that referenced
this issue
Nov 10, 2022
* [CHANGE ME] Re-generated to pick up changes in the API or client library generator. * fix(docs): dead link
sofisl
pushed a commit
that referenced
this issue
Nov 10, 2022
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ts-loader](https://github.com/TypeStrong/ts-loader) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/ts-loader/7.0.5/8.0.0) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v8.0.0`](https://github.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v800) [Compare Source](https://github.com/TypeStrong/ts-loader/compare/v7.0.5...v8.0.0) - [Support for symlinks in project references](https://github.com/TypeStrong/ts-loader/pull/1136) - thanks [@​sheetalkamat](https://github.com/sheetalkamat)! - `ts-loader` now supports TypeScript 3.6 and greater **BREAKING CHANGE** </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-web-risk).
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/73563d93-aea4-4354-9013-d19800d55cda/targets
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
* docs: add webhook code sample * update json data * fixed failing test * fixed test naming * converted response to string * removed convert to str * moved response object * lint fix * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Added link to linkinator * update test * revised code * lint fix * lint fix Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jsdoc](https://github.com/jsdoc/jsdoc) | [`^3.6.6` -> `^4.0.0`](https://renovatebot.com/diffs/npm/jsdoc/3.6.11/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/compatibility-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/confidence-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jsdoc/jsdoc</summary> ### [`v4.0.0`](https://github.com/jsdoc/jsdoc/blob/HEAD/CHANGES.md#​400-November-2022) [Compare Source](https://github.com/jsdoc/jsdoc/compare/3.6.11...084218523a7d69fec14a852ce680f374f526af28) - JSDoc releases now use [semantic versioning](https://semver.org/). If JSDoc makes backwards-incompatible changes in the future, the major version will be incremented. - JSDoc no longer uses the [`taffydb`](https://taffydb.com/) package. If your JSDoc template or plugin uses the `taffydb` package, see the [instructions for replacing `taffydb` with `@jsdoc/salty`](https://github.com/jsdoc/jsdoc/tree/main/packages/jsdoc-salty#use-salty-in-a-jsdoc-template). - JSDoc now supports Node.js 12.0.0 and later. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-service-management). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTcuMSJ9-->
4 tasks
Merged
sofisl
pushed a commit
that referenced
this issue
Nov 16, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/e6ac0f7f-2fc1-4ac2-9eb5-23ba1215b6a2/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@dc9caca
This was referenced Nov 16, 2022
sofisl
added a commit
that referenced
this issue
Nov 16, 2022
* build!: Update library to use Node 12
4 tasks
sofisl
added a commit
that referenced
this issue
Nov 30, 2022
sofisl
pushed a commit
that referenced
this issue
Nov 30, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://www.github.com/googleapis/nodejs-datacatalog/compare/v2.0.0...v2.1.0) (2020-06-16) ### Features * add order field to TagField and TagTemplateField ([#157](https://www.github.com/googleapis/nodejs-datacatalog/issues/157)) ([70c23c2](https://www.github.com/googleapis/nodejs-datacatalog/commit/70c23c2b609bd24901dc902090e23fbf92b55895)) * move ts target to es2018 from es2016 ([#172](https://www.github.com/googleapis/nodejs-datacatalog/issues/172)) ([e354dde](https://www.github.com/googleapis/nodejs-datacatalog/commit/e354ddeeeedd3e106c50ed579075f23c9d9c5bb5)) * promote library to GA ([#177](https://www.github.com/googleapis/nodejs-datacatalog/issues/177)) ([ac11090](https://www.github.com/googleapis/nodejs-datacatalog/commit/ac110906b723f362024318295e3de6743c905b7e)) ### Bug Fixes * proper fallback option handling ([51df672](https://www.github.com/googleapis/nodejs-datacatalog/commit/51df6721306ab6d2d9bf6919b0f3f432ca85b4ab)) * regenerate unit tests ([#163](https://www.github.com/googleapis/nodejs-datacatalog/issues/163)) ([4593117](https://www.github.com/googleapis/nodejs-datacatalog/commit/45931176d266d364e0508039cf6a4e284ad2923d)) * synth.py clean up for multiple version ([#167](https://www.github.com/googleapis/nodejs-datacatalog/issues/167)) ([c799604](https://www.github.com/googleapis/nodejs-datacatalog/commit/c799604b2d29269006ff39748afb78302ce46ca2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
4 tasks
sofisl
pushed a commit
that referenced
this issue
Jan 10, 2023
4 tasks
sofisl
pushed a commit
that referenced
this issue
Jan 17, 2023
sofisl
pushed a commit
that referenced
this issue
Jan 24, 2023
sofisl
pushed a commit
that referenced
this issue
Jan 25, 2023
4 tasks
sofisl
pushed a commit
that referenced
this issue
Sep 13, 2023
4 tasks
sofisl
pushed a commit
that referenced
this issue
Sep 14, 2023
4 tasks
This was referenced Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the Cloud Storage API.
🚨
This issue needs some love.
triage me
I really want to be triaged.
While using storage api I didn't find any option about predefined acl value. It seems that we need to patch the getWritableStream_ function inside lib/storage/index.js to customize the qs object, like, adding something like "predefinedAcl: option.acl"
This might also need a change to the API to accept an extra option parameter so we can do things like this:
bucket.write(filename, {data: buf, option: {predefinedAcl: 'publicRead'}}, function() { ... });
The text was updated successfully, but these errors were encountered: