Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Objects: compose as myBucket.combine #401

Closed
ryanseys opened this issue Feb 18, 2015 · 3 comments · Fixed by #408
Closed

Support Objects: compose as myBucket.combine #401

ryanseys opened this issue Feb 18, 2015 · 3 comments · Fixed by #408
Assignees
Labels
api: storage Issues related to the Cloud Storage API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@ryanseys
Copy link
Contributor

Here's a suggested usage:

var myBucket = storage.bucket('my-server-logs');
var log1 = myBucket.file('server-log-1');
var log2 = myBucket.file('server-log-2');

myBucket.combine({
  files: [log1, log2], // must all be in myBucket
  destination: 'combined-log-1-2' // new File in myBucket
}, function(err, newFile) {
  console.log(err, newFile);
});
@ryanseys ryanseys added the api: storage Issues related to the Cloud Storage API. label Feb 18, 2015
@ryanseys ryanseys added this to the Storage Stable milestone Feb 18, 2015
@stephenplusplus
Copy link
Contributor

How about this (supporting string filenames and file objects equally):

myBucket.combine(['log1', 'log2'], 'alllogs', function(err, newFile) {});

myBucket.combine([
  myBucket.file('log1'),
  myBucket.file('log2')
], 'alllogs', function(err, newFile) {});

myBucket.combine([
  myBucket.file('log1'),
  myBucket.file('log2')
], myBucket.file('alllogs'), function(err, newFile) {});

@ryanseys
Copy link
Contributor Author

Yep SGTM

@stephenplusplus
Copy link
Contributor

I'll get on this one 👍

@stephenplusplus stephenplusplus self-assigned this Feb 23, 2015
ryanseys added a commit that referenced this issue Feb 24, 2015
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
chingor13 pushed a commit that referenced this issue Aug 22, 2022
Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>

Source-Author: F. Hinkelmann <franziska.hinkelmann@gmail.com>
Source-Date: Wed Sep 30 14:13:57 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 079dcce498117f9570cebe6e6cff254b38ba3860
Source-Link: googleapis/synthtool@079dcce
sofisl pushed a commit that referenced this issue Sep 15, 2022
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Sep 16, 2022
sofisl pushed a commit that referenced this issue Sep 16, 2022
sofisl pushed a commit that referenced this issue Sep 27, 2022
* Add + run dependency updating script

* Address comments

Change-Id: I67af9d3ab9e461b579dbaee92274b6163d73c23e

* Run dependency script again

Change-Id: Icbec4acb2cc6bcfa40e0a3a705c5a1059d64efa5

* Update license

Change-Id: Ic1dd0a1bd34356e415bdbf005b81a71a8d2695c2

* Update (more) dependencies

Change-Id: Idaed95b9cfe486797fa75946b6f55e7e702217b8
sofisl pushed a commit that referenced this issue Oct 5, 2022
sofisl pushed a commit that referenced this issue Oct 5, 2022
sofisl pushed a commit that referenced this issue Oct 5, 2022
sofisl pushed a commit that referenced this issue Oct 5, 2022
sofisl pushed a commit that referenced this issue Nov 11, 2022
* build(node_library): migrate to Trampoline V2

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Fri Oct 2 12:13:27 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 0c868d49b8e05bc1f299bc773df9eb4ef9ed96e9
Source-Link: googleapis/synthtool@0c868d4

* build: only check --engine-strict for production deps

Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>

Source-Author: Benjamin E. Coe <bencoe@google.com>
Source-Date: Thu Oct 15 17:40:52 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5451633881133e5573cc271a18e73b18caca8b1b
Source-Link: googleapis/synthtool@5451633
sofisl pushed a commit that referenced this issue Nov 11, 2022
* Add + run dependency updating script

* Address comments

Change-Id: I67af9d3ab9e461b579dbaee92274b6163d73c23e

* Run dependency script again

Change-Id: Icbec4acb2cc6bcfa40e0a3a705c5a1059d64efa5

* Update license

Change-Id: Ic1dd0a1bd34356e415bdbf005b81a71a8d2695c2

* Update (more) dependencies

Change-Id: Idaed95b9cfe486797fa75946b6f55e7e702217b8
sofisl pushed a commit that referenced this issue Nov 11, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-containeranalysis).
sofisl pushed a commit that referenced this issue Nov 11, 2022
Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>

Source-Author: F. Hinkelmann <franziska.hinkelmann@gmail.com>
Source-Date: Wed Sep 30 14:13:57 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 079dcce498117f9570cebe6e6cff254b38ba3860
Source-Link: googleapis/synthtool@079dcce
sofisl pushed a commit that referenced this issue Nov 11, 2022
Source-Link: googleapis/synthtool@d815daf
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:a9d166a74752226923d159cb723df53429e226c9c076dad3ca52ffd073ff3bb4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Nov 17, 2022
* Add + run dependency updating script

* Address comments

Change-Id: I67af9d3ab9e461b579dbaee92274b6163d73c23e

* Run dependency script again

Change-Id: Icbec4acb2cc6bcfa40e0a3a705c5a1059d64efa5

* Update license

Change-Id: Ic1dd0a1bd34356e415bdbf005b81a71a8d2695c2

* Update (more) dependencies

Change-Id: Idaed95b9cfe486797fa75946b6f55e7e702217b8
sofisl pushed a commit that referenced this issue Jan 10, 2023
* Add + run dependency updating script

* Address comments

Change-Id: I67af9d3ab9e461b579dbaee92274b6163d73c23e

* Run dependency script again

Change-Id: Icbec4acb2cc6bcfa40e0a3a705c5a1059d64efa5

* Update license

Change-Id: Ic1dd0a1bd34356e415bdbf005b81a71a8d2695c2

* Update (more) dependencies

Change-Id: Idaed95b9cfe486797fa75946b6f55e7e702217b8
sofisl pushed a commit that referenced this issue Jan 24, 2023
* Add + run dependency updating script

* Address comments

Change-Id: I67af9d3ab9e461b579dbaee92274b6163d73c23e

* Run dependency script again

Change-Id: Icbec4acb2cc6bcfa40e0a3a705c5a1059d64efa5

* Update license

Change-Id: Ic1dd0a1bd34356e415bdbf005b81a71a8d2695c2

* Update (more) dependencies

Change-Id: Idaed95b9cfe486797fa75946b6f55e7e702217b8
sofisl pushed a commit that referenced this issue Jan 24, 2023
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
sofisl pushed a commit that referenced this issue Jan 25, 2023
* Add + run dependency updating script

* Address comments

Change-Id: I67af9d3ab9e461b579dbaee92274b6163d73c23e

* Run dependency script again

Change-Id: Icbec4acb2cc6bcfa40e0a3a705c5a1059d64efa5

* Update license

Change-Id: Ic1dd0a1bd34356e415bdbf005b81a71a8d2695c2

* Update (more) dependencies

Change-Id: Idaed95b9cfe486797fa75946b6f55e7e702217b8
sofisl pushed a commit that referenced this issue Jan 25, 2023
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
sofisl pushed a commit that referenced this issue Sep 13, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@google-cloud/storage](https://github.com/googleapis/nodejs-storage) | devDependencies | major | [`^4.0.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/@google-cloud%2fstorage/4.7.0/5.0.0) |

---

### Release Notes

<details>
<summary>googleapis/nodejs-storage</summary>

### [`v5.0.0`](https://github.com/googleapis/nodejs-storage/blob/master/CHANGELOG.md#&#8203;500-httpswwwgithubcomgoogleapisnodejs-storagecomparev470v500-2020-05-13)

[Compare Source](https://github.com/googleapis/nodejs-storage/compare/v4.7.0...v5.0.0)

##### ⚠ BREAKING CHANGES

-   automatically detect contentType if not provided ([#&#8203;1190](https://github.com/googleapis/nodejs-storage/issues/1190))
-   drop keepAcl parameter in file copy ([#&#8203;1166](https://github.com/googleapis/nodejs-storage/issues/1166))
-   drop support for node.js 8.x

##### Features

-   automatically detect contentType if not provided ([#&#8203;1190](https://www.github.com/googleapis/nodejs-storage/issues/1190)) ([b31ba4a](https://www.github.com/googleapis/nodejs-storage/commit/b31ba4a11399b57538ddf0d6ca2e10b2aa3fbc3a))
-   enable bytes read tracking ([#&#8203;1074](https://www.github.com/googleapis/nodejs-storage/issues/1074)) ([0776a04](https://www.github.com/googleapis/nodejs-storage/commit/0776a044f3b2149b485e114369e952688df75645))

##### Bug Fixes

-   **bucket:** Only disable resumable uploads for bucket.upload (fixes [#&#8203;1133](https://www.github.com/googleapis/nodejs-storage/issues/1133)) ([#&#8203;1135](https://www.github.com/googleapis/nodejs-storage/issues/1135)) ([2c20148](https://www.github.com/googleapis/nodejs-storage/commit/2c201486b7b2d3146846ac96c877a904c4a674b0)), closes [/github.com/googleapis/nodejs-storage/pull/1135#issuecomment-620070038](https://www.github.com/googleapis//github.com/googleapis/nodejs-storage/pull/1135/issues/issuecomment-620070038)
-   add whitespace to generateV4SignedPolicy ([#&#8203;1136](https://www.github.com/googleapis/nodejs-storage/issues/1136)) ([dcee78b](https://www.github.com/googleapis/nodejs-storage/commit/dcee78b98da23b02fe7d2f13a9270546bc07bba8))
-   apache license URL ([#&#8203;468](https://www.github.com/googleapis/nodejs-storage/issues/468)) ([#&#8203;1151](https://www.github.com/googleapis/nodejs-storage/issues/1151)) ([e8116d3](https://www.github.com/googleapis/nodejs-storage/commit/e8116d3c6fa7412858692e67745b514eef78850e))
-   Point to team in correct org ([#&#8203;1185](https://www.github.com/googleapis/nodejs-storage/issues/1185)) ([0bb1909](https://www.github.com/googleapis/nodejs-storage/commit/0bb19098013acf71cc3842f78ff333a8e356331a))
-   **deps:** update dependency [@&#8203;google-cloud/common](https://github.com/google-cloud/common) to v3 ([#&#8203;1134](https://www.github.com/googleapis/nodejs-storage/issues/1134)) ([774ac5c](https://www.github.com/googleapis/nodejs-storage/commit/774ac5c75f02238418cc8ed7242297ea573ca9cb))
-   **deps:** update dependency [@&#8203;google-cloud/paginator](https://github.com/google-cloud/paginator) to v3 ([#&#8203;1131](https://www.github.com/googleapis/nodejs-storage/issues/1131)) ([c1614d9](https://www.github.com/googleapis/nodejs-storage/commit/c1614d98e3047db379e09299b1014e80d73ed52f))
-   **deps:** update dependency [@&#8203;google-cloud/promisify](https://github.com/google-cloud/promisify) to v2 ([#&#8203;1127](https://www.github.com/googleapis/nodejs-storage/issues/1127)) ([06624a5](https://www.github.com/googleapis/nodejs-storage/commit/06624a534cd1fdbc38455eee8d89f9f60ba75758))
-   **deps:** update dependency uuid to v8 ([#&#8203;1170](https://www.github.com/googleapis/nodejs-storage/issues/1170)) ([6a98d64](https://www.github.com/googleapis/nodejs-storage/commit/6a98d64831baf1ca1ec2f03ecc4914745cba1c86))
-   **deps:** update gcs-resumable-upload, remove gitnpm usage ([#&#8203;1186](https://www.github.com/googleapis/nodejs-storage/issues/1186)) ([c78c9cd](https://www.github.com/googleapis/nodejs-storage/commit/c78c9cde49dccb2fcd4ce10e4e9f8299d65f6838))
-   **v4-policy:** encode special characters ([#&#8203;1169](https://www.github.com/googleapis/nodejs-storage/issues/1169)) ([6e48539](https://www.github.com/googleapis/nodejs-storage/commit/6e48539d76ca27e6f4c6cf2ac0872970f7391fed))
-   sync to [googleapis/conformance-tests@`fa559a1`](https://github.com/googleapis/conformance-tests/commit/fa559a1) ([#&#8203;1167](https://www.github.com/googleapis/nodejs-storage/issues/1167)) ([5500446](https://www.github.com/googleapis/nodejs-storage/commit/550044619d2f17a1977c83bce5df915c6dc9578c)), closes [#&#8203;1168](https://www.github.com/googleapis/nodejs-storage/issues/1168)

##### Miscellaneous Chores

-   drop keepAcl parameter in file copy ([#&#8203;1166](https://www.github.com/googleapis/nodejs-storage/issues/1166)) ([5a4044a](https://www.github.com/googleapis/nodejs-storage/commit/5a4044a8ba13f248fc4f791248f797eb0f1f3c16))

##### Build System

-   drop support for node.js 8.x ([b80c025](https://www.github.com/googleapis/nodejs-storage/commit/b80c025f106052fd25554c64314b3b3520e829b5))

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-automl).
sofisl pushed a commit that referenced this issue Sep 14, 2023
* Add + run dependency updating script

* Address comments

Change-Id: I67af9d3ab9e461b579dbaee92274b6163d73c23e

* Run dependency script again

Change-Id: Icbec4acb2cc6bcfa40e0a3a705c5a1059d64efa5

* Update license

Change-Id: Ic1dd0a1bd34356e415bdbf005b81a71a8d2695c2

* Update (more) dependencies

Change-Id: Idaed95b9cfe486797fa75946b6f55e7e702217b8
sofisl pushed a commit that referenced this issue Sep 14, 2023
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/cc99acfa-05b8-434b-9500-2f6faf2eaa02/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@799d8e6
sofisl pushed a commit that referenced this issue Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants