-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Protocol Buffers lib #474
Comments
Interesting. I'm all for speed and simplicity, especially when we have performance regressions or we are implementing with it. Not sure we have either of those scenarios so my comment is "why bother?" at least right now. I worry we'd see compatibility issues if not everything is implemented in this new library. Good to keep on the radar. |
Fair enough, we'll just close this for now, and if we find the need for something new in the future, we can review this one again. |
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-loader](https://github.com/TypeStrong/ts-loader) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/ts-loader/8.1.0/9.0.0) | [![age](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/compatibility-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/confidence-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v9.0.0`](https://github.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v900) [Compare Source](https://github.com/TypeStrong/ts-loader/compare/v8.1.0...v9.0.0) Breaking changes: - minimum webpack version: 5 - minimum node version: 12 Changes: - [webpack 5 migration](https://github.com/TypeStrong/ts-loader/pull/1251) - thanks [@​johnnyreilly](https://github.com/johnnyreilly), [@​jonwallsten](https://github.com/jonwallsten), [@​sokra](https://github.com/sokra), [@​appzuka](https://github.com/appzuka), [@​alexander-akait](https://github.com/alexander-akait) </details> --- ### Configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-asset).
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-loader](https://github.com/TypeStrong/ts-loader) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/ts-loader/8.1.0/9.0.0) | [![age](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/compatibility-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/confidence-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v9.0.0`](https://github.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v900) [Compare Source](https://github.com/TypeStrong/ts-loader/compare/v8.1.0...v9.0.0) Breaking changes: - minimum webpack version: 5 - minimum node version: 12 Changes: - [webpack 5 migration](https://github.com/TypeStrong/ts-loader/pull/1251) - thanks [@​johnnyreilly](https://github.com/johnnyreilly), [@​jonwallsten](https://github.com/jonwallsten), [@​sokra](https://github.com/sokra), [@​appzuka](https://github.com/appzuka), [@​alexander-akait](https://github.com/alexander-akait) </details> --- ### Configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-asset).
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-loader](https://github.com/TypeStrong/ts-loader) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/ts-loader/8.1.0/9.0.0) | [![age](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/compatibility-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/confidence-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v9.0.0`](https://github.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v900) [Compare Source](https://github.com/TypeStrong/ts-loader/compare/v8.1.0...v9.0.0) Breaking changes: - minimum webpack version: 5 - minimum node version: 12 Changes: - [webpack 5 migration](https://github.com/TypeStrong/ts-loader/pull/1251) - thanks [@​johnnyreilly](https://github.com/johnnyreilly), [@​jonwallsten](https://github.com/jonwallsten), [@​sokra](https://github.com/sokra), [@​appzuka](https://github.com/appzuka), [@​alexander-akait](https://github.com/alexander-akait) </details> --- ### Configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-asset).
gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f
🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.6](https://www.github.com/googleapis/nodejs-os-login/compare/v3.2.5...v3.2.6) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#474](https://www.github.com/googleapis/nodejs-os-login/issues/474)) ([b84fa0a](https://www.github.com/googleapis/nodejs-os-login/commit/b84fa0a5ed3d6b4888e083e8fbda68a47d4d691a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.6](https://www.github.com/googleapis/nodejs-os-login/compare/v3.2.5...v3.2.6) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#474](https://www.github.com/googleapis/nodejs-os-login/issues/474)) ([b84fa0a](https://www.github.com/googleapis/nodejs-os-login/commit/b84fa0a5ed3d6b4888e083e8fbda68a47d4d691a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.6](https://www.github.com/googleapis/nodejs-os-login/compare/v3.2.5...v3.2.6) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#474](https://www.github.com/googleapis/nodejs-os-login/issues/474)) ([b84fa0a](https://www.github.com/googleapis/nodejs-os-login/commit/b84fa0a5ed3d6b4888e083e8fbda68a47d4d691a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.6](https://www.github.com/googleapis/nodejs-os-login/compare/v3.2.5...v3.2.6) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#474](https://www.github.com/googleapis/nodejs-os-login/issues/474)) ([b84fa0a](https://www.github.com/googleapis/nodejs-os-login/commit/b84fa0a5ed3d6b4888e083e8fbda68a47d4d691a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.3](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/compare/v2.2.2...v2.2.3) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#472](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/472)) ([9f43f07](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/9f43f07aa530741ee7690d4dcc0c6d15023e7cb1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Just stumbled upon this: https://github.com/mafintosh/protocol-buffers - maybe worth integrating? Looks simple and fast.
The text was updated successfully, but these errors were encountered: