-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery's table.import() callback is invoked improperly #495
Labels
api: bigquery
Issues related to the BigQuery API.
🚨
This issue needs some love.
triage me
I really want to be triaged.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
jgeewax
added
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
api: bigquery
Issues related to the BigQuery API.
labels
May 14, 2015
yoshi-automation
added
triage me
I really want to be triaged.
🚨
This issue needs some love.
labels
Apr 6, 2020
4 tasks
sofisl
pushed a commit
that referenced
this issue
Oct 11, 2022
…#495) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7b446397-88f3-4463-9e7d-d2ce7069989d/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5936421
sofisl
pushed a commit
that referenced
this issue
Oct 13, 2022
…#495) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7b446397-88f3-4463-9e7d-d2ce7069989d/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5936421
sofisl
pushed a commit
that referenced
this issue
Nov 10, 2022
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
[PR](googleapis/gapic-generator-typescript#878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Link: googleapis/googleapis@95fa72f Source-Link: googleapis/googleapis-gen@f40a343
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
* docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-iot/compare/v2.3.3...v2.3.4) (2021-07-01) ### Bug Fixes * **deps:** require google-gax v2.17.0 ([#493](https://www.github.com/googleapis/nodejs-iot/issues/493)) ([f61a834](https://www.github.com/googleapis/nodejs-iot/commit/f61a834d9d8e9564f73849821de351757589422a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2b12f6c9-10d8-4a5e-b86e-af5827858559/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@ba9918c
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 18, 2022
* feat: support regapic LRO Use gapic-generator-typescript v2.15.1. PiperOrigin-RevId: 456946341 Source-Link: googleapis/googleapis@88fd18d Source-Link: googleapis/googleapis-gen@accfa37 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this issue
Jan 24, 2023
sofisl
pushed a commit
that referenced
this issue
Jan 25, 2023
4 tasks
sofisl
pushed a commit
that referenced
this issue
Sep 13, 2023
* chore: migrate to owl bot * chore: copy files from googleapis-gen fb91803ccef5d7c695139b22788b309e2197856b * chore: run the post processor * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the BigQuery API.
🚨
This issue needs some love.
triage me
I really want to be triaged.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
If you pass a string filename into BigQuery's
table.import()
method, the callback is invoked with the improper arguments. The documentation says the callback should be called with this format:But it is actually invoked like this:
This is caused by improperly handling the
complete
event ofcreateWriteStream()
on this line. The complete event fires with noerror
argument, but instead with thejob
as the first argument. So just forwarding the arguments ontocallback
results in the undocumented behavior.A PR with a fix is coming right up!
The text was updated successfully, but these errors were encountered: