-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on google-auto-auth and use google-auth-library #832
Comments
I only made it into its own module to restrict gcloud from taking on more responsibility than it needs. I also needed to use it from another module: https://github.com/stephenplusplus/gce-images (that is in turn used by gcloud). I would like to switch back to auth-library and deprecate auto-auth, but is it possible to wait to see if googleapis/google-auth-library-nodejs#54, googleapis/google-auth-library-nodejs#55, and googleapis/google-auth-library-nodejs#56 re-shape the library to make it easier for us to consume first? |
Sorry, I missed the second part saying just what I was asking for in my reply. Hard to believe I couldn't read two sentences properly... I'll make an issue to get me a pair of glasses. |
I think this issue can be tracked on google-auth-library (googleapis/google-auth-library-nodejs#54, googleapis/google-auth-library-nodejs#55, googleapis/google-auth-library-nodejs#56). We'll be aware if and when changes are made there and happily use google-auth-library as our dependency here. |
🤖 I have created a release \*beep\* \*boop\* --- ### [4.1.1](https://www.github.com/googleapis/nodejs-dialogflow/compare/v4.1.0...v4.1.1) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#837](https://www.github.com/googleapis/nodejs-dialogflow/issues/837)) ([05819be](https://www.github.com/googleapis/nodejs-dialogflow/commit/05819be5b6592c0c377f522ae56bf3a3bdd8dbde)) * make request optional in all cases ([#830](https://www.github.com/googleapis/nodejs-dialogflow/issues/830)) ([08ef5e5](https://www.github.com/googleapis/nodejs-dialogflow/commit/08ef5e59076b498fb423279059ab11de95a54e58)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
google-auth-library is where auth-related functionality should go. Add whatever features are required from google-auto-auth to it, and switch the dependency back to google-auth-library-nodejs.
The text was updated successfully, but these errors were encountered: