Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: clone user-provided options #1011

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

stephenplusplus
Copy link
Contributor

Fixes #1009

This clones the configuration object the user provides, instead of directly modifying it.

@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Dec 9, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2015
callmehiphop added a commit that referenced this pull request Dec 9, 2015
@callmehiphop callmehiphop merged commit a256ecc into googleapis:master Dec 9, 2015
sofisl pushed a commit that referenced this pull request Jan 17, 2023
PiperOrigin-RevId: 446836546
Source-Link: googleapis/googleapis@ca17771
Source-Link: googleapis/googleapis-gen@2957b3d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjk1N2IzZDc4ZmMyNDM1NGIzMDg5NjkwN2RlMTM1NDEzYjhlN2E0OSJ9
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
fix!: Product search related messages and enums changed in an incompatible way
fix!: NormalizedBoundingPoly message removed
PiperOrigin-RevId: 446837836
Source-Link: googleapis/googleapis@4c8ac5c
Source-Link: googleapis/googleapis-gen@8f7398f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGY3Mzk4ZmJkNzlhNGZiNmE0YWIxZjZhMTQ1NDc4NTIxMjE5ODZmZCJ9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants