refactor(storage): Use async in regression tests #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| ], done); | ||
| async.parallel( | ||
| filenames.map( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Added comment about styling, otherwise LGTM. |
silvolu
added a commit
that referenced
this pull request
Aug 14, 2014
refactor(storage): Use async in regression tests
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
chore(deps): update dependency mocha to v6 This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | mocha | devDependencies | major | `^5.2.0` -> `^6.0.0` | [homepage](https://mochajs.org/), [source](https://github.com/mochajs/mocha) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v6.0.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#​600--2019-02-18) [Compare Source](https://github.com/mochajs/mocha/compare/v5.2.0...v6.0.0) #### 🎉 Enhancements - [#​3726](https://github.com/mochajs/mocha/issues/3726): Add ability to unload files from `require` cache ([**@​plroebuck**](https://github.com/plroebuck)) #### 🐛 Fixes - [#​3737](https://github.com/mochajs/mocha/issues/3737): Fix falsy values from options globals ([**@​plroebuck**](https://github.com/plroebuck)) - [#​3707](https://github.com/mochajs/mocha/issues/3707): Fix encapsulation issues for `Suite#_onlyTests` and `Suite#_onlySuites` ([**@​vkarpov15**](https://github.com/vkarpov15)) - [#​3711](https://github.com/mochajs/mocha/issues/3711): Fix diagnostic messages dealing with plurality and markup of output ([**@​plroebuck**](https://github.com/plroebuck)) - [#​3723](https://github.com/mochajs/mocha/issues/3723): Fix "reporter-option" to allow comma-separated options ([**@​boneskull**](https://github.com/boneskull)) - [#​3722](https://github.com/mochajs/mocha/issues/3722): Fix code quality and performance of `lookupFiles` and `files` ([**@​plroebuck**](https://github.com/plroebuck)) - [#​3650](https://github.com/mochajs/mocha/issues/3650), [#​3654](https://github.com/mochajs/mocha/issues/3654): Fix noisy error message when no files found ([**@​craigtaub**](https://github.com/craigtaub)) - [#​3632](https://github.com/mochajs/mocha/issues/3632): Tests having an empty title are no longer confused with the "root" suite ([**@​juergba**](https://github.com/juergba)) - [#​3666](https://github.com/mochajs/mocha/issues/3666): Fix missing error codes ([**@​vkarpov15**](https://github.com/vkarpov15)) - [#​3684](https://github.com/mochajs/mocha/issues/3684): Fix exiting problem in Node.js v11.7.0+ ([**@​addaleax**](https://github.com/addaleax)) - [#​3691](https://github.com/mochajs/mocha/issues/3691): Fix `--delay` (and other boolean options) not working in all cases ([**@​boneskull**](https://github.com/boneskull)) - [#​3692](https://github.com/mochajs/mocha/issues/3692): Fix invalid command-line argument usage not causing actual errors ([**@​boneskull**](https://github.com/boneskull)) - [#​3698](https://github.com/mochajs/mocha/issues/3698), [#​3699](https://github.com/mochajs/mocha/issues/3699): Fix debug-related Node.js options not working in all cases ([**@​boneskull**](https://github.com/boneskull)) - [#​3700](https://github.com/mochajs/mocha/issues/3700): Growl notifications now show the correct number of tests run ([**@​outsideris**](https://github.com/outsideris)) - [#​3686](https://github.com/mochajs/mocha/issues/3686): Avoid potential ReDoS when diffing large objects ([**@​cyjake**](https://github.com/cyjake)) - [#​3715](https://github.com/mochajs/mocha/issues/3715): Fix incorrect order of emitted events when used programmatically ([**@​boneskull**](https://github.com/boneskull)) - [#​3706](https://github.com/mochajs/mocha/issues/3706): Fix regression wherein `--reporter-option`/`--reporter-options` did not support comma-separated key/value pairs ([**@​boneskull**](https://github.com/boneskull)) #### 📖 Documentation - [#​3652](https://github.com/mochajs/mocha/issues/3652): Switch from Jekyll to Eleventy ([**@​Munter**](https://github.com/Munter)) #### 🔩 Other - [#​3677](https://github.com/mochajs/mocha/issues/3677): Add error objects for createUnsupportedError and createInvalidExceptionError ([**@​boneskull**](https://github.com/boneskull)) - [#​3733](https://github.com/mochajs/mocha/issues/3733): Removed unnecessary processing in post-processing hook ([**@​wanseob**](https://github.com/wanseob)) - [#​3730](https://github.com/mochajs/mocha/issues/3730): Update nyc to latest version ([**@​coreyfarrell**](https://github.com/coreyfarrell)) - [#​3648](https://github.com/mochajs/mocha/issues/3648), [#​3680](https://github.com/mochajs/mocha/issues/3680): Fixes to support latest versions of [unexpected](https://npm.im/unexpected) and [unexpected-sinon](https://npm.im/unexpected-sinon) ([**@​sunesimonsen**](https://github.com/sunesimonsen)) - [#​3638](https://github.com/mochajs/mocha/issues/3638): Add meta tag to site ([**@​MartijnCuppens**](https://github.com/MartijnCuppens)) - [#​3653](https://github.com/mochajs/mocha/issues/3653): Fix parts of test suite failing to run on Windows ([**@​boneskull**](https://github.com/boneskull)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/nodejs-asset). #109 automerged by dpebot
chingor13
pushed a commit
that referenced
this pull request
Sep 12, 2022
* fix(artifactregistry): add missing HTTP rules to service config PiperOrigin-RevId: 420790332 Source-Link: googleapis/googleapis@3965406 Source-Link: googleapis/googleapis-gen@bdf699a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmRmNjk5YWFlMDAyOTI5NDZkYzhmNWVlZjVlZTAzYzMxNTJiODY0NCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Ace Nassri <anassri@google.com> Co-authored-by: Patti Shin <pattishin@users.noreply.github.com> Co-authored-by: Jeffrey Rennie <rennie@google.com>
chingor13
pushed a commit
that referenced
this pull request
Sep 14, 2022
* fix(artifactregistry): add missing HTTP rules to service config PiperOrigin-RevId: 420790332 Source-Link: googleapis/googleapis@3965406 Source-Link: googleapis/googleapis-gen@bdf699a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmRmNjk5YWFlMDAyOTI5NDZkYzhmNWVlZjVlZTAzYzMxNTJiODY0NCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Ace Nassri <anassri@google.com> Co-authored-by: Patti Shin <pattishin@users.noreply.github.com> Co-authored-by: Jeffrey Rennie <rennie@google.com>
Merged
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
This was referenced Oct 5, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/nodejs-phishing-protection/compare/v1.6.0...v1.7.0) (2020-03-06) ### Features * deferred client initialization ([#108](https://www.github.com/googleapis/nodejs-phishing-protection/issues/108)) ([1552963](https://www.github.com/googleapis/nodejs-phishing-protection/commit/1552963ecd210fa5a50abe17f95bf343d502cc3a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4bdc1826-2f69-49f1-a63b-94f99cceb5ee/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@89d431f
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/96fb0e9d-e02a-4451-878f-e646368369cc/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@94421c4
This was referenced Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
…e in region tag (#109) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 399287285 Source-Link: googleapis/googleapis@1575986 Source-Link: googleapis/googleapis-gen@b27fff6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjI3ZmZmNjIzYTVkOGQ1ODZiNzAzYjVlNDkxOTg1NmFiZTdjMmViMyJ9
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 434859890 Source-Link: googleapis/googleapis@bc2432d Source-Link: googleapis/googleapis-gen@930b673 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
4 tasks
sofisl
added a commit
that referenced
this pull request
Nov 11, 2022
* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* chore(main): release 2.1.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.2](https://github.com/googleapis/nodejs-essential-contacts/compare/v2.0.1...v2.0.2) (2022-11-11) ### Bug Fixes * Allow passing gax instance to client constructor ([#110](https://github.com/googleapis/nodejs-essential-contacts/issues/110)) ([fb3d596](https://github.com/googleapis/nodejs-essential-contacts/commit/fb3d596a8dee0ab338485a862955757cfbcd99c2)) * Better support for fallback mode ([#105](https://github.com/googleapis/nodejs-essential-contacts/issues/105)) ([c23259b](https://github.com/googleapis/nodejs-essential-contacts/commit/c23259b0a493e5bcdabf408902ffe16be76e7cb0)) * Change import long to require ([#106](https://github.com/googleapis/nodejs-essential-contacts/issues/106)) ([f009752](https://github.com/googleapis/nodejs-essential-contacts/commit/f009752ac7a8267ef6444fa9eb7338e70e6687d6)) * **deps:** Use google-gax v3.5.2 ([#117](https://github.com/googleapis/nodejs-essential-contacts/issues/117)) ([f90a6e7](https://github.com/googleapis/nodejs-essential-contacts/commit/f90a6e75af5c23754bf67bea1b8fd55c96a1330f)) * Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-essential-contacts/issues/1553)) ([#109](https://github.com/googleapis/nodejs-essential-contacts/issues/109)) ([c7e8827](https://github.com/googleapis/nodejs-essential-contacts/commit/c7e8827859caa1c23bc38f43ca71cfe8d6784dfd)) * Preserve default values in x-goog-request-params header ([#111](https://github.com/googleapis/nodejs-essential-contacts/issues/111)) ([5074ba2](https://github.com/googleapis/nodejs-essential-contacts/commit/5074ba241d3e5ac5dc4a47ef7fc9cc3761f406cb)) * Regenerated protos JS and TS definitions ([#120](https://github.com/googleapis/nodejs-essential-contacts/issues/120)) ([4989df1](https://github.com/googleapis/nodejs-essential-contacts/commit/4989df17b1c7d0deb7907f7659b0fd2032833e8f)) * Remove pip install statements ([#1546](https://github.com/googleapis/nodejs-essential-contacts/issues/1546)) ([#108](https://github.com/googleapis/nodejs-essential-contacts/issues/108)) ([9fb4d1c](https://github.com/googleapis/nodejs-essential-contacts/commit/9fb4d1c253480086fe101cef0817874b313d076a)) * use google-gax v3.3.0 ([c7e8827](https://github.com/googleapis/nodejs-essential-contacts/commit/c7e8827859caa1c23bc38f43ca71cfe8d6784dfd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9
This was referenced Nov 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.3.5](https://www.github.com/googleapis/nodejs-bigquery-connection/compare/v1.3.4...v1.3.5) (2021-07-12) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#108](https://www.github.com/googleapis/nodejs-bigquery-connection/issues/108)) ([b94f6e6](https://www.github.com/googleapis/nodejs-bigquery-connection/commit/b94f6e69c6984ef5180f64e25eb5576d35471573)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped) | [`^14.14.10` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-retail).
](https://renovatebot.com){kind=link}
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.