Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: use streams. #118

Merged
merged 1 commit into from
Aug 19, 2014
Merged

Conversation

stephenplusplus
Copy link
Contributor

I know this is beating a dead horse, but I finally got streams working with the help of duplexify. Getting this in before M1 release would be fantastic, since this is such a fundamental Node philosophy, and is relied on in many apps.

Given that the streams worked out, I simplified the signature of Bucket#write. If a user wishes to use our writable, they are free to open their readable pipeline however they wish, then simply pipe it to bucket.createWriteStream() (as opposed to passing a readable to #write). As an added shortcut, Bucket#write accepts a string or buffer directly: bucket.write('file', 'Hi!', function(err) {});

util.handleResp(null, resp, resp.body, callback);
});
});
.on('complete', callback.bind(null, null));

This comment was marked as spam.

This comment was marked as spam.

@rakyll
Copy link
Contributor

rakyll commented Aug 19, 2014

I liked this approach much! One question about Bucket.prototype.write: Do we need it at all? createWriteStream(...).write(buffer) isn't working?

@stephenplusplus
Copy link
Contributor Author

write is just left around for when one needs to write a string or buffer. As far as I know, without our write method, the user would have to design/implement their own string/buffer readable stream in order to be able to pipe it to createWriteStream().

For those use cases, the api now looks like:

bucket.write('destination-file-name', 'Contents', function(err) {});
// or
bucket.write('destination-file-name', {
  data: 'Contents',
  metadata: {
    // ...
  }
}, function(err) {});

It also still handles metadata-only posts when there is no data provided.

@rakyll
Copy link
Contributor

rakyll commented Aug 19, 2014

Writable streams provide a write method: http://nodejs.org/api/stream.html#stream_writable_write_chunk_encoding_callback

var st = bucket.createWriteableStream(...);
st.write(buffer);
st.end();

should work. But for metadata only requests, it's weird to require end before writing any data to the stream.

@rakyll
Copy link
Contributor

rakyll commented Aug 19, 2014

I'm merging this change, will run some perf test later this week. Much thanks!

rakyll pushed a commit that referenced this pull request Aug 19, 2014
@rakyll rakyll merged commit c3dd731 into googleapis:master Aug 19, 2014
@stephenplusplus stephenplusplus deleted the storage-stream branch August 19, 2014 22:14
chingor13 pushed a commit that referenced this pull request Sep 12, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^12.0.0` -> `^13.0.0`](https://renovatebot.com/diffs/npm/sinon/12.0.1/13.0.1) | [![age](https://badges.renovateapi.com/packages/npm/sinon/13.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/13.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/13.0.1/compatibility-slim/12.0.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/13.0.1/confidence-slim/12.0.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v13.0.1`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#&#8203;1301)

[Compare Source](https://github.com/sinonjs/sinon/compare/v13.0.0...v13.0.1)

-   [`ec4223f9`](https://github.com/sinonjs/sinon/commit/ec4223f94076d809483e3c6a7536cfc1278dd3c9)
    Bump nise to fix [sinonjs/nise#&#8203;193](https://github.com/sinonjs/nise/issues/193) (Carl-Erik Kopseng)
-   [`f329a010`](https://github.com/sinonjs/sinon/commit/f329a01040bfa5a79e039419220b21eda56935d6)
    Add unimported to workflow ([#&#8203;2441](https://github.com/sinonjs/sinon/issues/2441)) (Morgan Roderick)
-   [`7f16cec9`](https://github.com/sinonjs/sinon/commit/7f16cec968c3c8d4e580267fb00195916d6f827d)
    Enable updates to same major version (Carl-Erik Kopseng)
-   [`f784d7ad`](https://github.com/sinonjs/sinon/commit/f784d7ad2c86be0fc65477d69f8bdafca846ef2c)
    Re-introduce new version.sh script to version hook (Joel Bradshaw)
    > This was inadvertently removed during merge conflicts, and is required
    > for any of the new release process stuff to work
-   [`51c508ab`](https://github.com/sinonjs/sinon/commit/51c508ab77cf0f9fb8c5305ff626f6a2eada178f)
    Add dry run mode to `npm version` ([#&#8203;2436](https://github.com/sinonjs/sinon/issues/2436)) (Joel Bradshaw)
    > -   Add DRY_RUN flag to skip publish/push
    >
    > -   Allow overriding branch names for testing
-   [`05341dcf`](https://github.com/sinonjs/sinon/commit/05341dcf92ddca4a1d4c90966b1fcdc7039cff18)
    Update npm version scripts to manage new releases branch (Joel Bradshaw)
-   [`fe658261`](https://github.com/sinonjs/sinon/commit/fe65826171db69ed2986a1060db77944dbc98a6d)
    Remove release archives from master (Joel Bradshaw)
    > These archives made it difficult to find things in the GitHub interface,
    > and take up a lot of space in a checked-out repo for something that is
    > not useful to most people checking out the repository.
    >
    > The main purpose of these archives is to make old versions and
    > documentation available on the Sinon website that is run out of this
    > repo. This can be supported by using a separate branch for website
    > releases, and to maintain the archives.
    >
    > Following this commit, the `npm version` scripts will be updated to
    > automatically handle archiving the releases in the new releases branch
    > and keeping it up to date with master.
    >
    > Also remove the directories we removed from .prettierignore, since they
    > don't exist any more.

*Released by [Carl-Erik Kopseng](https://github.com/fatso83) on 2022-02-01.*

### [`v13.0.0`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#&#8203;1300)

[Compare Source](https://github.com/sinonjs/sinon/compare/v12.0.1...v13.0.0)

-   [`cf3d6c0c`](https://github.com/sinonjs/sinon/commit/cf3d6c0cd9689c0ee673b3daa8bf9abd70304392)
    Upgrade packages ([#&#8203;2431](https://github.com/sinonjs/sinon/issues/2431)) (Carl-Erik Kopseng)
    > -   Update all @&#8203;sinonjs/ packages
    >
    > -   Upgrade to fake-timers 9
    >
    > -   chore: ensure always using latest LTS release
-   [`41710467`](https://github.com/sinonjs/sinon/commit/417104670d575e96a1b645ea40ce763afa76fb1b)
    Adjust deploy scripts to archive old releases in a separate branch, move existing releases out of master ([#&#8203;2426](https://github.com/sinonjs/sinon/issues/2426)) (Joel Bradshaw)
    > Co-authored-by: Carl-Erik Kopseng <carlerik@gmail.com>
-   [`c80a7266`](https://github.com/sinonjs/sinon/commit/c80a72660e89d88b08275eff1028ecb9e26fd8e9)
    Bump node-fetch from 2.6.1 to 2.6.7 ([#&#8203;2430](https://github.com/sinonjs/sinon/issues/2430)) (dependabot\[bot])
    > Co-authored-by: dependabot\[bot] <49699333+dependabot\[bot][@&#8203;users](https://github.com/users).noreply.git.luolix.top>
-   [`a00f14a9`](https://github.com/sinonjs/sinon/commit/a00f14a97dbe8c65afa89674e16ad73fc7d2fdc0)
    Add explicit export for `./*` ([#&#8203;2413](https://github.com/sinonjs/sinon/issues/2413)) (なつき)
-   [`b82ca7ad`](https://github.com/sinonjs/sinon/commit/b82ca7ad9b1add59007771f65a18ee34415de8ca)
    Bump cached-path-relative from 1.0.2 to 1.1.0 ([#&#8203;2428](https://github.com/sinonjs/sinon/issues/2428)) (dependabot\[bot])
-   [`a9ea1427`](https://github.com/sinonjs/sinon/commit/a9ea142716c094ef3c432ecc4089f8207b8dd8b6)
    Add documentation for assert.calledOnceWithMatch ([#&#8203;2424](https://github.com/sinonjs/sinon/issues/2424)) (Mathias Schreck)
-   [`1d5ab86b`](https://github.com/sinonjs/sinon/commit/1d5ab86ba60e50dd69593ffed2bffd4b8faa0d38)
    Be more general in stripping off stack frames to fix Firefox tests ([#&#8203;2425](https://github.com/sinonjs/sinon/issues/2425)) (Joel Bradshaw)
-   [`56b06129`](https://github.com/sinonjs/sinon/commit/56b06129e223eae690265c37b1113067e2b31bdc)
    Check call count type ([#&#8203;2410](https://github.com/sinonjs/sinon/issues/2410)) (Joel Bradshaw)
-   [`7863e2df`](https://github.com/sinonjs/sinon/commit/7863e2dfdbda79e0a32e42af09e6539fc2f2b80f)
    Fix [#&#8203;2414](https://github.com/sinonjs/sinon/issues/2414): make Sinon available on homepage (Carl-Erik Kopseng)
-   [`fabaabdd`](https://github.com/sinonjs/sinon/commit/fabaabdda82f39a7f5b75b55bd56cf77b1cd4a8f)
    Bump nokogiri from 1.11.4 to 1.13.1 ([#&#8203;2423](https://github.com/sinonjs/sinon/issues/2423)) (dependabot\[bot])
-   [`dbc0fbd2`](https://github.com/sinonjs/sinon/commit/dbc0fbd263c8419fa47f9c3b20cf47890a242d21)
    Bump shelljs from 0.8.4 to 0.8.5 ([#&#8203;2422](https://github.com/sinonjs/sinon/issues/2422)) (dependabot\[bot])
-   [`fb8b3d72`](https://github.com/sinonjs/sinon/commit/fb8b3d72a85dc8fb0547f859baf3f03a22a039f7)
    Run Prettier (Carl-Erik Kopseng)
-   [`12a45939`](https://github.com/sinonjs/sinon/commit/12a45939e9b047b6d3663fe55f2eb383ec63c4e1)
    Fix 2377: Throw error when trying to stub non-configurable or non-writable properties ([#&#8203;2417](https://github.com/sinonjs/sinon/issues/2417)) (Stuart Dotson)
    > Fixes issue [#&#8203;2377](https://github.com/sinonjs/sinon/issues/2377) by throwing an error when trying to stub non-configurable or non-writable properties

*Released by [Carl-Erik Kopseng](https://github.com/fatso83) on 2022-01-28.*

</details>

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-artifact-registry).
chingor13 pushed a commit that referenced this pull request Sep 14, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^12.0.0` -> `^13.0.0`](https://renovatebot.com/diffs/npm/sinon/12.0.1/13.0.1) | [![age](https://badges.renovateapi.com/packages/npm/sinon/13.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/13.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/13.0.1/compatibility-slim/12.0.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/13.0.1/confidence-slim/12.0.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v13.0.1`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#&#8203;1301)

[Compare Source](https://github.com/sinonjs/sinon/compare/v13.0.0...v13.0.1)

-   [`ec4223f9`](https://github.com/sinonjs/sinon/commit/ec4223f94076d809483e3c6a7536cfc1278dd3c9)
    Bump nise to fix [sinonjs/nise#&#8203;193](https://github.com/sinonjs/nise/issues/193) (Carl-Erik Kopseng)
-   [`f329a010`](https://github.com/sinonjs/sinon/commit/f329a01040bfa5a79e039419220b21eda56935d6)
    Add unimported to workflow ([#&#8203;2441](https://github.com/sinonjs/sinon/issues/2441)) (Morgan Roderick)
-   [`7f16cec9`](https://github.com/sinonjs/sinon/commit/7f16cec968c3c8d4e580267fb00195916d6f827d)
    Enable updates to same major version (Carl-Erik Kopseng)
-   [`f784d7ad`](https://github.com/sinonjs/sinon/commit/f784d7ad2c86be0fc65477d69f8bdafca846ef2c)
    Re-introduce new version.sh script to version hook (Joel Bradshaw)
    > This was inadvertently removed during merge conflicts, and is required
    > for any of the new release process stuff to work
-   [`51c508ab`](https://github.com/sinonjs/sinon/commit/51c508ab77cf0f9fb8c5305ff626f6a2eada178f)
    Add dry run mode to `npm version` ([#&#8203;2436](https://github.com/sinonjs/sinon/issues/2436)) (Joel Bradshaw)
    > -   Add DRY_RUN flag to skip publish/push
    >
    > -   Allow overriding branch names for testing
-   [`05341dcf`](https://github.com/sinonjs/sinon/commit/05341dcf92ddca4a1d4c90966b1fcdc7039cff18)
    Update npm version scripts to manage new releases branch (Joel Bradshaw)
-   [`fe658261`](https://github.com/sinonjs/sinon/commit/fe65826171db69ed2986a1060db77944dbc98a6d)
    Remove release archives from master (Joel Bradshaw)
    > These archives made it difficult to find things in the GitHub interface,
    > and take up a lot of space in a checked-out repo for something that is
    > not useful to most people checking out the repository.
    >
    > The main purpose of these archives is to make old versions and
    > documentation available on the Sinon website that is run out of this
    > repo. This can be supported by using a separate branch for website
    > releases, and to maintain the archives.
    >
    > Following this commit, the `npm version` scripts will be updated to
    > automatically handle archiving the releases in the new releases branch
    > and keeping it up to date with master.
    >
    > Also remove the directories we removed from .prettierignore, since they
    > don't exist any more.

*Released by [Carl-Erik Kopseng](https://github.com/fatso83) on 2022-02-01.*

### [`v13.0.0`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#&#8203;1300)

[Compare Source](https://github.com/sinonjs/sinon/compare/v12.0.1...v13.0.0)

-   [`cf3d6c0c`](https://github.com/sinonjs/sinon/commit/cf3d6c0cd9689c0ee673b3daa8bf9abd70304392)
    Upgrade packages ([#&#8203;2431](https://github.com/sinonjs/sinon/issues/2431)) (Carl-Erik Kopseng)
    > -   Update all @&#8203;sinonjs/ packages
    >
    > -   Upgrade to fake-timers 9
    >
    > -   chore: ensure always using latest LTS release
-   [`41710467`](https://github.com/sinonjs/sinon/commit/417104670d575e96a1b645ea40ce763afa76fb1b)
    Adjust deploy scripts to archive old releases in a separate branch, move existing releases out of master ([#&#8203;2426](https://github.com/sinonjs/sinon/issues/2426)) (Joel Bradshaw)
    > Co-authored-by: Carl-Erik Kopseng <carlerik@gmail.com>
-   [`c80a7266`](https://github.com/sinonjs/sinon/commit/c80a72660e89d88b08275eff1028ecb9e26fd8e9)
    Bump node-fetch from 2.6.1 to 2.6.7 ([#&#8203;2430](https://github.com/sinonjs/sinon/issues/2430)) (dependabot\[bot])
    > Co-authored-by: dependabot\[bot] <49699333+dependabot\[bot][@&#8203;users](https://github.com/users).noreply.git.luolix.top>
-   [`a00f14a9`](https://github.com/sinonjs/sinon/commit/a00f14a97dbe8c65afa89674e16ad73fc7d2fdc0)
    Add explicit export for `./*` ([#&#8203;2413](https://github.com/sinonjs/sinon/issues/2413)) (なつき)
-   [`b82ca7ad`](https://github.com/sinonjs/sinon/commit/b82ca7ad9b1add59007771f65a18ee34415de8ca)
    Bump cached-path-relative from 1.0.2 to 1.1.0 ([#&#8203;2428](https://github.com/sinonjs/sinon/issues/2428)) (dependabot\[bot])
-   [`a9ea1427`](https://github.com/sinonjs/sinon/commit/a9ea142716c094ef3c432ecc4089f8207b8dd8b6)
    Add documentation for assert.calledOnceWithMatch ([#&#8203;2424](https://github.com/sinonjs/sinon/issues/2424)) (Mathias Schreck)
-   [`1d5ab86b`](https://github.com/sinonjs/sinon/commit/1d5ab86ba60e50dd69593ffed2bffd4b8faa0d38)
    Be more general in stripping off stack frames to fix Firefox tests ([#&#8203;2425](https://github.com/sinonjs/sinon/issues/2425)) (Joel Bradshaw)
-   [`56b06129`](https://github.com/sinonjs/sinon/commit/56b06129e223eae690265c37b1113067e2b31bdc)
    Check call count type ([#&#8203;2410](https://github.com/sinonjs/sinon/issues/2410)) (Joel Bradshaw)
-   [`7863e2df`](https://github.com/sinonjs/sinon/commit/7863e2dfdbda79e0a32e42af09e6539fc2f2b80f)
    Fix [#&#8203;2414](https://github.com/sinonjs/sinon/issues/2414): make Sinon available on homepage (Carl-Erik Kopseng)
-   [`fabaabdd`](https://github.com/sinonjs/sinon/commit/fabaabdda82f39a7f5b75b55bd56cf77b1cd4a8f)
    Bump nokogiri from 1.11.4 to 1.13.1 ([#&#8203;2423](https://github.com/sinonjs/sinon/issues/2423)) (dependabot\[bot])
-   [`dbc0fbd2`](https://github.com/sinonjs/sinon/commit/dbc0fbd263c8419fa47f9c3b20cf47890a242d21)
    Bump shelljs from 0.8.4 to 0.8.5 ([#&#8203;2422](https://github.com/sinonjs/sinon/issues/2422)) (dependabot\[bot])
-   [`fb8b3d72`](https://github.com/sinonjs/sinon/commit/fb8b3d72a85dc8fb0547f859baf3f03a22a039f7)
    Run Prettier (Carl-Erik Kopseng)
-   [`12a45939`](https://github.com/sinonjs/sinon/commit/12a45939e9b047b6d3663fe55f2eb383ec63c4e1)
    Fix 2377: Throw error when trying to stub non-configurable or non-writable properties ([#&#8203;2417](https://github.com/sinonjs/sinon/issues/2417)) (Stuart Dotson)
    > Fixes issue [#&#8203;2377](https://github.com/sinonjs/sinon/issues/2377) by throwing an error when trying to stub non-configurable or non-writable properties

*Released by [Carl-Erik Kopseng](https://github.com/fatso83) on 2022-01-28.*

</details>

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-artifact-registry).
sofisl pushed a commit that referenced this pull request Sep 16, 2022
sofisl pushed a commit that referenced this pull request Oct 5, 2022
sofisl pushed a commit that referenced this pull request Oct 8, 2022
sofisl pushed a commit that referenced this pull request Oct 11, 2022
sofisl pushed a commit that referenced this pull request Oct 12, 2022
sofisl pushed a commit that referenced this pull request Oct 13, 2022
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/ba2d388f-b3b2-4ad7-a163-0c6b4d86894f/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@05de3e1
sofisl pushed a commit that referenced this pull request Oct 13, 2022
Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>

Source-Author: F. Hinkelmann <franziska.hinkelmann@gmail.com>
Source-Date: Wed Sep 30 14:13:57 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 079dcce498117f9570cebe6e6cff254b38ba3860
Source-Link: googleapis/synthtool@079dcce
sofisl pushed a commit that referenced this pull request Nov 11, 2022
* chore: update v2.14.2 gapic-generator-typescript

Committer: @summer-ji-eng
PiperOrigin-RevId: 434859890

Source-Link: googleapis/googleapis@bc2432d

Source-Link: googleapis/googleapis-gen@930b673
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
samples: pull in latest typeless bot, clean up some comments

Source-Link: https://github.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e
@release-please release-please bot mentioned this pull request Nov 12, 2022
sofisl pushed a commit that referenced this pull request Nov 16, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.6.0](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/compare/v1.5.3...v1.6.0) (2020-03-05)


### Features

* export protos in src/index.ts ([ffd77ca](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/commit/ffd77caffcec5d341517e7b82e58d1c50288ea22))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
sofisl pushed a commit that referenced this pull request Nov 16, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 18, 2022
sofisl pushed a commit that referenced this pull request Jan 10, 2023
sofisl pushed a commit that referenced this pull request Jan 17, 2023
sofisl pushed a commit that referenced this pull request Jan 24, 2023
* MicrophoneStreamTest, and basic .ava tests-

* Just cosmetic, removed some notes, added note about Event style for test.

* removed .test, cleaned up yaaarghs

* Cleaned up test within MicStream.js, .ava tests forthcoming

* Pruned down to core streaming function, yaargs rebuilt, .ava upcoming

* newest .ava test, just makes sure yaargs loads, comments addressed

* Added Readme

* BetaFeatures for Test, fixed from yesterday

* Updated Readme

* Updated Readme, fixed old paths used in testing

* Updated Readme again

* Updated Yaargs Examples to fit readme

* Fixed Diarization bug

* Speech Fixes

* fixing eslint settings to merge

* eslint again

* testing lint quick fix

* more ESlint shennanigans

* cleaned up region tags

* Removed audiochannelGCS

* Removed Comments, also multiChannel GCS

* Removed Comments, GCS MultiChannel

* Removed multi Audio Channel

* Added mono-channel multi Language file to sample

* removed old console.log

* fixed todos and filename -> fileName

* removed docstrings

* removed enableWordTimeOffsets in WordLvlConfidence

* rebuild

* fixed space

* fixed package.lock for node8 circleCI

* Attempted fix for circleCI node 8

* attempted mime-types fix

* possible mime/CLI fix

* Merged Latest package chore stuff, for circleCI

* all outstanding comments, except eslint issue

* confidence test fix

* fixed eslinting in betaFeatures.js

* eslint again

* Fixed MultiChannel transcribe

* multiChannelGCS test

* Updated readme

* updated readme, scaffolding

* readme again
sofisl pushed a commit that referenced this pull request Jan 25, 2023
* MicrophoneStreamTest, and basic .ava tests-

* Just cosmetic, removed some notes, added note about Event style for test.

* removed .test, cleaned up yaaarghs

* Cleaned up test within MicStream.js, .ava tests forthcoming

* Pruned down to core streaming function, yaargs rebuilt, .ava upcoming

* newest .ava test, just makes sure yaargs loads, comments addressed

* Added Readme

* BetaFeatures for Test, fixed from yesterday

* Updated Readme

* Updated Readme, fixed old paths used in testing

* Updated Readme again

* Updated Yaargs Examples to fit readme

* Fixed Diarization bug

* Speech Fixes

* fixing eslint settings to merge

* eslint again

* testing lint quick fix

* more ESlint shennanigans

* cleaned up region tags

* Removed audiochannelGCS

* Removed Comments, also multiChannel GCS

* Removed Comments, GCS MultiChannel

* Removed multi Audio Channel

* Added mono-channel multi Language file to sample

* removed old console.log

* fixed todos and filename -> fileName

* removed docstrings

* removed enableWordTimeOffsets in WordLvlConfidence

* rebuild

* fixed space

* fixed package.lock for node8 circleCI

* Attempted fix for circleCI node 8

* attempted mime-types fix

* possible mime/CLI fix

* Merged Latest package chore stuff, for circleCI

* all outstanding comments, except eslint issue

* confidence test fix

* fixed eslinting in betaFeatures.js

* eslint again

* Fixed MultiChannel transcribe

* multiChannelGCS test

* Updated readme

* updated readme, scaffolding

* readme again
sofisl pushed a commit that referenced this pull request Jan 26, 2023
…nsorboard services to aiplatform v1beta1. (#118)

PiperOrigin-RevId: 371996826
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Jeff Ching <chingor@google.com>
sofisl pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants