iam: Implement support #1193
Closed
iam: Implement support #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| */ | ||
| this.iam = new IAM(pubsub, this.name); | ||
| var iam; | ||
| Object.defineProperty(this, 'iam', { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
spp--1192
branch
from
aad2bb9
to
9462cc6
Compare
|
@callmehiphop when you have a chance, can you try to track down what I might be doing wrong that causes this error during the build? |
| this.iam = new IAM(pubsub, this.name); | ||
| var iam; | ||
| Object.defineProperty(this, 'iam', { | ||
| get() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
added
the
status: blocked
|
This PR has been somewhat nullified until IAM support is better supported. It may be worth pulling some code out of this PR when that happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #1192
This pulls the IAM object outside of the Pub/Sub code it's previously been buried under.
Blockers
To Dos