Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore/request: add API error handling #153

Merged
merged 5 commits into from
Aug 30, 2014
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/datastore/transaction.js
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,15 @@ Transaction.prototype.makeReq = function(method, req, respType, callback) {
buffer = Buffer.concat([buffer, chunk]);
});
resp.on('end', function() {
callback(null, respType.decode(buffer));
if (resp.statusCode != 200) {

This comment was marked as spam.

return callback({
error: 'request failed',
request: request,
response: resp,
body: buffer.toString()
}, null);
}
return callback(null, respType.decode(buffer));
});
});
remoteStream.on('error', callback);
Expand Down