Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all modules: ensure all User-Agents are set #1568

Merged
merged 7 commits into from
Sep 9, 2016
Merged

all modules: ensure all User-Agents are set #1568

merged 7 commits into from
Sep 9, 2016

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Sep 6, 2016 •
edited
Loading

To Dos

Each module will now pass its own package.json to ensure the correct UA string is set.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2016
stephenplusplus
stephenplusplus reviewed Sep 6, 2016
View reviewed changes
packages/common/src/grpc-service.js
@@ -161,6 +161,11 @@ function GrpcService(config, options) {

this.grpcMetadata = new grpc.Metadata();

this.grpcMetadata.add('User-Agent', [

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Sep 7, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 328765b on stephenplusplus:spp--user-agents into 494907c on GoogleCloudPlatform:master.

callmehiphop
callmehiphop reviewed Sep 9, 2016
View reviewed changes
packages/common/test/grpc-service.js
@@ -43,6 +44,7 @@ function fakeRetryRequest() {
return (retryRequestOverride || retryRequest).apply(null, arguments);
}


This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@callmehiphop
Copy link
Contributor

@stephenplusplus Not trying to be a pain in the butt, but could we separate this into 2 different PRs?

  1. All the @google-cloud/common updates.
  2. All the modules upgrading to the latest common + packageJson fields

The way all these changes are lumped together makes testing this locally .. challenging.

@stephenplusplus stephenplusplus mentioned this pull request Sep 9, 2016
Merged
@stephenplusplus stephenplusplus changed the title common: fix user agent strings all modules: ensure all User-Agents are set Sep 9, 2016
@stephenplusplus stephenplusplus added api: compute Issues related to the Compute Engine API. api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API. api: pubsub Issues related to the Pub/Sub API. api: bigquery Issues related to the BigQuery API. api: dns Issues related to the Cloud DNS API. don't merge api: logging Issues related to the Cloud Logging API. api: bigtable Issues related to the Bigtable API. labels Sep 9, 2016
@stephenplusplus stephenplusplus added api: translate Issues related to the Cloud Translation API. api: vision Issues related to the Cloud Vision API. api: language Issues related to the Cloud Natural Language API API. labels Sep 9, 2016
@callmehiphop
Copy link
Contributor

Looks like we're missing packageJson within PubSub/IAM

@stephenplusplus
Copy link
Contributor Author

Added.

@callmehiphop callmehiphop merged commit 48a82a9 into googleapis:master Sep 9, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e2851fc on stephenplusplus:spp--user-agents into * on GoogleCloudPlatform:master*.

sofisl pushed a commit that referenced this pull request Oct 11, 2022
@stephenplusplus @callmehiphop
all modules: ensure all User-Agents are set (#1568)
7e1f526
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@stephenplusplus @callmehiphop
all modules: ensure all User-Agents are set (#1568)
aa5c254
@sofisl sofisl mentioned this pull request Oct 12, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@stephenplusplus @sofisl
all modules: ensure all User-Agents are set (#1568)
c277dce
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@stephenplusplus @callmehiphop
all modules: ensure all User-Agents are set (#1568)
8d55dde
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 17, 2022
@stephenplusplus @callmehiphop
all modules: ensure all User-Agents are set (#1568)
b49bab0
@sofisl sofisl mentioned this pull request Nov 17, 2022
Merged
4 tasks
@sofisl sofisl mentioned this pull request Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 17, 2023
@stephenplusplus @callmehiphop
all modules: ensure all User-Agents are set (#1568)
40618a9
sofisl pushed a commit that referenced this pull request Sep 14, 2023
@stephenplusplus @callmehiphop
all modules: ensure all User-Agents are set (#1568)
7e420ea
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@callmehiphop callmehiphop

Labels
api: bigquery Issues related to the BigQuery API. api: bigtable Issues related to the Bigtable API. api: compute Issues related to the Compute Engine API. api: datastore Issues related to the Datastore API. api: dns Issues related to the Cloud DNS API. api: language Issues related to the Cloud Natural Language API API. api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. api: storage Issues related to the Cloud Storage API. api: translate Issues related to the Cloud Translation API. api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephenplusplus @coveralls @callmehiphop @murgatroid99 @googlebot