-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Gapic-generated files for cloud vision API. #1576
Introduce Gapic-generated files for cloud vision API. #1576
Conversation
} | ||
|
||
var grpcClient = gaxGrpc.load([{ | ||
root: require('google-proto-files')('..'), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
2 similar comments
@stephenplusplus the CI build fails on nodejs 0.12: /home/travis/build/GoogleCloudPlatform/google-cloud-node/packages/google-cloud/node_modules/@google-cloud/bigtable/node_modules/dot-prop/index.js: This does not seem to have anything to do with this PR. Sounds like another build flakiness issue. Can you rebuild? Is there anyway we can improve this since each time the build takes long time and we don't want to waste too much time on this. |
We simply have 3 OSes to run tests for 3 different versions of Node. Running the system tests takes a big portion of the time, the other is the installation of all of our dependencies. I have improved the performance somewhat by forcing Travis to use npm 3, which flattens the dependency tree before downloading. I think there might be room to improve if we only run the system tests for the module that the modified files affected, e.g., this PR wouldn't run Bigtable tests. I'll open a new issue to talk that through. Regarding the error itself, it was from a mistake I made yesterday, giving @google-cloud/bigtable a dependency on a module that only worked on Node > v4. I released a patch earlier today and just restarted the build. If that goes well, I'll merge this right after. Thanks! |
Fixes #1463
Fixes #1575
auto-generated:
image_annotator_api.js
image_annotator_client_config.json
v1/index.js: manually written
index.js and package.json: manually modified