Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Gapic-generated files for cloud vision API. #1576

Merged

Conversation

swcloud
Copy link
Contributor

@swcloud swcloud commented Sep 7, 2016

Fixes #1463
Fixes #1575

auto-generated:
image_annotator_api.js
image_annotator_client_config.json

v1/index.js: manually written
index.js and package.json: manually modified

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2016
@stephenplusplus stephenplusplus added the api: vision Issues related to the Cloud Vision API. label Sep 7, 2016
}

var grpcClient = gaxGrpc.load([{
root: require('google-proto-files')('..'),

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@coveralls
Copy link

coveralls commented Sep 7, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 061ca0f on swcloud:gapic-codegen-cloud-vision into a744f26 on GoogleCloudPlatform:master.

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 1f3a965 on swcloud:gapic-codegen-cloud-vision into a744f26 on GoogleCloudPlatform:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1f3a965 on swcloud:gapic-codegen-cloud-vision into a744f26 on GoogleCloudPlatform:master.

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 1f3a965 on swcloud:gapic-codegen-cloud-vision into a744f26 on GoogleCloudPlatform:master.

@swcloud
Copy link
Contributor Author

swcloud commented Sep 8, 2016

@stephenplusplus the CI build fails on nodejs 0.12:

/home/travis/build/GoogleCloudPlatform/google-cloud-node/packages/google-cloud/node_modules/@google-cloud/bigtable/node_modules/dot-prop/index.js:
const isObj = require('is-obj');
^^^^^
SyntaxError: Use of const in strict mode.

This does not seem to have anything to do with this PR. Sounds like another build flakiness issue. Can you rebuild? Is there anyway we can improve this since each time the build takes long time and we don't want to waste too much time on this.

@stephenplusplus
Copy link
Contributor

Is there anyway we can improve this since each time the build takes long time and we don't want to waste too much time on this.

We simply have 3 OSes to run tests for 3 different versions of Node. Running the system tests takes a big portion of the time, the other is the installation of all of our dependencies. I have improved the performance somewhat by forcing Travis to use npm 3, which flattens the dependency tree before downloading. I think there might be room to improve if we only run the system tests for the module that the modified files affected, e.g., this PR wouldn't run Bigtable tests. I'll open a new issue to talk that through.

Regarding the error itself, it was from a mistake I made yesterday, giving @google-cloud/bigtable a dependency on a module that only worked on Node > v4. I released a patch earlier today and just restarted the build. If that goes well, I'll merge this right after.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants