Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Connection.requester and rename req to request for clarity #158

Merged
merged 1 commit into from
Sep 2, 2014
Merged

Use Connection.requester and rename req to request for clarity #158

merged 1 commit into from
Sep 2, 2014

Conversation

ryanseys
Copy link
Contributor

Renamed req to request for clarity and less conflicts when CTRL + F'ing.

One use of req was changed to use this.requester as is done in other parts of the code.

@stephenplusplus
Copy link
Contributor

+1

rakyll pushed a commit that referenced this pull request Sep 2, 2014
Merge pull request #158 from ryanseys/use-requester
436b90c 
Use Connection.requester and rename req to request for clarity
@rakyll rakyll merged commit 436b90c into googleapis:master Sep 2, 2014
@ryanseys ryanseys deleted the use-requester branch September 2, 2014 19:02
@snyk-bot snyk-bot mentioned this pull request May 21, 2020
Open
This was referenced Jul 21, 2021
Open
Open
Open
Open
Open
Open
chingor13 pushed a commit that referenced this pull request Aug 22, 2022
@yoshi-automation @JustinBeckwith
chore: release 1.1.0 (#158)
4fd52d6 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
chingor13 pushed a commit that referenced this pull request Sep 12, 2022
@gcf-owl-bot
fix: better support for fallback mode (#158)
dc89a5c 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468790263

Source-Link: googleapis/googleapis@873ab45

Source-Link: googleapis/googleapis-gen@cb6f37a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
chingor13 pushed a commit that referenced this pull request Sep 14, 2022
@gcf-owl-bot
fix: better support for fallback mode (#158)
0b7f197 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468790263

Source-Link: googleapis/googleapis@873ab45

Source-Link: googleapis/googleapis-gen@cb6f37a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
@release-please release-please bot mentioned this pull request Sep 14, 2022
Merged
@sofisl sofisl mentioned this pull request Sep 15, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 15, 2022
@yoshi-automation @callmehiphop
build: only pipe to codecov if tests run in Node 10 (#158)
80abc69
sofisl pushed a commit that referenced this pull request Sep 27, 2022
@JustinBeckwith
chore: update license file (#158)
fc4d362
@sofisl sofisl mentioned this pull request Sep 27, 2022
Closed
4 tasks
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@JustinBeckwith
chore: udpate lint configs (#158)
652d20e
@sofisl sofisl mentioned this pull request Oct 12, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@renovate @JustinBeckwith
fix(deps): update dependency google-gax to ^0.25.0 (#158)
37d0bcc
@sofisl sofisl mentioned this pull request Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@yoshi-automation
build: add config .gitattributes (#158)
035d29a 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/e6ac0f7f-2fc1-4ac2-9eb5-23ba1215b6a2/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@dc9caca
@sofisl sofisl mentioned this pull request Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@yoshi-automation
chore: regenerate common templates (#158)
e269a3a 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/a2b9b6b0-6911-4d73-92bd-3c9c35909e3f/targets

- [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

Source-Link: googleapis/synthtool@c6706ee
Source-Link: googleapis/synthtool@b33b0e2
Source-Link: googleapis/synthtool@898b38a
@sofisl sofisl mentioned this pull request Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@gcf-owl-bot
build(node): update deps used during postprocessing (#1243) (#158)
1b615ff
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
test: use fully qualified request type name in tests (#158)
bb8df3a 
* test: use fully qualified request type name in tests

PiperOrigin-RevId: 475685359

Source-Link: googleapis/googleapis@7a12973

Source-Link: googleapis/googleapis-gen@370c729
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@alexander-fenster
fix(deps): require google-gax v2.12.0 (#158)
909bbe9
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@renovate @JustinBeckwith
fix(deps): update dependency google-gax to v1 (#158)
9db5710
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: preserve default values in x-goog-request-params header (#158)
f6ee977 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 474338479

Source-Link: googleapis/googleapis@d5d35e0

Source-Link: googleapis/googleapis-gen@efcd3f9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9
sofisl pushed a commit that referenced this pull request Nov 16, 2022
@renovate-bot
chore(deps): update dependency @types/node to v18 (#158)
a5cb368 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped)) | [`^16.0.0` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/16.18.3/18.11.9) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/compatibility-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/confidence-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-network-connectivity).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTkuMCJ9-->
@sofisl sofisl mentioned this pull request Nov 16, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 16, 2022
@JustinBeckwith
chore: update lint ignore files (#158)
78b238d
This was referenced Nov 16, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 16, 2022
@gcf-owl-bot
docs(samples): include metadata file, add exclusions for samples to h…
9f3a17b 
…andwritten libraries (#158)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 429395631

Source-Link: googleapis/googleapis@84594b3

Source-Link: googleapis/googleapis-gen@ed74f97
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
@sofisl sofisl mentioned this pull request Nov 16, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 1.6.1 (#158)
6c75511 
🤖 I have created a release *beep* *boop*
---


### [1.6.1](googleapis/nodejs-retail@v1.6.0...v1.6.1) (2022-03-15)


### Bug Fixes

* remove gcloud_project env variable ([#156](googleapis/nodejs-retail#156)) ([16cefb4](googleapis/nodejs-retail@16cefb4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Nov 17, 2022
@dpebot @JustinBeckwith
Update the kokoro config (#158)
b074de8
This was referenced Nov 17, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 18, 2022
@JustinBeckwith @bcoe
fix(deps): bump google-gax to 1.7.5 (#158)
c98f8b5
sofisl pushed a commit that referenced this pull request Jan 26, 2023
@gcf-owl-bot @bcoe
fix: add C#, PHP and Ruby options for all AI Platform protos (#158)
5984903 
PiperOrigin-RevId: 381271921
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
sofisl pushed a commit that referenced this pull request Jan 26, 2023
@release-please
chore: release 1.7.3 (#159)
d2bf244 
🤖 I have created a release \*beep\* \*boop\*
---
### [1.7.3](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.7.2...v1.7.3) (2021-06-29)


### Bug Fixes

* add C#, PHP and Ruby options for all AI Platform protos ([#158](https://www.github.com/googleapis/nodejs-ai-platform/issues/158)) ([da0babf](https://www.github.com/googleapis/nodejs-ai-platform/commit/da0babf54c6b074b8dc3d0354f8a57b9bc0cefc1))
* **deps:** google-gax v2.17.0 with mTLS ([#161](https://www.github.com/googleapis/nodejs-ai-platform/issues/161)) ([8e7d46f](https://www.github.com/googleapis/nodejs-ai-platform/commit/8e7d46f1252c4e89a663dd28b70b49bf269f091a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Jan 26, 2023
Merged
4 tasks
@enterstudio enterstudio mentioned this pull request Apr 19, 2023
Open
@enterstudio enterstudio mentioned this pull request Jun 26, 2023
Open
@sofisl sofisl mentioned this pull request Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 13, 2023
@JustinBeckwith
refactor: use execSync for tests (#158)
b238fb7
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 14, 2023
@JustinBeckwith
chore: update CircleCI config (#158)
fa12e66
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanseys @stephenplusplus @rakyll