dns: add promise support #1705
Merged
dns: add promise support #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
48 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes ahead!⚠️
Summary of changes
The following methods previously returned a
streamin the event that thecallbackparameter was omitted. This functionality has since moved to a different method entirely.DNS#getZones->DNS#getZonesStreamZone#getChanges->Zone#getChangesStreamZone#getRecords->Zone#getRecordsStreamEach callback accepting change has also been updated to return a
Promiseinstance in the event that thecallbackwas omitted.