Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix bigquery#import format correctly #1747

Closed
wants to merge 1 commit into from

Conversation

e-jigsaw
Copy link

@e-jigsaw e-jigsaw commented Oct 24, 2016

Hello,

A sample code in Bigquery#import document are incorrect. I tried and faild Job sveral times, so I investigate this issue.

  if (format) {
    metadata.sourceFormat = FORMATS[format.toLowerCase()];
    delete metadata.format;
  }

Above block remove I assigned format. :(

Please fix it.

Thanks


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2016
@@ -826,7 +826,7 @@ Table.prototype.getRows = function(options, callback) {
* //-
* var metadata = {
* encoding: 'ISO-8859-1',
* sourceFormat: 'NEWLINE_DELIMITED_JSON'
* format: 'JSON'

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@stephenplusplus stephenplusplus added docs api: bigquery Issues related to the BigQuery API. labels Oct 24, 2016
@stephenplusplus
Copy link
Contributor

I've sent a PR so that sourceFormat is honored, which was the intended behavior: #1748.

Thank you for reporting this!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5d1c04f on e-jigsaw:fix-doc into f8f713a on GoogleCloudPlatform:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants