Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc update #1762

Closed
wants to merge 1 commit into from
Closed

grpc update #1762

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 1, 2016

Fixes #1753

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 1, 2016
@stephenplusplus
Copy link
Contributor

Thank you! We don't require specifying this, however. If you un- and re-install google-cloud (or one of the sub-modules, i.e. @google-cloud/bigtable), it will pick up the latest 1.0.1. Can you try this and confirm?

@ghost
Copy link
Author

ghost commented Nov 1, 2016

Try to uninstall and reinstall google-cloud. grpc still on 1.0.0

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 1, 2016
@stephenplusplus
Copy link
Contributor

Yep, that is weird. Installing @google-cloud/bigtable pulls down the latest. It's acting as if we have a hard dependency on grpc@1.0.0 somewhere, but I don't know where. @callmehiphop any ideas?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d044f2d on Turismatic:grpc-update into 56c745b on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor

Mystery solved. We shrinkwrap our google-cloud release, so 1.0.0 is hardcoded as the dependency to install. All of our dependencies, including grpc, will be updated before we shrinkwrap for our next release, so this change isn't necessary. Thanks for calling this out, we hope to have a release out after some more PRs merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants