Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add grpc max size to troubleshooting #1767

Merged
merged 3 commits into from
Nov 4, 2016
Merged

docs: add grpc max size to troubleshooting #1767

merged 3 commits into from
Nov 4, 2016

Conversation

callmehiphop
Copy link
Contributor

Closes #1755

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2016
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Nov 3, 2016 •
edited
Loading

Can you also add a note to the methods that are the most common source of the error as well, i.e. at least bigtable/table#insert()?

stephenplusplus
stephenplusplus suggested changes Nov 3, 2016
View reviewed changes
docs/troubleshooting.md
@@ -86,3 +86,7 @@ async.eachLimit(subscriptions, PARALLEL_LIMIT, deleteSubscription, function(err)
This will only allow 10 at a time to go through, making it easier on the API to keep up with your requests.

Reference Issue: [#1101](https://github.com/GoogleCloudPlatform/google-cloud-node/issues/1101)

## GRPC received a message exceeding the max size.

This comment was marked as spam.

Sign in to view

docs/troubleshooting.md

## GRPC received a message exceeding the max size.

If you're seeing an error message saying that your grpc request is exceeding the max size, you may need to send smaller individual request. Request bodies should not exceed 4MB.

This comment was marked as spam.

Sign in to view

docs/troubleshooting.md
@@ -86,3 +86,7 @@ async.eachLimit(subscriptions, PARALLEL_LIMIT, deleteSubscription, function(err)
This will only allow 10 at a time to go through, making it easier on the API to keep up with your requests.

Reference Issue: [#1101](https://github.com/GoogleCloudPlatform/google-cloud-node/issues/1101)

This comment was marked as spam.

Sign in to view

@callmehiphop
Copy link
Contributor Author

@stephenplusplus PTAL

@stephenplusplus
Copy link
Contributor

Looks good, but I was hoping you could add a line to the actual method's JSDocs so they don't have to wait til an error to know the best practice.

@callmehiphop
Copy link
Contributor Author

Sure, I can. Do you have any other methods you'd like to add that to?

@stephenplusplus
Copy link
Contributor

Probably just any Bigtable ones that can commonly see a lot of data. Off
hand I'm not sure of other gRPC APIs that could suffer from this, so we can
wait to see if we get reports from users who are hitting this error.
On Thu, Nov 3, 2016 at 3:16 PM Dave Gramlich notifications@github.com
wrote:

Sure, I can. Do you have any other methods you'd like to add that to?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#1767 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAsIaHSO4RU0-Ga-Erk_ikfSVqhlIlTIks5q6jMhgaJpZM4KoF0k
.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c537daa on callmehiphop:grpc-max-size into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c537daa on callmehiphop:grpc-max-size into * on GoogleCloudPlatform:master*.

@stephenplusplus stephenplusplus merged commit 881ef7c into googleapis:master Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus requested changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@callmehiphop @stephenplusplus @coveralls @googlebot