Language updates #1783

callmehiphop · 2016-11-10T20:29:19Z

Updates Natural Language to 1.0 proto files!

⚠️ BLOCKED

Introduce language v1 proto and yaml file googleapis#190
A new google-proto-files release

Notable Changes

New rcp AnalyzeSyntax in the form of document#detectSyntax
Sentences can now contain sentiments
sentiment.polarity was renamed to sentiment.score
partOfSpeech received 11 new attributes
English, Japanese and Spanish now supported for all features.
There are additional changes, but generally only affect verbose mode.

Possible Conflicts (per API team review)

Multiplying values by 100 appears to be problematic. While score (polarity) returns a value between -1 and 1, magnitude is unbounded. That being said I'm not sure we're creating a meaningful number for magnitude by multiplying it.

TODO

Unit tests

callmehiphop · 2016-11-10T20:30:49Z

@stephenplusplus PTAL!

stephenplusplus · 2016-11-10T20:33:20Z

+1 on not multiplying magnitude.

callmehiphop · 2016-11-10T20:58:09Z

+1 on not multiplying magnitude.

Awesome, that being said do you think we should be consistent and not multiply score as well?

stephenplusplus · 2016-11-10T20:59:35Z

No, they're not the same value range, so we can't achieve consistency between them. All of our APIs multiply -1.0 through 1.0 ranges.

packages/language/src/document.js

@@ -196,13 +197,34 @@ Document.PART_OF_SPEECH = {
 *     text.
 * @param {object[]} callback.annotation.tokens - Parts of speech that were
 *     detected from the text.
- * @param {object[]} callback.annotation.tokens.text - The piece of text
+ * @param {string} callback.annotation.tokens[].text - The piece of text


packages/language/src/document.js

- *   //         'Google is an American multinational technology company' +
- *   //         'specializing in Internet-related services and products.'
- *   //       beginOffset: -1
+ *   //       text: {


packages/language/src/document.js

 * @param {boolean} options.verbose - Enable verbose mode for more detailed
 *     results. Default: `false`
 * @param {function} callback - The callback function.
 * @param {?error} callback.err - An error occurred while making this request.
- * @param {number} callback.sentiment - A value in the range of `-100` to `100`.
- *     Large numbers represent more positive sentiments.
+ * @param {number} callback.sentiment.sentiment - A value in the range of `-100`


packages/language/src/document.js

+ *   //         content:
+ *   //           'Google is an American multinational technology company' +
+ *   //           'specializing in Internet-related services and products.',
+ *   //         beingOffset: -1


packages/language/system-test/language.js

@@ -331,7 +359,18 @@ describe('Language', function() {
        assert.deepEqual(annotation.tokens[0], {
          text: 'Hello',
          partOfSpeech: 'Other: foreign words, typos, abbreviations',
-          partOfSpeechTag: 'X'
+          tag: 'X',
+          aspect: 'ASPECT_UNKNOWN',


jgeewax · 2016-11-11T17:21:17Z

Are we going to change the version to 1.0? Or is this meaning something else? Not sure if we're ready to say 1.0 here....

callmehiphop · 2016-11-11T17:48:05Z

@jgeewax sorry about the confusion, we're moving from the upstream v1beta1 api to the upstream v1 api. We will not be publishing the library itself as 1.0

packages/language/src/document.js

 * @param {boolean} options.verbose - Enable verbose mode for more detailed
 *     results. Default: `false`
 * @param {function} callback - The callback function.
 * @param {?error} callback.err - An error occurred while making this request.
- * @param {number} callback.sentiment - A value in the range of `-100` to `100`.
- *     Large numbers represent more positive sentiments.
+ * @param {number} callback.sentiment - A value in the range of `-100`


packages/language/src/document.js

@@ -601,8 +660,21 @@ Document.prototype.detectEntities = function(options, callback) {
 *   }
 *
 *   // sentiment = {
- *   //   polarity: 100,
- *   //   magnitude: 40
+ *   //   sentiment: {


packages/language/src/document.js

+
+    var syntax = {
+      sentences: Document.formatSentences_(resp.sentences, verbose),
+      tokens: Document.formatTokens_(resp.tokens, verbose),


coveralls · 2016-11-12T01:55:00Z

Changes Unknown when pulling 2005c08 on callmehiphop:language-updates into * on GoogleCloudPlatform:master*.

packages/language/src/document.js

+ *     text.
+ * @param {object[]} callback.syntax.tokens - Parts of speech that were
+ *     detected from the text.
+ * @param {string} callback.syntax.language - The language detected from the


packages/language/src/document.js

+ *     results. Default: `false`
+ * @param {function} callback - The callback function.
+ * @param {?error} callback.err - An error occurred while making this request.
+ * @param {object} callback.syntax - The recognizd syntax from the text.


packages/language/src/document.js

+ * @resource [documents.analyzeSyntax API Documentation]{@link https://cloud.google.com/natural-language/reference/rest/v1/documents/analyzeSyntax}
+ *
+ * @param {object=} options - Configuration object. See
+ *     [documents.annotateText](https://cloud.google.com/natural-language/reference/rest/v1/documents/analyzeSyntax#request-body).


packages/language/src/document.js

+ *   //   tokens: [
+ *   //     {
+ *   //       text: 'Google',
+ *   //       partOfSpeech: 'Noun (common and proper)'


packages/language/src/document.js

+ *   //       },
+ *   //       dependencyEdge: {
+ *   //         headTokenIndex: 1,
+ *   //         label: 'NSUBJ'


packages/language/src/document.js

+
+      for (var part in token) {
+        if (token.hasOwnProperty(part) && /UNKNOWN/.test(token[part])) {
+          token[part] = false;


stephenplusplus · 2016-11-14T15:45:43Z

Please re-assign when it's ready for another look.

stephenplusplus · 2016-11-14T17:23:02Z

LGTM. Re-assign when the blockers are cleared.

coveralls · 2016-11-14T22:08:39Z

Changes Unknown when pulling 62d397d on callmehiphop:language-updates into * on GoogleCloudPlatform:master*.

jmuk · 2016-11-14T23:55:44Z

googleapis/googleapis#190 has been merged, and the new proto is already in the master of https://github.com/googleapis/googleapis. @stephenplusplus, please update google-proto-files package.

bjwatson · 2016-11-15T00:01:38Z

@callmehiphop @jmdobry googleapis/googleapis#190 has been merged. Can one of you take care of updating google-proto-files?

jmdobry · 2016-11-15T00:21:17Z

googleapis/nodejs-proto-files#11

bjwatson · 2016-11-15T00:26:11Z

Thanks @jmdobry and @stephenplusplus.

jmdobry · 2016-11-15T00:30:33Z

Language v1 proto is available in google-proto-files v0.8.5.

bjwatson · 2016-11-15T00:32:15Z

Thanks @jmdobry.

@stephenplusplus have your requested changes been satisfied?

Also, Travis seems unhappy. Is this just flakiness?

bjwatson · 2016-11-15T00:34:21Z

Dave explained that the unhappiness is just depending on the google-proto-files update.

stephenplusplus · 2016-11-15T00:35:24Z

Yep, just update google-proto-files to 0.9.0 (@callmehiphop simultaneously published to npm).

callmehiphop · 2016-11-15T00:45:03Z

Should be good to go on this.

jmdobry · 2016-11-15T00:57:07Z

@callmehiphop Remember to get your google-proto-files 0.9.0 commit pushed to GitHub

callmehiphop · 2016-11-15T00:58:39Z

@jmdobry I ended up unpublishing it since you beat me to it :)

callmehiphop added don't merge api: language Issues related to the Cloud Natural Language API API. labels Nov 10, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2016

callmehiphop assigned stephenplusplus Nov 10, 2016

stephenplusplus suggested changes Nov 11, 2016

View reviewed changes

jmuk and others added 4 commits November 11, 2016 12:48

Language API v1

a07aaf1

language: v1 support

24f7645

leave magnitude un-altered

6d669ce

minor tweaks per PR feedback

a3f69c7

stephenplusplus reviewed Nov 11, 2016

View reviewed changes

callmehiphop commented Nov 11, 2016

View reviewed changes

packages/language/src/document.js

var syntax = {

sentences: Document.formatSentences_(resp.sentences, verbose),

tokens: Document.formatTokens_(resp.tokens, verbose),

This comment was marked as spam.

Sign in to view

callmehiphop added 2 commits November 11, 2016 16:26

added unit tests

0136ddd

minor tweaks from PR feedback

2005c08

stephenplusplus reviewed Nov 13, 2016

View reviewed changes

stephenplusplus removed their assignment Nov 14, 2016

small updates pr PR feedback

b1dee3d

callmehiphop assigned stephenplusplus Nov 14, 2016

stephenplusplus removed their assignment Nov 14, 2016

add/update tests for dependency edge label descriptions

62d397d

callmehiphop assigned stephenplusplus Nov 14, 2016

stephenplusplus added status: blocked Resolving the issue is dependent on other work. and removed don't merge labels Nov 14, 2016

stephenplusplus removed their assignment Nov 14, 2016

bjwatson assigned bjwatson and callmehiphop and unassigned bjwatson and callmehiphop Nov 14, 2016

updating proto files

657f43d

stephenplusplus removed the status: blocked Resolving the issue is dependent on other work. label Nov 15, 2016

callmehiphop assigned stephenplusplus Nov 15, 2016

stephenplusplus merged commit bd70843 into googleapis:master Nov 15, 2016

jmdobry mentioned this pull request Nov 29, 2016

Update to Language v1 googleapis/google-cloud-python#2747

Closed

sofisl pushed a commit that referenced this pull request Oct 11, 2022

language: update to v1 (#1783)

a851455

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

language: update to v1 (#1783)

11e2a05

Language updates #1783

Language updates #1783

Conversation

callmehiphop commented Nov 10, 2016 • edited Loading

⚠️ BLOCKED

Notable Changes

Possible Conflicts (per API team review)

TODO

callmehiphop commented Nov 10, 2016

stephenplusplus commented Nov 10, 2016

callmehiphop commented Nov 10, 2016

stephenplusplus commented Nov 10, 2016 • edited Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

jgeewax commented Nov 11, 2016

callmehiphop commented Nov 11, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 12, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Nov 14, 2016

stephenplusplus commented Nov 14, 2016

coveralls commented Nov 14, 2016

jmuk commented Nov 14, 2016

bjwatson commented Nov 15, 2016 • edited Loading

jmdobry commented Nov 15, 2016

bjwatson commented Nov 15, 2016

jmdobry commented Nov 15, 2016

bjwatson commented Nov 15, 2016 • edited Loading

bjwatson commented Nov 15, 2016

stephenplusplus commented Nov 15, 2016

callmehiphop commented Nov 15, 2016

jmdobry commented Nov 15, 2016

callmehiphop commented Nov 15, 2016

callmehiphop commented Nov 10, 2016 •

edited

Loading

stephenplusplus commented Nov 10, 2016 •

edited

Loading

bjwatson commented Nov 15, 2016 •

edited

Loading

bjwatson commented Nov 15, 2016 •

edited

Loading