Fix Bigtable docs references to "instances". #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove confusion between creating a "Compute Instance" (which is a GCE VM instance) vs. a Cloud Bigtable instance and cluster (which is what we need here). Updated the link to point to the correct page in the documentation, as Bigtable also has documentation for creating GCE VM instances with the correct scopes to access Bigtable instances, but that's not what we want here, and not what the code sample is trying to accomplish.
googlebot
added
the
cla: yes
|
Note: this is a comment-only change; it would be nice, if possible, to make the 0.6.0 docs reflect this as well, unless there's an imminent release of the library coming soon (though this technically affects all releases of the Bigtable Node library docs, as it's just a terminology confusion, not a change in the API). |
|
Thanks @mbrukman, I hadn't realized this changed. I think we might have a release for Bigtable come up, so I'm going to hold off on re-generating the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove confusion between creating a "Compute Instance" (which is a GCE VM
instance) vs. a Cloud Bigtable instance and cluster (which is what we need
here).
Updated the link to point to the correct page in the documentation, as Bigtable
also has documentation for creating GCE VM instances with the correct scopes to
access Bigtable instances, but that's not what we want here, and not what the
code sample is trying to accomplish.