Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system-test for GAPIC files for logging API. #1865

Closed
wants to merge 2 commits into from

Conversation

jmuk
Copy link
Contributor

@jmuk jmuk commented Dec 6, 2016

This is hand-written for now. Eventually, we will replace this
by automatically generated ones.

This is hand-written for now. Eventually, we will replace this
by automatically generated ones.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2016
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Dec 6, 2016

Some linting errors:

> jshint scripts/ packages/ system-test/ test/ && jscs packages/ system-test/ test/

packages/logging/system-test/v2.js: line 62, col 11, 'start' is defined but never used.
packages/logging/system-test/v2.js: line 113, col 37, Strings must use singlequote.
packages/logging/system-test/v2.js: line 124, col 7, Missing semicolon.
packages/logging/system-test/v2.js: line 186, col 78, 'resp' is defined but never used.

@stephenplusplus stephenplusplus added api: logging Issues related to the Cloud Logging API. testing labels Dec 6, 2016
@jmuk
Copy link
Contributor Author

jmuk commented Dec 6, 2016

Fixed lint errors.

@stephenplusplus
Copy link
Contributor

@jmuk is it possible these tests are better suited for the gax repo? As I understand this, these tests are certifying that the gax library works. But, we should always be able to assume it works, because there wouldn't have been a gax release unless tests like these passed. Does this make sense?

@jmuk
Copy link
Contributor Author

jmuk commented Dec 8, 2016

This is a bit different from gax-nodejs repo because it tests API-agnostic logic, while our code generator tests the generated files, character-by-character. This PR verifies the behaviors of generated files -- i.e. whether it's syntactically correct or not, or whether it can issue API calls correctly or not.

However we have another repository api-client-staging to store the autogen results (and actually I put the baseline of this PR already there, as https://github.com/googleapis/api-client-staging/tree/master/test/nodejs/logging). If that's good enough, I'll keep using that repository for those tests for autogen results.

Feel free to close this if that sounds good.

@stephenplusplus
Copy link
Contributor

Thanks, api-client-staging sounds like the perfect place 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants