Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate: rebrand #1885

Merged
merged 1 commit into from
Dec 27, 2016
Merged

Conversation

stephenplusplus
Copy link
Contributor

Fixes #1884

@stephenplusplus stephenplusplus added docs api: translate Issues related to the Cloud Translation API. labels Dec 14, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 14, 2016
Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just a general comment, I still see translate present throughout our code and I'm wondering if everything should be renamed to translation? (e.g. umbrella package method name, client docs, etc.)

var translate = gcloud.translate;
```

#### Using the Google Translate API module

This comment was marked as spam.


```js
var gcloud = require('google-cloud');
var translate = gcloud.translate;

This comment was marked as spam.

@stephenplusplus
Copy link
Contributor Author

RE: module and method name changes, I don't believe so, because of this part of #1884:

This does not impact the method names but the URLbase as well as readmes, samples and comments.

@callmehiphop
Copy link
Contributor

@stephenplusplus I assumed when they mentioned method names that was for the translate module. For the umbrella package we have a method specifically named translate which is what I'm wondering about

@stephenplusplus
Copy link
Contributor Author

That's funny, I thought it may have meant the reverse, since his note specifically mentioned "method names" and gcloud.translate is one :) But enough guessing, @danoscarmike, can you help us find some clarity on this:

  • do we change the module name? npm install google-cloud/translate OR npm install google-cloud/translation

  • do we change the method name? require('google-cloud').translate(...) OR require('google-cloud').translation(...)

@stephenplusplus
Copy link
Contributor Author

@callmehiphop sounds like we're keeping the names. Let's merge this 🐶 ?

@callmehiphop callmehiphop merged commit c10bc53 into googleapis:master Dec 27, 2016
sofisl pushed a commit that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: translate Issues related to the Cloud Translation API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants