-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate: rebrand #1885
translate: rebrand #1885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just a general comment, I still see translate
present throughout our code and I'm wondering if everything should be renamed to translation
? (e.g. umbrella package method name, client docs, etc.)
var translate = gcloud.translate; | ||
``` | ||
|
||
#### Using the Google Translate API module |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
||
```js | ||
var gcloud = require('google-cloud'); | ||
var translate = gcloud.translate; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
RE: module and method name changes, I don't believe so, because of this part of #1884:
|
@stephenplusplus I assumed when they mentioned method names that was for the |
That's funny, I thought it may have meant the reverse, since his note specifically mentioned "method names" and
|
@callmehiphop sounds like we're keeping the names. Let's merge this 🐶 ? |
Fixes #1884