-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1881 vision: include original Likelihood score #1887
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Thank you very much :) I think the only thing missing before we merge is an update to the docs (in the JSDocs snippet above the method) and a test to confirm we're returning the original value. If you prefer, I'm happy to do these at a later time. |
Add the original likelihood value into the response from the vision api alongside the boolean values
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@@ -960,12 +960,19 @@ Vision.prototype.detectCrops = function(images, options, callback) { | |||
* // }, | |||
* // confidence: 56.748849, | |||
* // anger: false, | |||
* // angerLikelihood: 1, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Fixes #1881
Add the original likelihood value into the response from the vision api
alongside the boolean values