Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: Fix broken abortion of outstanding requests #1961

Conversation

ctavan
Copy link

@ctavan ctavan commented Feb 3, 2017

This restores the fix from #1105
which was broken after #1070

It seems like the introduction of gRPC in #1070 broke the feature of aborting outstanding http requests when pubsub subscription listeners are removed.

This patch doesn't really add a suitable test-coverage to the pubsub testsuite yet, it just ensures that GrpcService.prototype.request returns an object which has an abort() method.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 3, 2017
@ctavan ctavan force-pushed the pubsub-fix-broken-request-abort-behavior branch from 2d6a54d to 72129dd Compare February 3, 2017 21:31
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 3, 2017
@stephenplusplus
Copy link
Contributor

Thank you for this! I had to make some other changes, so please check out PR #1973 and let me know if it looks okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants