pubsub: Fix broken abortion of outstanding requests #1961
Closed
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the fix from #1105
which was broken after #1070
It seems like the introduction of gRPC in #1070 broke the feature of aborting outstanding http requests when pubsub subscription listeners are removed.
This patch doesn't really add a suitable test-coverage to the pubsub testsuite yet, it just ensures that
GrpcService.prototype.request
returns an object which has anabort()
method.