site: make the doc link more linky. #202
Conversation
|
Dude. 🏄 I think the animation is awesome. Only thing that threw me off was that 'See the' is rather light & isn't blue. Making it blue doesn't look amazing but it certainly is a step up. Perhaps making the text darker is the best way. A change of alpha from 0.8 to 0.95 was better IMO. Before (0.8 alpha):
After (0.95 alpha):
|
|
Woo! I'm somewhat partial to the lighter gray, but I don't mind it either way. I'll wait for more weigh-ins before making any changes for now. |
|
@leomaia - please let me know your thoughts. The last thing I want to do is ruin your code and style. Happy to make any changes to maintain the integrity 👍 |
|
Certainly not a deal breaker. It's much clearer and more |
|
@stephenplusplus I liked the animation but I am not sure about the element around the icon in the middle of the phrase. I don't know what happened but the white space (padding) between the sections seems to be cut on half and this makes me not being a fan of the light grey bar for the external links either. They are all very close together. If you set this bar (.featuring-links) to display: inline-block it will stop spanning full width and will feel more comfortable for me. I made a rough example.
|
|
Looks nice to me! I'll try to re-create :) |
stephenplusplus
force-pushed
the
doc-button
branch
from
297cd57
to
7efd8bd
Compare
|
Take another look: http://stephenplusplus.github.io/gcloud-node/#/ |
|
Loving the animation. Can we keep the red button with this animation on hover please? Having a single section of buttons was making it looking slicker -- less vertical alignment issues I suppose :) |
|
Yeah animation is good but the text should change in some way when you hover. Right now it's underlined statically and that doesn't change. :( |
|
@rakyll So identical to http://googlecloudplatform.github.io/gcloud-node/#/, with just the box icon spinning on hover? |
|
@stephenplusplus, yeap, that's just my personal opinion though :) |
|
I'm against that. It looks pressed / current page. I want to see a blue link / fat button in my face to take me to documentation. Landing page is the last place we want people to abandon. And centering the button/link basically screams "CLICK ME". It's the "download me" equivalent for an API client: Sources: I'd rather it be ugly than confuse people. |
|
The button can say "Read Docs". |
|
SGTM. |
|
My thoughts on how much we are thinking about this button: (╯°□°）╯︵ ┻━┻) |
|
So where are we at? Identical to master + spinning icon + "Read the Docs" On Thursday, September 11, 2014, Ryan Seys notifications@github.com wrote:
|
|
Yes, exactly. |
|
This button is going to win awards. On Thursday, September 11, 2014, Ryan Seys notifications@github.com wrote:
|
|
I hope we bring down google analytics because people are clicking it so much. |
|
Up to the dated: http://stephenplusplus.github.io/gcloud-node/#/ |
|
|
site: make the doc link more linky.
* Adds runReport * Adds batch and pivot report samples * Updates comments * Updates comments * Removes runReport to avoid merge conflicts * Modifies formatting of tests * Modifies strings to formatted strings for consistency * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Fixes print statement in batch report * Removes readme changes * fix lint issue * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: ikuleshov <ikuleshov@google.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
…uild API has always assumed this, but now we are actually specifying it. (#202) feat: Add `ReceiveTriggerWebhook` for webhooks activating specific triggers. feat: Add `SecretManager`-related resources and messages for corresponding integration. feat: Add `COMMENTS_ENABLED_FOR_EXTERNAL_CONTRIBUTORS_ONLY` for corresponding comment control feat: Committer: @LOZORD PiperOrigin-RevId: 363244566 Source-Author: Google APIs <noreply@google.com> Source-Date: Tue Mar 16 12:32:12 2021 -0700 Source-Repo: googleapis/googleapis Source-Sha: 913f5553d5ff5940cddd8245313136449b2a3571 Source-Link: googleapis/googleapis@913f555 Co-authored-by: Megan O'Keefe <3137106+askmeegs@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v14.0.0`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#​1400) [Compare Source](https://github.com/sinonjs/sinon/compare/v13.0.2...v14.0.0) - [`c2bbd826`](https://github.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00) Drop node 12 (Morgan Roderick) > And embrace Node 18 > > See https://nodejs.org/en/about/releases/ *Released by Morgan Roderick on 2022-05-07.* </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-analytics-admin).
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/b742586e-df31-4aac-8092-78288e9ea8e7/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@bd0deaa
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jsdoc](https://github.com/jsdoc/jsdoc) | [`^3.6.4` -> `^4.0.0`](https://renovatebot.com/diffs/npm/jsdoc/3.6.11/4.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jsdoc/jsdoc</summary> ### [`v4.0.0`](https://github.com/jsdoc/jsdoc/blob/HEAD/CHANGES.md#​400-November-2022) [Compare Source](https://github.com/jsdoc/jsdoc/compare/3.6.11...084218523a7d69fec14a852ce680f374f526af28) - JSDoc releases now use [semantic versioning](https://semver.org/). If JSDoc makes backwards-incompatible changes in the future, the major version will be incremented. - JSDoc no longer uses the [`taffydb`](https://taffydb.com/) package. If your JSDoc template or plugin uses the `taffydb` package, see the [instructions for replacing `taffydb` with `@jsdoc/salty`](https://github.com/jsdoc/jsdoc/tree/main/packages/jsdoc-salty#use-salty-in-a-jsdoc-template). - JSDoc now supports Node.js 12.0.0 and later. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-bigquery-connection). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTcuMSJ9-->
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5f7f9c6d-c75a-4c60-8bb8-0026a14cead7/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@bd0deaa
* feat: auto-generate samples for GAPIC clients PiperOrigin-RevId: 398106791 Source-Link: googleapis/googleapis@4f46ddc Source-Link: googleapis/googleapis-gen@43a09fa Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDNhMDlmYWNiYTBlNWM4MGQyNTg3NzI0ZDdlZjIxYmU5MGUwYjE4YyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* build: check dead links on Kokoro * recursive crawl local links
](https://renovatebot.com){kind=link}
RE: #183
I may have gone a little overboard with this one.
http://stephenplusplus.github.io/gcloud-node/#/