Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vision: add default formatter for unknown annotation types #2044

Merged
merged 1 commit into from
Mar 2, 2017
Merged

vision: add default formatter for unknown annotation types #2044

merged 1 commit into from
Mar 2, 2017

Conversation

callmehiphop
Copy link
Contributor

Closes #2034

Quick patch fix to resolve issues until we roll out 1.1 updates.

@callmehiphop callmehiphop added the api: vision Issues related to the Cloud Vision API. label Mar 2, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2017
jmuk
jmuk approved these changes Mar 2, 2017
View reviewed changes
Copy link
Contributor

@jmuk jmuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@callmehiphop callmehiphop merged commit 1b04c1f into googleapis:master Mar 2, 2017
@stephenplusplus stephenplusplus mentioned this pull request Mar 3, 2017
Closed
@sofisl sofisl mentioned this pull request Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 17, 2023
@callmehiphop
vision: add default formatter for unknown annotation types (#2044)
bad8153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmuk jmuk jmuk approved these changes

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

Assignees
No one assigned
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vision API detectText returns TypeError: formatMethodMap[type] is not a function
3 participants
@callmehiphop @jmuk @googlebot