Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: audit #2151

Closed
wants to merge 3 commits into from
Closed

docs: audit #2151

wants to merge 3 commits into from

Conversation

callmehiphop
Copy link
Contributor

closes #2114

@callmehiphop callmehiphop added api: datastore Issues related to the Datastore API. api: logging Issues related to the Cloud Logging API. api: storage Issues related to the Cloud Storage API. docs labels Mar 29, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.924% when pulling 96f4736 on callmehiphop:dg--docs-audit into 8f51232 on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus reviewed Mar 29, 2017
View reviewed changes
Copy link
Contributor

@stephenplusplus stephenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

packages/datastore/src/query.js
@@ -200,7 +200,7 @@ Query.prototype.select = function(fieldNames) {
/**
* Set a starting cursor to a query.
*
* @resource [Query Cursors]{@link https://cloud.google.com/datastore/docs/concepts/queries#Datastore_Query_cursors}
* @resource [Query Cursors]{@link https://cloud.google.com/datastore/docs/concepts/queries#cursors_limits_and_offsets}

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus mentioned this pull request Mar 31, 2017
Merged
@stephenplusplus
Copy link
Contributor

Incorporated these into #2170. Won't mark #2114 as resolved in the new PR as you have this as don't merge, so presumably there is more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus left review comments

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. api: logging Issues related to the Cloud Logging API. api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit documentation
4 participants
@callmehiphop @coveralls @stephenplusplus @googlebot