Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage in common. #2156

Merged
merged 3 commits into from
Mar 29, 2017
Merged

Improve coverage in common. #2156

merged 3 commits into from
Mar 29, 2017

Conversation

lukesneeringer
Copy link
Contributor

This gets line coverage in common to 100% and improves branch coverage.

Improve coverage in common.
402a1ef 
This gets line coverage in common to 100% and improves branch coverage.
@lukesneeringer lukesneeringer self-assigned this Mar 29, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2017
@stephenplusplus
Copy link
Contributor

LGTM, just a few linting issues.

@lukesneeringer
Copy link
Contributor Author

In a meeting; will knock them when I get out.
I will also install a linter plugin in Atom so I catch those sooner.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.987% when pulling 3ab1b28 on lukesneeringer:common-coverage into f569e1d on GoogleCloudPlatform:master.

@lukesneeringer lukesneeringer merged commit 895529e into googleapis:master Mar 29, 2017
@lukesneeringer lukesneeringer deleted the common-coverage branch March 29, 2017 20:25
@mikolajroszak mikolajroszak mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukesneeringer lukesneeringer

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukesneeringer @stephenplusplus @coveralls @googlebot