Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodejs GAPIC: vision v1 #2227

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Nodejs GAPIC: vision v1 #2227

merged 1 commit into from
Apr 17, 2017

Conversation

lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Apr 17, 2017 •
edited by stephenplusplus
Loading

RE: #2225

This pull request was generated by artman. Please review it thoroughly before merging.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2017
@lukesneeringer
Copy link
Contributor Author

Related to #2225, and is sufficient to drop that issue to "not P0".

@lukesneeringer
Copy link
Contributor Author

@stephenplusplus After this is merged, can you cut a new patch release of Vision?

@stephenplusplus
Copy link
Contributor

For sure.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cb19b54 on vision-nodejs-v1-d00d338d into a7d8030 on master.

@lukesneeringer lukesneeringer merged commit 7921343 into master Apr 17, 2017
@lukesneeringer lukesneeringer deleted the vision-nodejs-v1-d00d338d branch April 17, 2017 16:06
@lukesneeringer
Copy link
Contributor Author

@stephenplusplus Merged. Please do the things.

@sofisl sofisl mentioned this pull request Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 17, 2023
@lukesneeringer
Nodejs GAPIC: vision v1 (#2227)
15c13be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukesneeringer @stephenplusplus @coveralls @googlebot