Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error-reporting: Add errors.report system test #2264

Merged
merged 2 commits into from
May 2, 2017
Merged

error-reporting: Add errors.report system test #2264

merged 2 commits into from
May 2, 2017

Conversation

DominicKramer
Copy link
Contributor

This change adds a system test that verifies that the
errors.report method correctly reports an error to the error
reporting console.

@DominicKramer
error-reporting: Add errors.report system test
e50f932 
This change adds a system test that verifies that the
`errors.report` method correctly reports an error to the error
reporting console.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2017
@DominicKramer DominicKramer mentioned this pull request Apr 27, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e50f932 on DominicKramer:test/system-test-verify-report into 5149126 on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus reviewed Apr 27, 2017
View reviewed changes
packages/error-reporting/utils/errors-api-transport.js
uri: [API, id, 'events'].join('/'),
method: 'DELETE'
};
self.request_(options, function(err, /* jshint unused:false */ response,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

matthewloring
matthewloring suggested changes Apr 28, 2017
View reviewed changes
packages/error-reporting/system-test/testAuthClient.js Outdated
});

it('Should correctly publish errors', function(done) {
this.timeout(TIMEOUT * 2);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/error-reporting/system-test/testAuthClient.js
});

after(function(done) {
transport.deleteAllEvents(function(err) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/error-reporting/system-test/testAuthClient.js
var rep = errItem.representative;
assert.ok(rep);
var context = rep.serviceContext;
assert.ok(context);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 57bf5e9 on DominicKramer:test/system-test-verify-report into 5149126 on GoogleCloudPlatform:master.

@DominicKramer
Copy link
Contributor Author

@stephenplusplus This is ready to land now.

@stephenplusplus stephenplusplus merged commit 0f10a12 into googleapis:master May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus left review comments

@matthewloring matthewloring matthewloring approved these changes

Assignees
No one assigned
Labels
api: error-reporting cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DominicKramer @coveralls @stephenplusplus @matthewloring @googlebot