storage: createReadStream: accept start/end offsets #327

stephenplusplus · 2014-12-09T17:51:26Z

This adds options.start and options.end to file.createReadStream, using the Range HTTP header when calling the API.

// @janesconference for a review, since it was all his idea 💡 👍

test/storage/file.js

+        (callback.onAuthorized || callback)(null, req);
+      }
+    };
+    bucket = new Bucket(options, 'bucket-name');


cristiano-belloni · 2014-12-11T09:37:48Z

+1 from me! :)

silvolu · 2014-12-15T18:28:41Z

Can we haz a regression test?

stephenplusplus · 2014-12-15T19:33:47Z

Yes, that was a good idea! I didn't turn off validation. stephenplusplus@04964bd

stephenplusplus · 2014-12-15T20:51:19Z

Fixed the bugs I introduced with the last commit (tests weren't updated to match changes I made in this PR). Squashed all the commits into one, ready for final review & merge.

silvolu · 2014-12-18T23:11:36Z

LGTM, @ryanseys ?

lib/storage/file.js

@@ -356,7 +391,7 @@ File.prototype.createReadStream = function(options) {

              throughStream.emit('error', error);
            } else {
-              throughStream.emit('complete');
+              throughStream.emit('complete', res);


ryanseys · 2014-12-22T04:20:54Z

Other than few comments, overall looks good to me.

stephenplusplus · 2014-12-22T18:26:33Z

Updated example: https://github.com/GoogleCloudPlatform/gcloud-node/pull/327/files#diff-8ce1c5ba96fca8cd68637b6416287596R250

stephenplusplus · 2014-12-22T23:07:17Z

Will rebase this, merge, tag, and push 0.12.0 tonight if everyone's okay with that? // @ryanseys @silvolu

silvolu · 2014-12-22T23:31:40Z

@stephenplusplus 0.12.0 sounds good to me

storage: createReadStream: accept start/end offsets

…327)

…or (#327) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.

* chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…327)

🤖 I have created a release \*beep\* \*boop\* --- ### [3.1.7](https://www.github.com/googleapis/nodejs-containeranalysis/compare/v3.1.6...v3.1.7) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#326](https://www.github.com/googleapis/nodejs-containeranalysis/issues/326)) ([9e3f627](https://www.github.com/googleapis/nodejs-containeranalysis/commit/9e3f62734cecd16c7bae394665b50e7212f55158)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#329](https://www.github.com/googleapis/nodejs-containeranalysis/issues/329)) ([5403fb4](https://www.github.com/googleapis/nodejs-containeranalysis/commit/5403fb42c84354d439ea8f6414b6b7e28c57f5c1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@d815daf Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:a9d166a74752226923d159cb723df53429e226c9c076dad3ca52ffd073ff3bb4 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com>

* chore(main): release 4.1.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>

…327)

* fix: fixes for dynamic routing and streaming descriptors Use gapic-generator-typescript v2.14.5. PiperOrigin-RevId: 450616838 Source-Link: googleapis/googleapis@7a47b72 Source-Link: googleapis/googleapis-gen@42cc633 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDJjYzYzMzFiYWUwYjk5ZjYxYjhlMDFhZTE1YjA1MjExNzE2YzRmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [3.0.1](googleapis/nodejs-cloudbuild@v3.0.0...v3.0.1) (2022-06-20) ### Bug Fixes * fixes for dynamic routing and streaming descriptors ([#327](googleapis/nodejs-cloudbuild#327)) ([4cf9b63](googleapis/nodejs-cloudbuild@4cf9b63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped) | [`^14.0.0` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/compatibility-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/confidence-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-recaptcha-enterprise).

PiperOrigin-RevId: 332497859 Source-Author: Google APIs <noreply@google.com> Source-Date: Fri Sep 18 12:02:05 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 8d73f9486fc193a150f6c907dfb9f49431aff3ff Source-Link: googleapis/googleapis@8d73f94

stephenplusplus reviewed Dec 9, 2014
View reviewed changes

test/storage/file.js

(callback.onAuthorized || callback)(null, req);

}

};

bucket = new Bucket(options, 'bucket-name');

This comment was marked as spam.

Sign in to view

stephenplusplus mentioned this pull request Dec 9, 2014

storage: createReadStream to support start,end? #318

Closed

stephenplusplus force-pushed the spp--download-byte-range branch from 987ee70 to 7dc9761 Compare December 10, 2014 17:57

stephenplusplus force-pushed the spp--download-byte-range branch from 7dc9761 to 04964bd Compare December 15, 2014 19:32

stephenplusplus force-pushed the spp--download-byte-range branch 2 times, most recently from cfe28da to 34c0d76 Compare December 15, 2014 20:50

stephenplusplus force-pushed the spp--download-byte-range branch from 34c0d76 to ba0782e Compare December 15, 2014 20:56

ryanseys reviewed Dec 22, 2014
View reviewed changes

stephenplusplus force-pushed the spp--download-byte-range branch from ba0782e to 15c5aa7 Compare December 22, 2014 18:25

storage: createReadStream: accept start/end offsets

cae3cb6

stephenplusplus force-pushed the spp--download-byte-range branch from 15c5aa7 to cae3cb6 Compare December 23, 2014 00:02

stephenplusplus added a commit that referenced this pull request Dec 23, 2014

Merge pull request #327 from stephenplusplus/spp--download-byte-range

a8fc8a1

storage: createReadStream: accept start/end offsets

stephenplusplus merged commit a8fc8a1 into googleapis:master Dec 23, 2014

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

feat: clean proto list, add decoded function for longrunning method (#…

59a78d4

…327)

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

fix: remove eslint, update gax, fix generated protos, run the generat…

879bb27

…or (#327) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.

sofisl pushed a commit that referenced this pull request Sep 27, 2022

chore: release 2.6.2 (#327)

747a2ae

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs(badges): tweak badge to use new preview/stable language (#1314) (#…

3fc161e

…327)

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-datalabeling #3548

Merged

migrate code from googleapis/nodejs-web-risk #3549

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-containeranalysis #3550

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

test(nodejs): remove 15 add 16 (#1322) (#327)

9db73ae

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-grafeas #3551

Merged

migrate code from googleapis/nodejs-billing-budgets #3552

Merged

migrate code from googleapis/nodejs-secret-manager #3553

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

feat: clean proto list, add decoded function for longrunning method (#…

4991a0f

…327)

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-asset #3567

Merged

migrate code from googleapis/nodejs-cloudbuild #3566

Merged

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 30, 2022

docs(nodejs): version support policy edits (#1346) (#327)

49fd108

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

chore(deps): update dependency @google-cloud/pubsub to ^0.32.0 (#327)

c0feeb7

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

build: use linkinator for docs test (#327)

0ec8fe0

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore: update license headers (#327)

0e8765d

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: createReadStream: accept start/end offsets #327

storage: createReadStream: accept start/end offsets #327

stephenplusplus commented Dec 9, 2014

This comment was marked as spam.

cristiano-belloni commented Dec 11, 2014

silvolu commented Dec 15, 2014

stephenplusplus commented Dec 15, 2014

stephenplusplus commented Dec 15, 2014

silvolu commented Dec 18, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Dec 22, 2014

stephenplusplus commented Dec 22, 2014

stephenplusplus commented Dec 22, 2014

silvolu commented Dec 22, 2014

storage: createReadStream: accept start/end offsets #327

storage: createReadStream: accept start/end offsets #327

Conversation

stephenplusplus commented Dec 9, 2014

This comment was marked as spam.

cristiano-belloni commented Dec 11, 2014

silvolu commented Dec 15, 2014

stephenplusplus commented Dec 15, 2014

stephenplusplus commented Dec 15, 2014

silvolu commented Dec 18, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Dec 22, 2014

stephenplusplus commented Dec 22, 2014

stephenplusplus commented Dec 22, 2014

silvolu commented Dec 22, 2014