Adding regression tests. #33

silvolu · 2014-07-24T17:06:10Z

Currently coverings for datastore.

@rakyll if the approach is ok I'll add to the README instructions on how to run the tests (basically configuring the export variables in run_regression_tests.sh) and I will add the tests to our build.

regression/datastore.js

+ * limitations under the License.
+ */
+
+var projectId = process.env.PROJECT_ID,


rakyll · 2014-07-24T17:27:15Z

There are more issues, but we need to remove globals like saveAllAssignedIds and saveAllMap first. Unit tests should not share any state, because running order is arbitrary.

* Coverage for datastore.

silvolu · 2014-07-24T19:35:49Z

@rakyll first bunch of review comments should be covered.

regression/datastore.js

+        saveAllMap = {};
+      ds.saveAll([key, key], [post1, post2], function(err, keys) {
+        if (err) return done(err);
+        assert(keys[0][1]);


rakyll · 2014-07-24T21:10:20Z

Added some comments. Otherwise, LGTM.

silvolu · 2014-07-24T21:54:54Z

@rakyll that test should be better now :)

rakyll · 2014-07-24T21:56:15Z

Yes, look good. Merging.

Adding regression tests.

PiperOrigin-RevId: 315786558 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed Jun 10 15:57:14 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 81226871ce438cdeec241dd81f33f796e37e1c03 Source-Link: googleapis/googleapis@8122687 Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>

* fix: flag module as GA * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update .repo-metadata.json * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.5](https://www.github.com/googleapis/nodejs-cloud-shell/compare/v1.0.4...v1.0.5) (2021-08-30) ### Bug Fixes * flag module as GA ([#33](https://www.github.com/googleapis/nodejs-cloud-shell/issues/33)) ([cf357c8](https://www.github.com/googleapis/nodejs-cloud-shell/commit/cf357c81140d75b3c7106dc747bac328da247363)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

@alexander-fenster

Committer: @alexander-fenster PiperOrigin-RevId: 372656503 Source-Link: googleapis/googleapis@6fa858c Source-Link: googleapis/googleapis-gen@d7c95df

🤖 I have created a release \*beep\* \*boop\* --- ### [1.1.1](https://www.github.com/googleapis/nodejs-cloud-tpu/compare/v1.1.0...v1.1.1) (2021-08-25) ### Bug Fixes * flag module as GA ([#32](https://www.github.com/googleapis/nodejs-cloud-tpu/issues/32)) ([80ee7de](https://www.github.com/googleapis/nodejs-cloud-tpu/commit/80ee7deaa87856edab4e65f8a21caaf9b8d49ba7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.4](https://www.github.com/googleapis/nodejs-private-catalog/compare/v1.0.3...v1.0.4) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#32](https://www.github.com/googleapis/nodejs-private-catalog/issues/32)) ([20fe51a](https://www.github.com/googleapis/nodejs-private-catalog/commit/20fe51a9f2f588c744847905954cd16cc0e4a2bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

#33) * build(node): add feat in node post-processor to add client library version number in snippet metadata Co-authored-by: Benjamin E. Coe <bencoe@google.com> Source-Link: googleapis/synthtool@d337b88 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>

* updated CHANGELOG.md * updated package.json * updated samples/package.json

PiperOrigin-RevId: 334870265 Source-Author: Google APIs <noreply@google.com> Source-Date: Thu Oct 1 12:16:35 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: aa72330a8d16d281df131e8d37bb1a4bde53401f Source-Link: googleapis/googleapis@aa72330

🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-bigquery-connection/compare/v1.1.0...v1.2.0) (2020-10-17) ### Features * add aws connection support ([#33](https://www.github.com/googleapis/nodejs-bigquery-connection/issues/33)) ([13fecb8](https://www.github.com/googleapis/nodejs-bigquery-connection/commit/13fecb87d0191a4654f14604164072570f640dc6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

* samples: add quickstart * sync quickstart to README.md * rm console.log * update README.md * npm run fix

* feat: generating GAPIC code for v1p2beta1

* Add Speech Recognition v1p1beta1 samples * Upgrade eslint-plugin-prettier to ^2.6.0

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 507603203 Source-Link: https://github.com/googleapis/googleapis/commit/a4f2de456480c0a4ed9feeeaa1f8ee620bbef23a Source-Link: https://github.com/googleapis/googleapis-gen/commit/dcf882154e7c710ecf2a1abc77b35c95f9062371 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGNmODgyMTU0ZTdjNzEwZWNmMmExYWJjNzdiMzVjOTVmOTA2MjM3MSJ9 BEGIN_NESTED_COMMIT chore: update .gitignore to always include protos folder Use gapic-generator-typescript v3.0.0. PiperOrigin-RevId: 507004755 Source-Link: https://github.com/googleapis/googleapis/commit/d784f3c1043616fc0646e9ce7afa1b9161cc02de Source-Link: https://github.com/googleapis/googleapis-gen/commit/5e64ba8615f65fdedb1fcd6ac792e5ea621027e4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWU2NGJhODYxNWY2NWZkZWRiMWZjZDZhYzc5MmU1ZWE2MjEwMjdlNCJ9 END_NESTED_COMMIT BEGIN_NESTED_COMMIT chore: update import paths for Go targets to match open source location chore: update go_package in protos to match open source location chore: add explicit release levels to Go gapic targets PiperOrigin-RevId: 506711567 Source-Link: https://github.com/googleapis/googleapis/commit/d02e58244db5d01607ec2ad52a47e7edce8612f0 Source-Link: https://github.com/googleapis/googleapis-gen/commit/7f1c54153125eb5abd60a32de58cfda6a798a70a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2YxYzU0MTUzMTI1ZWI1YWJkNjBhMzJkZTU4Y2ZkYTZhNzk4YTcwYSJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITfeat: Added SuggestConversationSummary RPC docs: updated go library package PiperOrigin-RevId: 501862436 Source-Link: https://github.com/googleapis/googleapis/commit/155e0f4123ba003055587768944a47498c48926b Source-Link: https://github.com/googleapis/googleapis-gen/commit/3051f617a991c274c88d27064e803095e4ef9d39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzA1MWY2MTdhOTkxYzI3NGM4OGQyNzA2NGU4MDMwOTVlNGVmOWQzOSJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITchore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java) PiperOrigin-RevId: 493113566 Source-Link: https://github.com/googleapis/googleapis/commit/758f0d1217d9c7fe398aa5efb1057ce4b6409e55 Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9 END_NESTED_COMMIT

rakyll reviewed Jul 24, 2014
View reviewed changes

regression/datastore.js

* limitations under the License.

*/

var projectId = process.env.PROJECT_ID,

This comment was marked as spam.

Sign in to view

Adding regression tests.

c7c3688

* Coverage for datastore.

rakyll reviewed Jul 24, 2014
View reviewed changes

regression/datastore.js

saveAllMap = {};

ds.saveAll([key, key], [post1, post2], function(err, keys) {

if (err) return done(err);

assert(keys[0][1]);

This comment was marked as spam.

Sign in to view

Simplified test for multiple entities

e7225a3

rakyll pushed a commit that referenced this pull request Jul 24, 2014

Merge pull request #33 from silvolu/master

3cc03a8

Adding regression tests.

rakyll merged commit 3cc03a8 into googleapis:master Jul 24, 2014

snyk-bot mentioned this pull request May 21, 2020

[Snyk] Upgrade google-auto-auth from 0.2.4 to 0.10.1 aknuds1/gcloud-node#2

Open

sofisl pushed a commit that referenced this pull request Sep 15, 2022

chore: ignore package-lock.json (#33)

bec8502

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

fix: update all dependencies (#33)

001390f

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-memcache #3412

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-service-control #3609

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: update gapic-generator-typescript to v1.3.2 (#33)

731f1e3

Committer: @alexander-fenster PiperOrigin-RevId: 372656503 Source-Link: googleapis/googleapis@6fa858c Source-Link: googleapis/googleapis-gen@d7c95df

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dms #3611

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(nodejs): update client ref docs link in metadata (#33)

a78e466

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-cloud-tpu #3612

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-private-catalog #3616

Merged

4 tasks

sofisl mentioned this pull request Nov 12, 2022

migrate code from googleapis/nodejs-ids #3617

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 12, 2022

chore: add api_shortname and library_type to repo metadata (#33)

2ccaa79

sofisl mentioned this pull request Nov 12, 2022

migrate code from googleapis/nodejs-filestore #3619

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 16, 2022

chore: release 1.1.1 (#33)

4d05f14

* updated CHANGELOG.md * updated package.json * updated samples/package.json

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl pushed a commit that referenced this pull request Nov 18, 2022

samples: add quickstart (#33)

007e3e3

* samples: add quickstart * sync quickstart to README.md * rm console.log * update README.md * npm run fix

sofisl pushed a commit that referenced this pull request Jan 10, 2023

fix(deps): use google-gax v3.5.2 (#33)

e378de0

This was referenced Jan 10, 2023

migrate code from googleapis/nodejs-run #3838

Merged

migrate code from googleapis/nodejs-vision #3860

Merged

sofisl pushed a commit that referenced this pull request Jan 17, 2023

feat: generating GAPIC code for v1p2beta1 (#33)

ec6a135

* feat: generating GAPIC code for v1p2beta1

sofisl pushed a commit that referenced this pull request Jan 24, 2023

Add Speech Recognition v1p1beta1 samples (#33)

c68a228

* Add Speech Recognition v1p1beta1 samples * Upgrade eslint-plugin-prettier to ^2.6.0

sofisl pushed a commit that referenced this pull request Jan 25, 2023

Add Speech Recognition v1p1beta1 samples (#33)

a18c0f9

* Add Speech Recognition v1p1beta1 samples * Upgrade eslint-plugin-prettier to ^2.6.0

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-apigee-registry #4654

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore: one more workaround for repo-tools EPERM (#33)

27542d6

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

takeratta mentioned this pull request Nov 28, 2023

[Snyk] Fix for 8 vulnerabilities takeratta/google-cloud-node#23

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding regression tests. #33

Adding regression tests. #33

silvolu commented Jul 24, 2014

This comment was marked as spam.

rakyll commented Jul 24, 2014

silvolu commented Jul 24, 2014

This comment was marked as spam.

rakyll commented Jul 24, 2014

silvolu commented Jul 24, 2014

rakyll commented Jul 24, 2014