Return Error object for failed Api requests and fixed flaky test. #36

silvolu · 2014-07-24T23:33:32Z

No description provided.

* Order in returned objects is coherent with returned keys, but not necessarily with the keys passed as input.

lib/datastore/index.js

@@ -302,7 +302,9 @@ Transaction.prototype.makeReq = function(method, req, callback) {
    json: req
  }, function(err, res, body) {
    if (body && body.error) {
-      return callback(body.error, null);
+      var error = new Error(body.error.errors[0].reason + ': ' +


silvolu · 2014-07-25T01:26:26Z

@rakyll what about doing it this way?

rakyll · 2014-07-25T01:42:25Z

LGTM

Return Error object for failed Api requests and fixed flaky test.

* chore: lock files maintenance * chore: lock files maintenance

* chore: removing node7 job from CircleCI * chore: rename reference

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/37f383f8-7560-459e-b66c-def10ff830cb/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@b10590a

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/c503f640-90ae-4547-bcc8-a154d32c609e/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@15013ef

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v14.0.0`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#1400) [Compare Source](https://github.com/sinonjs/sinon/compare/v13.0.2...v14.0.0) - [`c2bbd826`](https://github.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00) Drop node 12 (Morgan Roderick) > And embrace Node 18 > > See https://nodejs.org/en/about/releases/ *Released by Morgan Roderick on 2022-05-07.* </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-ids).

…36)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped) | [`^9.0.9` -> `^10.0.0`](https://renovatebot.com/diffs/npm/@types%2fsinon/9.0.11/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fsinon/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fsinon/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fsinon/10.0.0/compatibility-slim/9.0.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fsinon/10.0.0/confidence-slim/9.0.11)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-managed-identities).

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

docs: update jsdoc comments

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jsdoc](https://github.com/jsdoc/jsdoc) | [`^3.5.5` -> `^4.0.0`](https://renovatebot.com/diffs/npm/jsdoc/3.6.11/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/compatibility-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/confidence-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jsdoc/jsdoc</summary> ### [`v4.0.0`](https://github.com/jsdoc/jsdoc/blob/HEAD/CHANGES.md#400-November-2022) [Compare Source](https://github.com/jsdoc/jsdoc/compare/3.6.11...084218523a7d69fec14a852ce680f374f526af28) - JSDoc releases now use [semantic versioning](https://semver.org/). If JSDoc makes backwards-incompatible changes in the future, the major version will be incremented. - JSDoc no longer uses the [`taffydb`](https://taffydb.com/) package. If your JSDoc template or plugin uses the `taffydb` package, see the [instructions for replacing `taffydb` with `@jsdoc/salty`](https://github.com/jsdoc/jsdoc/tree/main/packages/jsdoc-salty#use-salty-in-a-jsdoc-template). - JSDoc now supports Node.js 12.0.0 and later. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-run).

🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.1.0...v1.2.0) (2021-01-09) ### Features * adds cleaner utility for orphaned resources ([#34](https://www.github.com/googleapis/nodejs-ai-platform/issues/34)) ([7c09258](https://www.github.com/googleapis/nodejs-ai-platform/commit/7c09258eb99d9c40ba7bf28b6d84434d6bb8a5b9)) * adds style enumeration ([#37](https://www.github.com/googleapis/nodejs-ai-platform/issues/37)) ([81c1515](https://www.github.com/googleapis/nodejs-ai-platform/commit/81c15150f55c4ef20359c1e48530f2c9bcd0f64b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* feat!: change default version to v1beta1 Release-As: v0.4.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: changing format of the jsdoc links PiperOrigin-RevId: 509352615 Source-Link: googleapis/googleapis@b737d30 Source-Link: googleapis/googleapis-gen@8efadf3 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGVmYWRmM2Q1ODc4MGVhMWM1NTAyNjhkNDZhM2RjNzAxYmEzN2ZjZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: Add SQL translation service to Bazel generation PiperOrigin-RevId: 512937316 Source-Link: googleapis/googleapis@178674c Source-Link: googleapis/googleapis-gen@131f327 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTMxZjMyNzEyNTZlMGE3YTJhYjk2ZDQyNTQwZWYwNWM5Y2FjZWM3ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

silvolu added 2 commits July 24, 2014 16:23

Create Error object for errors returned in the response body.

b8f93a8

Fixed flaky test for Datastore.getAll().

da5ddcc

* Order in returned objects is coherent with returned keys, but not necessarily with the keys passed as input.

rakyll reviewed Jul 25, 2014
View reviewed changes

Added custom error class for api errors

200c38e

rakyll pushed a commit that referenced this pull request Jul 25, 2014

Merge pull request #36 from silvolu/master

61db807

Return Error object for failed Api requests and fixed flaky test.

rakyll merged commit 61db807 into googleapis:master Jul 25, 2014

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

chore(deps): update dependency eslint-plugin-node to v8 (#36)

42d5022

chingor13 pushed a commit that referenced this pull request Aug 26, 2022

chore: disable renovate dependency dashboard (#1194) (#36)

58a8770

chingor13 pushed a commit that referenced this pull request Sep 13, 2022

chore: disable renovate dependency dashboard (#1194) (#36)

f7d942d

sofisl pushed a commit that referenced this pull request Sep 15, 2022

chore: do not use npm ci (#36)

0c71ff7

This was referenced Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

migrate code from googleapis/nodejs-os-login #3366

Closed

sofisl pushed a commit that referenced this pull request Sep 16, 2022

Add synth.py and update google-gax (#36)

5fa4ea8

sofisl pushed a commit that referenced this pull request Sep 27, 2022

chore: lock files maintenance (#36)

36cbe69

* chore: lock files maintenance * chore: lock files maintenance

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

Add synth.py and update google-gax (#36)

a87d501

This was referenced Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

migrate code from googleapis/nodejs-os-login #3389

Closed

sofisl pushed a commit that referenced this pull request Oct 8, 2022

Add synth.py and update google-gax (#36)

12c1934

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 11, 2022

chore: removing node7 job from CircleCI (#36)

ff4f6b4

* chore: removing node7 job from CircleCI * chore: rename reference

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

migrate code from googleapis/nodejs-memcache #3412

Merged

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-bigquery-reservation #3413

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore(deps): update dependency mocha to v9 (#36)

344e529

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-cloud-shell #3415

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(nodejs): update client ref docs link in metadata (#36)

01eed97

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-essential-contacts #3615

Merged

migrate code from googleapis/nodejs-private-catalog #3616

Merged

sofisl mentioned this pull request Nov 12, 2022

migrate code from googleapis/nodejs-ids #3617

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 12, 2022

docs(badges): tweak badge to use new preview/stable language (#1314) (#…

1d1b9f6

…36)

This was referenced Nov 12, 2022

migrate code from googleapis/nodejs-filestore #3619

Merged

migrate code from googleapis/nodejs-managed-identities #3642

Merged

sofisl pushed a commit that referenced this pull request Nov 16, 2022

chore: release 1.1.2 (#36)

955658d

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

sofisl pushed a commit that referenced this pull request Nov 16, 2022

chore(deps): update dependency webpack-cli to v4 (#36)

1bea5af

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl pushed a commit that referenced this pull request Nov 18, 2022

docs: update jsdoc comments (#36)

773b278

docs: update jsdoc comments

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-run #3838

Merged

4 tasks

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

sofisl mentioned this pull request Feb 23, 2023

chore: migrate code from googleapis/nodejs-dataform #4015

Merged

4 tasks

release-please bot mentioned this pull request Feb 23, 2023

chore: release main #4017

Merged

This was referenced Sep 13, 2023

migrate code from googleapis/nodejs-apigee-registry #4654

Merged

migrate code from googleapis/nodejs-automl #4655

Closed

sofisl pushed a commit that referenced this pull request Sep 13, 2023

Update the CI config (#36)

e04c7c2

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore: test on node10 (#36)

d8585ec

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return Error object for failed Api requests and fixed flaky test. #36

Return Error object for failed Api requests and fixed flaky test. #36

silvolu commented Jul 24, 2014

This comment was marked as spam.

This comment was marked as spam.

silvolu commented Jul 25, 2014

rakyll commented Jul 25, 2014

Return Error object for failed Api requests and fixed flaky test. #36

Return Error object for failed Api requests and fixed flaky test. #36

Conversation

silvolu commented Jul 24, 2014

This comment was marked as spam.

This comment was marked as spam.

silvolu commented Jul 25, 2014

rakyll commented Jul 25, 2014