Use pubsub v1beta2 #433

ryanseys · 2015-03-07T17:46:23Z

This PR updates PubSub to v1beta2. Some of the parameters for calls have changed to match the API in hopes that it more understandable.

I've also made a couple changes that are irrespective of the change in API:

When pulling messages to be emitted on the event listener, pull for the maximum number of messages and emit each one received rather than pulling 1 message at a time. This greatly increases the throughput of messages and reduces the overhead of making the JSON request for each message individually.
Added Subscription#setAckDeadline to set the deadline for a message. I've added respective unit and regression tests in this PR.

Note: We have still left out PushConfig various usage and endpoints from this API.

Fixes #414

lib/pubsub/subscription.js

- *   //     ackId: '', // ID used to acknowledge its receival.
- *   //     id: '',    // Unique message ID.
- *   //     data: ''   // Contents of the message.
+ *   //     ackId: '',     // ID used to acknowledge its receival.


stephenplusplus · 2015-03-10T14:45:48Z

When pulling messages to be emitted on the event listener, pull for the maximum number of messages and emit each one received rather than pulling 1 message at a time. This greatly increases the throughput of messages and reduces the overhead of making the JSON request for each message individually.

👍

lib/pubsub/subscription.js

+ * var options = {
+ * 	ackId: 123,
+ * 	seconds: 10 // Expire in 10 seconds from call.
+ * }


stephenplusplus · 2015-03-10T15:03:40Z

It looks great! I left non-issue comments on formatting and phrasing, but after settling those, we're both driving straight to big green button city.

ryanseys · 2015-03-10T15:09:41Z

PTAL at the latest diff in this PR for my fixes.

Use pubsub v1beta2

…ongrunning (#433)

🤖 I have created a release \*beep\* \*boop\* --- ## [3.12.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.11.0...v3.12.0) (2021-02-09) ### Features * **samples:** add samples for analyzeIamPolicy and analyzeIamPolicyLongrunning ([#433](https://www.github.com/googleapis/nodejs-asset/issues/433)) ([dfbd75c](https://www.github.com/googleapis/nodejs-asset/commit/dfbd75c98f2977d3a9af06e7637c005b82eda973)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…ncy versions (#433) Source-Author: Megan Potter <57276408+feywind@users.noreply.github.com> Source-Date: Fri Sep 11 18:47:00 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: fdd03c161003ab97657cc0218f25c82c89ddf4b6 Source-Link: googleapis/synthtool@fdd03c1

Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com> Source-Author: F. Hinkelmann <franziska.hinkelmann@gmail.com> Source-Date: Wed Sep 30 14:13:57 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 079dcce498117f9570cebe6e6cff254b38ba3860 Source-Link: googleapis/synthtool@079dcce

gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2ae671ee-21a8-4bed-96cc-bdcf6b4638b5/targets - [ ] To automatically regenerate this PR, check this box.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e

…andwritten libraries (#433) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9

* feat: accept google-gax instance as a parameter Please see the documentation of the client constructor for details. PiperOrigin-RevId: 470332808 Source-Link: googleapis/googleapis@d4a2367 Source-Link: googleapis/googleapis-gen@e97a1ac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: use _gaxModule when accessing gax for bundling PiperOrigin-RevId: 470911839 Source-Link: googleapis/googleapis@3527566 Source-Link: googleapis/googleapis-gen@f16a1d2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: use gapic-generator-typescript v2.17.0 PiperOrigin-RevId: 474338479 Source-Link: googleapis/googleapis@d5d35e0 Source-Link: googleapis/googleapis-gen@efcd3f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * test: use fully qualified request type name in tests PiperOrigin-RevId: 475685359 Source-Link: googleapis/googleapis@7a12973 Source-Link: googleapis/googleapis-gen@370c729 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: owlbot post-processing for grafeas * fix: add Grafeas import back Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alexander Fenster <fenster@google.com>

…ongrunning (#433)

🤖 I have created a release \*beep\* \*boop\* --- ## [3.12.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.11.0...v3.12.0) (2021-02-09) ### Features * **samples:** add samples for analyzeIamPolicy and analyzeIamPolicyLongrunning ([#433](https://www.github.com/googleapis/nodejs-asset/issues/433)) ([dfbd75c](https://www.github.com/googleapis/nodejs-asset/commit/dfbd75c98f2977d3a9af06e7637c005b82eda973)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore(main): release 4.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/160598ca-4f95-425c-8b33-df656c4049e4/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@901ddd4 Source-Link: googleapis/synthtool@f96d3b4

Use pubsub v1beta2

1233ac6

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 7, 2015

jgeewax reviewed Mar 9, 2015
View reviewed changes

stephenplusplus reviewed Mar 10, 2015
View reviewed changes

lib/pubsub/subscription.js

* var options = {

* ackId: 123,

* seconds: 10 // Expire in 10 seconds from call.

* }

This comment was marked as spam.

Sign in to view

Fix documentation issues for pubsub v1beta2

27ebdc1

stephenplusplus added a commit that referenced this pull request Mar 10, 2015

Merge pull request #433 from ryanseys/pubsub-v1beta2

7fb3c17

Use pubsub v1beta2

stephenplusplus merged commit 7fb3c17 into googleapis:master Mar 10, 2015

ryanseys deleted the pubsub-v1beta2 branch March 18, 2015 17:24

snyk-bot mentioned this pull request Jan 29, 2022

[Snyk] Upgrade chalk from 2.4.2 to 5.0.0 RebelTat/google-cloud-node#2

Open

mikolajroszak mentioned this pull request May 7, 2022

[Snyk] Upgrade chalk from 2.4.2 to 5.0.1 mikolajroszak/google-cloud-node#3

Open

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

feat(samples): add samples for analyzeIamPolicy and analyzeIamPolicyL…

8cfb843

…ongrunning (#433)

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 27, 2022

chore: update npm scripts and synth.py (#433)

de71591

Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Nov 9, 2022

chore: update npm scripts and synth.py (#433)

17cf704

Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

sofisl pushed a commit that referenced this pull request Nov 10, 2022

chore: release 3.1.0 (#433)

d01036b

sofisl pushed a commit that referenced this pull request Nov 10, 2022

build: use bazel build (#433)

0cd51c3

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-tasks #3530

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-dataproc #3533

Merged

migrate code from googleapis/nodejs-cloud-container #3543

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: new owl bot post processor docker image (#433)

273cec1

gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

migrate code from googleapis/nodejs-monitoring #3545

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-scheduler #3547

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-containeranalysis #3550

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

feat(samples): add samples for analyzeIamPolicy and analyzeIamPolicyL…

5fff30f

…ongrunning (#433)

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-asset #3567

Merged

migrate code from googleapis/nodejs-talent #3568

Merged

sofisl added a commit that referenced this pull request Nov 17, 2022

build!: update to latest version of gts and typescript (#433)

765db4a

This was referenced Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl pushed a commit that referenced this pull request Nov 18, 2022

chore: fix the wrong post processor image (#433)

4cf93c2

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use pubsub v1beta2 #433

Use pubsub v1beta2 #433

ryanseys commented Mar 7, 2015

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Mar 10, 2015

This comment was marked as spam.

stephenplusplus commented Mar 10, 2015

ryanseys commented Mar 10, 2015

Use pubsub v1beta2 #433

Use pubsub v1beta2 #433

Conversation

ryanseys commented Mar 7, 2015

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Mar 10, 2015

This comment was marked as spam.

stephenplusplus commented Mar 10, 2015

ryanseys commented Mar 10, 2015