storage: add getSignedPolicy function to generate a signed policy #502

mziccard · 2015-04-15T21:04:03Z

Added a function to generate a signed policy for POST requests.
So far it supports several conditions (according to the docs):

Equality: ["eq", "$<field>", "<value>"]
Starts with: ["starts-with", "$<field>", "<value>"]
Content length: ["content-length-range", <min_range>, <max_range>]
Bucket: {"bucket": "<bucket_name>"}
Acl: {"acl": "<acl_name>"}
Success redirect: {"success_action_redirect": "<url>"}
Success status: {"success_action_status": "<status>"}

Documentation is provided describing function arguments.
Unit tests are added.

… and fixes

lib/storage/file.js

+ * *[Reference](http://goo.gl/JWJEkG).*
+ *
+ * @throws {Error} if an expiration timestamp from the past is given or 
+ *     option parameter does not respect


test/storage/file.js

+          assert(signedPolicy.string.indexOf(conditionString) > -1);
+          done();
+        });
+      });


stephenplusplus · 2015-04-20T13:57:56Z

All looks good to me. Thanks for adding this @mziccard!

@ryanseys anything left to resolve before merge? I'll handle the small style issues, so we don't bug him with that :)

mziccard · 2015-04-20T14:07:47Z

@stephenplusplus Feel free to bug me:)

BTW, I think it is still open for discussion whether to move this method to Bucket (allowing signed policies not associated to a specific filename) or not.

Adding a regression test might be useful as well.

lib/storage/file.js

+  var conditions = []; 
+
+  // Populate eq conditions
+  if (options.equals && options.equals instanceof Array) {


… equality and prefix conditions as 1D array. Docs updated accordingly. Added tests.

mziccard · 2015-04-20T23:11:55Z

Should be ok now, even the boring stuff :)
Both

file.getSignedPolicy({
  equals: ['$Content-Type', 'image/jpeg']
  // ...

and

file.getSignedPolicy({
  equals: [['$Content-Type', 'image/jpeg']]
  // ...

are now supported if only one condition is specified. (also for startsWith condition).

lib/storage/file.js

+        conditions.push(['eq', condition[0], condition[1]]);
+      });
+    }
+  }


stephenplusplus · 2015-04-20T23:31:00Z

Thank you very much!

…as 1D array

mziccard · 2015-04-23T20:14:55Z

Everything ok on my side, are there any more thoughts?

test/storage/file.js

+          expiration: expiration,
+          startsWith: [['$<field>', '<value>']]
+        }, function(err, signedPolicy) {
+          console.log(signedPolicy);


ryanseys · 2015-04-27T02:00:04Z

Just a couple console.logs left in the tests, but otherwise looks ready for merge! :)

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7a1b0b96-8ddb-4836-a1a2-d2f73b7e6ffe/targets - [ ] To automatically regenerate this PR, check this box.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/541df317-e090-4c6d-88b9-3f79f53b8d13/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@57c23fa

…502)

…n API (#502)

🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.4](https://www.github.com/googleapis/nodejs-monitoring/compare/v2.1.3...v2.1.4) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#501](https://www.github.com/googleapis/nodejs-monitoring/issues/501)) ([a923606](https://www.github.com/googleapis/nodejs-monitoring/commit/a9236060fdd4516e5f3fa31a5bf76895ad8bf6c1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

…e in region tag (#502) * docs(samples): add auto-generated samples for Node with api short name in region tag PiperOrigin-RevId: 399287285 Source-Link: googleapis/googleapis@1575986 Source-Link: googleapis/googleapis-gen@b27fff6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjI3ZmZmNjIzYTVkOGQ1ODZiNzAzYjVlNDkxOTg1NmFiZTdjMmViMyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com> Source-Author: F. Hinkelmann <franziska.hinkelmann@gmail.com> Source-Date: Wed Sep 30 14:13:57 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 079dcce498117f9570cebe6e6cff254b38ba3860 Source-Link: googleapis/synthtool@079dcce

* chore(main): release 6.3.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.2](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.1...v2.4.2) (2021-05-12) ### Bug Fixes * **deps:** require google-gax v2.12.0 ([#501](https://www.github.com/googleapis/nodejs-automl/issues/501)) ([f88cc91](https://www.github.com/googleapis/nodejs-automl/commit/f88cc915df6ac67f7dc46fa345d9fc481b12d7da)) * use require() to load JSON protos ([#504](https://www.github.com/googleapis/nodejs-automl/issues/504)) ([4cd9585](https://www.github.com/googleapis/nodejs-automl/commit/4cd9585da11b3a9189ed8f3f0e5ddc76c578a462)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…502)

mziccard added 5 commits April 14, 2015 12:00

Baseline implementation of getSignedPolicy

f3fdbab

Add support getSignedPolicy for contentLengthRange, minor refactoring…

0afc1a0

… and fixes

Fixed and extended getSignedPolicy example and docs

f98c200

Add getSignedPolicy tests

2dda343

Merge remote-tracking branch 'upstream/master' into signed-policy

cca9d4c

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2015

ryanseys reviewed Apr 15, 2015
View reviewed changes

lib/storage/file.js

* *[Reference](http://goo.gl/JWJEkG).*

*

* @throws {Error} if an expiration timestamp from the past is given or

* option parameter does not respect

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Fixed missing text in getSignedPolicy docs

79f1002

ryanseys reviewed Apr 15, 2015
View reviewed changes

test/storage/file.js

assert(signedPolicy.string.indexOf(conditionString) > -1);

done();

});

});

This comment was marked as spam.

Sign in to view

Added spaces for consistency between getSignedPolicy tests

6e30060

stephenplusplus reviewed Apr 20, 2015
View reviewed changes

lib/storage/file.js

var conditions = [];

// Populate eq conditions

if (options.equals && options.equals instanceof Array) {

This comment was marked as spam.

Sign in to view

getSignedPolicy code refactoring and comments removal. Allowed single…

2f3de3e

… equality and prefix conditions as 1D array. Docs updated accordingly. Added tests.

stephenplusplus reviewed Apr 20, 2015
View reviewed changes

lib/storage/file.js

conditions.push(['eq', condition[0], condition[1]]);

});

}

}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

getSignedPolicy refactoring of single equality and prefix conditions …

a7fa2f6

…as 1D array

ryanseys reviewed Apr 27, 2015
View reviewed changes

test/storage/file.js

expiration: expiration,

startsWith: [['$<field>', '<value>']]

}, function(err, signedPolicy) {

console.log(signedPolicy);

This comment was marked as spam.

Sign in to view

Removed console.log form getSignedPolicy tests

c7eefbc

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

build(node): update deps used during postprocessing (#1243) (#502)

ec62e9b

sofisl pushed a commit that referenced this pull request Oct 13, 2022

build(node): update deps used during postprocessing (#1243) (#502)

2b107b0

sofisl pushed a commit that referenced this pull request Nov 9, 2022

chore: release 3.1.2 (#502)

b75c9f6

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-tasks #3530

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(nodejs): remove api-extractor dependencies (#502)

09b4bb1

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-dataproc #3533

Merged

migrate code from googleapis/nodejs-cloud-container #3543

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs(badges): tweak badge to use new preview/stable language (#1314) (#…

7b3c555

…502)

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

migrate code from googleapis/nodejs-monitoring #3545

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

feat: Add sample codes for cloud-iot-token-service generateAccessToke…

1751f84

…n API (#502)

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(nodejs): remove api-extractor dependencies (#502)

10f079e

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-asset #3567

Merged

migrate code from googleapis/nodejs-kms #3601

Merged

This was referenced Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

docs(badges): tweak badge to use new preview/stable language (#1314) (#…

e84fd98

…502)

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: add getSignedPolicy function to generate a signed policy #502

storage: add getSignedPolicy function to generate a signed policy #502

mziccard commented Apr 15, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Apr 20, 2015

mziccard commented Apr 20, 2015

This comment was marked as spam.

mziccard commented Apr 20, 2015

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Apr 20, 2015

mziccard commented Apr 23, 2015

This comment was marked as spam.

ryanseys commented Apr 27, 2015

storage: add getSignedPolicy function to generate a signed policy #502

storage: add getSignedPolicy function to generate a signed policy #502

Conversation

mziccard commented Apr 15, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Apr 20, 2015

mziccard commented Apr 20, 2015

This comment was marked as spam.

mziccard commented Apr 20, 2015

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Apr 20, 2015

mziccard commented Apr 23, 2015

This comment was marked as spam.

ryanseys commented Apr 27, 2015