Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to CRC module and fix self register #512

Merged
merged 2 commits into from
Apr 28, 2015
Merged

Update to CRC module and fix self register #512

merged 2 commits into from
Apr 28, 2015

Conversation

ryanseys
Copy link
Contributor

Inherits from #488

anandsuresh and others added 2 commits April 9, 2015 11:07
@anandsuresh
Update CRC module to SSE4_CRC32 v3.1.0
4a0e81e 
- v3.1.0 fixes issues with hardware CRC detection and provides software fallbalck
for platforms lacking hardware CRC support.
- Reduces the number of layers between core code and the CRC functions
@ryanseys
Fix self-register of crc32c
3d6e163
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 27, 2015
@ryanseys
Copy link
Contributor Author

Fear not, dear @googlebot.

@ryanseys
Copy link
Contributor Author

@anandsuresh Will wait for Travis to confirm this actually works, then will merge and close other PR.

@anandsuresh
Copy link
Contributor

Aaah! I see now that Mockery needed to be told about the new module in order to get that to work. My bad. I didn't realize that was a requirement.

Having said that, a more descriptive error message might have made this easier. 😫

@ryanseys
Copy link
Contributor Author

Yeah something like that. I don't actually know much about the register and deregister system in node regarding requiring modules and caches and all that jazz, but this seemed to fix it on my machine so I'm running with it. I believe it's an issue because it's required both inside the test file and the file.js. That combined with the fact that it's a native module on node 0.12.0 is a recipe for disaster.

@stephenplusplus
Copy link
Contributor

It passed! It passed!

ryanseys added a commit that referenced this pull request Apr 28, 2015
@ryanseys
Merge pull request #512 from ryanseys/fix-self-register
cb65e34 
Update to CRC module and fix self register
@ryanseys ryanseys merged commit cb65e34 into googleapis:master Apr 28, 2015
@ryanseys ryanseys deleted the fix-self-register branch April 28, 2015 00:53
@ryanseys
Copy link
Contributor Author

:D

@anandsuresh
Copy link
Contributor

Yaay!! Finally done! :)

@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@yoshi-automation
build(node_library): migrate to Trampoline V2 (#512)
2c6d141 
Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Fri Oct 2 12:13:27 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 0c868d49b8e05bc1f299bc773df9eb4ef9ed96e9
Source-Link: googleapis/synthtool@0c868d4
@sofisl sofisl mentioned this pull request Oct 12, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@gcf-owl-bot
docs(badges): tweak badge to use new preview/stable language (#1314) (#…
407a638 
…512)
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@yoshi-automation @sofisl
build(node_library): migrate to Trampoline V2 (#512)
f7b1e49 
Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Fri Oct 2 12:13:27 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 0c868d49b8e05bc1f299bc773df9eb4ef9ed96e9
Source-Link: googleapis/synthtool@0c868d4
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@gcf-owl-bot @sofisl
docs(badges): tweak badge to use new preview/stable language (#1314) (#…
2bd2988 
…512)
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@JustinBeckwith
chore: remove tslint.json (#512)
acdd471
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@renovate-bot
chore(deps): update dependency @types/node to v14 (#512)
a8439e4 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped) | [`^12.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/12.20.13/14.17.0) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/compatibility-slim/12.20.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/confidence-slim/12.20.13)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-text-to-speech).
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: reverting unintentional breaking change: GetOpenIdConfigRequest,…
80d64c6 
… GetOpenIdConfigResponse (#512)

* fix: reverting unintentional breaking change: GetOpenIdConfigRequest, GetOpenIdConfigResponse

PiperOrigin-RevId: 424115592

Source-Link: googleapis/googleapis@853e8a2

Source-Link: googleapis/googleapis-gen@8e17f77
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGUxN2Y3N2ZiOWU0ODQzODQ1YmYwZWUxZDQ2NmRjZWUwMDFjYzJjNCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@bcoe
fix(build): migrate to main branch (#512)
fe9ba6e
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
docs: update dates (#512)
fc936d0 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/d365a9d3-f86e-4598-8272-bbf6b821e385/targets

- [ ] To automatically regenerate this PR, check this box.
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 1.1.2 (#512)
1049737
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@fhinkel
chore(cloud-rad): delete api-extractor config (#512)
0658c9e
@sofisl sofisl mentioned this pull request Nov 18, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 18, 2022
@release-please @gcf-owl-bot
chore(main): release 7.0.0 (#512)
b02c977 
* chore(main): release 7.0.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this pull request Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 13, 2023
@renovate-bot
chore(deps): update dependency sinon to v11 (#512)
2699e05 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^10.0.0` -> `^11.0.0`](https://renovatebot.com/diffs/npm/sinon/10.0.0/11.1.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/compatibility-slim/10.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/confidence-slim/10.0.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v11.1.0`](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md#&#8203;1110--2021-05-25)

[Compare Source](https://github.com/sinonjs/sinon/compare/v11.0.0...31be9a5d5a4762ef01cb195f29024616dfee9ce8)

\==================

-   Add sinon.promise() implementation ([#&#8203;2369](https://github.com/sinonjs/sinon/issues/2369))
-   Set wrappedMethod on getters/setters ([#&#8203;2378](https://github.com/sinonjs/sinon/issues/2378))
-   \[Docs] Update fake-server usage & descriptions ([#&#8203;2365](https://github.com/sinonjs/sinon/issues/2365))
-   Fake docs improvement ([#&#8203;2360](https://github.com/sinonjs/sinon/issues/2360))
-   Update nise to 5.1.0 (fixed [#&#8203;2318](https://github.com/sinonjs/sinon/issues/2318))

### [`v11.0.0`](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md#&#8203;1100--2021-05-24)

[Compare Source](https://github.com/sinonjs/sinon/compare/v10.0.1...v11.0.0)

\==================

-   Explicitly use samsam 6.0.2 with fix for [#&#8203;2345](https://github.com/sinonjs/sinon/issues/2345)
-   Update most packages ([#&#8203;2371](https://github.com/sinonjs/sinon/issues/2371))
-   Update compatibility docs ([#&#8203;2366](https://github.com/sinonjs/sinon/issues/2366))
-   Update packages (includes breaking fake-timers change, see [#&#8203;2352](https://github.com/sinonjs/sinon/issues/2352))
-   Warn of potential memory leaks ([#&#8203;2357](https://github.com/sinonjs/sinon/issues/2357))
-   Fix clock test errors

### [`v10.0.1`](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md#&#8203;1001--2021-04-08)

[Compare Source](https://github.com/sinonjs/sinon/compare/v10.0.0...v10.0.1)

\==================

-   Upgrade sinon components (bumps y18n to 4.0.1)
-   Bump y18n from 4.0.0 to 4.0.1

</details>

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-automl).
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanseys @googlebot @anandsuresh @stephenplusplus